[PHP-DOC] Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING

2011-11-22 Thread Pierre Joye
Please document them as deprecated and mention that they always return false (obviously :) On Tue, Nov 22, 2011 at 2:29 PM, Peter Cowburn wrote: > Hi docs folks, > > What are your thoughts on how to treat the > get_magic_quotes_(gpc|runtime) functions, in the documentation. > Traditionally we mar

Re: [PHP-DOC] Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING

2011-11-22 Thread Ferenc Kovacs
If we want to remove them in 5.5 (or whatever we end up after 5.4), then it should be documented as deprecated, even if we don't raise E_DEPRECATED for now. On Tue, Nov 22, 2011 at 2:44 PM, Pierrick Charron wrote: > I personally think that we should do both. As of 5.4 > get_magic_quotes_* are ma

[PHP-DOC] Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING

2011-11-22 Thread Pierrick Charron
I personally think that we should do both. As of 5.4 get_magic_quotes_* are mark them as deprecated to discourage people using it and will always return false. Thanks Pierrick On 22 November 2011 08:29, Peter Cowburn wrote: > Hi docs folks, > > What are your thoughts on how to treat the > get_ma

[PHP-DOC] Re: [PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ UPGRADING

2011-11-22 Thread Peter Cowburn
Hi docs folks, What are your thoughts on how to treat the get_magic_quotes_(gpc|runtime) functions, in the documentation. Traditionally we mark functions as deprecated if they're deprecated in the code (e.g. PHP_DEP_FE), but that's not the case for these two. Should we just say in the change log