Voytsekhovskyy Alexander wrote:
Good day.
you too

As far as some small adjustments can be input into the documentation, i
would like to correct all discrepancies and divergencies. During the  work
some questions had appeared. Let's discuss them using the following example -
features/file-upload.xml:
1. there are 3 different ways of writing:
a) some text <literal>PHP 4.2.0</literal> some text
b) some text <literal>PHP</literal> 4.2.0 some text
c) some text PHP 4.2.0 some text
Which way is correct?
For example, do we need tag <literal> in the next text "In PHP versions prior to 4.1.0 
this was
named"?

I'd say b) but Damien [1] proposed some new entities to have a consistant manual. One of these entity is &php; that is defined as '<literal>PHP</literal>'. This way we'll always write "Some text &php; 4.2.0"


2. there are 3 different ways of writing:
a) the <literal>MAX_FILE_SIZE</literal> item
b) he MAX_FILE_SIZE hidden field
Which way is correct?

a)

3. Article <term><varname>UPLOAD_ERR_INI_SIZE</varname></term> describes
constant, using tag <varname>. In the PCRE documentation notation
<term><constant>UPLOAD_ERR_INI_SIZE</constant></term> or
<term>UPLOAD_ERR_INI_SIZE</term> is used.


Since UPLOAD_ERR_INI_SIZE is a constant, we should use :
  <term><constant>UPLOAD_ERR_INI_SIZE</constant></term>

4. As I understand the line "$_FILES['userfile']['size'] as 0" should be such
"<varname>$_FILES['userfile']['size']</varname> as
<literal>0</literal>" (am i mistaken?)

You seem right for me.

Other questions seem to be clear for me, and if you don't mind, I will
send diff-files with corrections during my work.

Great, it will be really appreciated, but please, have a look at [1], you maybe don't need to take care of the "<literal>PHP</literal>" stuff.


Regards,

didou

[1] - http://news.php.net/article.php?group=php.doc&article=969360648
  • Voytsekhovskyy Alexander
    • Mehdi Achour

Reply via email to