[piccolo2d-dev] Re: Release Piccolo2D.Java 1.3

2010-02-26 Thread cmal...@pixelzoom.com
Doh. Make that "oppose 1.3-rc3", not "1.3-rc4". Chris On Feb 26, 7:16 pm, "cmal...@pixelzoom.com" wrote: > Well, apparently we (PhET) didn't have as much consensus as I thought. > I should have waited to comment until we had more internal discussion. > > The new feeling is that we rely heavily o

[piccolo2d-dev] Re: Release Piccolo2D.Java 1.3

2010-02-26 Thread cmal...@pixelzoom.com
Well, apparently we (PhET) didn't have as much consensus as I thought. I should have waited to comment until we had more internal discussion. The new feeling is that we rely heavily on PSwing, and 163 is therefore pretty important. We've seen it cause serious problems in at least one application,

[piccolo2d-dev] Re: Release Piccolo2D.Java 1.3

2010-02-26 Thread cmal...@pixelzoom.com
My client (PhET) uses PSwing quite heavily. But I'm not going to -1 in order to get the 163 fix, for 3 reasons: (1) The consensus within PhET is that we're comfortable with patching our 1.3 copy to resolve 163. (2) Imho PSwing needs an internal overhaul, to bring the code up to the standards of Pic

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Updates: Status: Verified Comment #6 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Marked as verified. -- You received this message because you are listed in the owner or CC fields of thi

[piccolo2d-dev] Re: [VOTE] Release Piccolo2D.Java 1.3

2010-02-26 Thread Michael Heuer
Michael Heuer wrote: > Vote will close at 12:00 GMT Friday 26 February 2010. I would like to extend to vote deadline until Monday 01 March 2010 to allow for feedback on recently fixed issues 163 and 165. The current vote would pass as it stands and the fixes for those issues would not be release

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #5 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Verified that r973 solves the problem, both in TestPSwingDynamicComponent and the PhET application where this was first noticed. Note t

[piccolo2d-dev] Re: Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related

2010-02-26 Thread piccolo2d
Updates: Status: Accepted Comment #3 on issue 166 by heue...@gmail.com: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 False alarm, issue 165 was fixed by r974, not this one. -- You received this message because you are listed in the o

[piccolo2d-dev] Re: Issue 165 in piccolo2d: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveInBackOf(PNode)

2010-02-26 Thread piccolo2d
Updates: Status: Fixed Comment #2 on issue 165 by heue...@gmail.com: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveInBackOf(PNode) http://code.google.com/p/piccolo2d/issues/detail?id=165 Oops, trying out the new svn commit message

[piccolo2d-dev] [piccolo2d] r974 committed - Issue 166 ; improved javadoc comments for moveToFront and related. Fi...

2010-02-26 Thread piccolo2d
Revision: 974 Author: heuermh Date: Fri Feb 26 13:55:45 2010 Log: Issue 166 ; improved javadoc comments for moveToFront and related. Fixes issue 166. http://code.google.com/p/piccolo2d/source/detail?r=974 Modified: /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java =

[piccolo2d-dev] Re: Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related

2010-02-26 Thread piccolo2d
Updates: Status: Fixed Comment #2 on issue 166 by heue...@gmail.com: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 This issue was closed by revision r974. -- You received this message because you are listed in the owner or CC fields o

[piccolo2d-dev] Re: Issue 165 in piccolo2d: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveInBackOf(PNode)

2010-02-26 Thread piccolo2d
Updates: Status: Accepted Labels: Type-Defect Priority-Medium Effort-Low OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-1.3 Comment #1 on issue 165 by heue...@gmail.com: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveIn

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Updates: Status: Fixed Comment #4 on issue 163 by allain.lalonde: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Fixed in r973 -- You received this message because you are listed in the owner or CC fields of this issue, or beca

[piccolo2d-dev] [piccolo2d] r973 committed - Fix for Issue 163 changes in size of node itself were being detected, ...

2010-02-26 Thread piccolo2d
Revision: 973 Author: allain.lalonde Date: Fri Feb 26 13:32:02 2010 Log: Fix for Issue 163 changes in size of node itself were being detected, but not changes in the size of its progeny. I'm not entirely sure why a method called "ancestorResized" gets called when a subcomponent changes... bu

[piccolo2d-dev] Re: Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related

2010-02-26 Thread piccolo2d
Updates: Labels: Milestone-2.0 Type-Enhancement Priority-Low OpSys-All Effort-Low Toolkit-Piccolo2D.Java Component-Core Usability Comment #1 on issue 166 by allain.lalonde: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 Unless you keep the

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #3 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 On second thought, I might -1 the 1.3-rc3 because of Issue 165, so let's see if we can get this fixed quickly. -- You received this message

[piccolo2d-dev] Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related

2010-02-26 Thread piccolo2d
Status: New Owner: New issue 166 by heue...@gmail.com: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 I would like to rename & refactor the Z-order methods in PNode to the following Methods that change the Z-order of this void raise(); v

[piccolo2d-dev] Issue 165 in piccolo2d: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveInBackOf(PNode)

2010-02-26 Thread piccolo2d
Status: New Owner: New issue 165 by heue...@gmail.com: Bad javadoc for PNode.moveToFront(), PNode.moveToBack(), PNode.moveInFrontOf(PNode) and PNode.moveInBackOf(PNode) http://code.google.com/p/piccolo2d/issues/detail?id=165 The javadoc descriptions for PNode.moveToFront(), PNode.moveToB

[piccolo2d-dev] Re: Issue 164 in piccolo2d: PNode#moveToFront change to avoid java.util.ConcurrentModificationException

2010-02-26 Thread piccolo2d
Comment #1 on issue 164 by heue...@gmail.com: PNode#moveToFront change to avoid java.util.ConcurrentModificationException http://code.google.com/p/piccolo2d/issues/detail?id=164 I vote to mark this as WontFix. The method is throwing ConcurrentModificationException because that's what is h

[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly

2010-02-26 Thread piccolo2d
Comment #2 on issue 163 by heue...@gmail.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 I confirm that this happens with 1.3-rc3. If you add TestPSwingDynamicComponent.java, line 64: + piccoloLabelPanel.invalidate(); + piccoloLab