Author: pradeepkth Date: Fri Feb 12 00:43:17 2010 New Revision: 909191 URL: http://svn.apache.org/viewvc?rev=909191&view=rev Log: minor changes in comments and removed unused vars from PigStorage
Modified: hadoop/pig/branches/load-store-redesign/src/org/apache/pig/LoadFunc.java hadoop/pig/branches/load-store-redesign/src/org/apache/pig/builtin/PigStorage.java Modified: hadoop/pig/branches/load-store-redesign/src/org/apache/pig/LoadFunc.java URL: http://svn.apache.org/viewvc/hadoop/pig/branches/load-store-redesign/src/org/apache/pig/LoadFunc.java?rev=909191&r1=909190&r2=909191&view=diff ============================================================================== --- hadoop/pig/branches/load-store-redesign/src/org/apache/pig/LoadFunc.java (original) +++ hadoop/pig/branches/load-store-redesign/src/org/apache/pig/LoadFunc.java Fri Feb 12 00:43:17 2010 @@ -118,8 +118,8 @@ /** * Retrieves the next tuple to be processed. Implementations should NOT reuse - * tuple objects they return across calls and should return a different tuple - * object in each call. + * tuple objects (or inner member objects) they return across calls and + * should return a different tuple object in each call. * @return the next tuple to be processed or null if there are no more tuples * to be processed. * @throws IOException if there is an exception while retrieving the next @@ -265,12 +265,12 @@ /** * This method will be called by Pig both in the front end and back end to - * pass a unique signature to the {...@link LoadFunc} which it can use to store - * information in the {...@link UDFContext} which it needs to store between - * various method invocations in the front end and back end. A use case is - * to store {...@link RequiredFieldList} passed to it in - * {...@link LoadPushDown#pushProjection(RequiredFieldList)} for use in the - * back end before returning tuples in {...@link LoadFunc#getNext()} + * pass a unique signature to the {...@link LoadFunc}. The signature can be used + * to store into the {...@link UDFContext} any information which the + * {...@link LoadFunc} needs to store between various method invocations in the + * front end and back end. A use case is to store {...@link RequiredFieldList} + * passed to it in {...@link LoadPushDown#pushProjection(RequiredFieldList)} for + * use in the back end before returning tuples in {...@link LoadFunc#getNext()} * @param signature a unique signature to identify this LoadFunc */ public void setUDFContextSignature(String signature) { Modified: hadoop/pig/branches/load-store-redesign/src/org/apache/pig/builtin/PigStorage.java URL: http://svn.apache.org/viewvc/hadoop/pig/branches/load-store-redesign/src/org/apache/pig/builtin/PigStorage.java?rev=909191&r1=909190&r2=909191&view=diff ============================================================================== --- hadoop/pig/branches/load-store-redesign/src/org/apache/pig/builtin/PigStorage.java (original) +++ hadoop/pig/branches/load-store-redesign/src/org/apache/pig/builtin/PigStorage.java Fri Feb 12 00:43:17 2010 @@ -72,13 +72,9 @@ protected final Log mLog = LogFactory.getLog(getClass()); private String signature; - long end = Long.MAX_VALUE; private byte fieldDel = '\t'; private ArrayList<Object> mProtoTuple = null; private TupleFactory mTupleFactory = TupleFactory.getInstance(); - private static final int OS_UNIX = 0; - private static final int OS_WINDOWS = 1; - private static final String UTF8 = "UTF-8"; private static final int BUFFER_SIZE = 1024; public PigStorage() {