[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771188#action_12771188
]
Olga Natkovich commented on PIG-953:
+1 on the patch assuming that the all the failures
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12763218#action_12763218
]
Ashutosh Chauhan commented on PIG-953:
--
Changes look good. One comment I have:
1) In
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12763256#action_12763256
]
Ashutosh Chauhan commented on PIG-953:
--
..aah.. I should have had dug more in jdk
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760710#action_12760710
]
Pradeep Kamath commented on PIG-953:
Dmitriy,
I looked at the ResourceSchema proposed in
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760423#action_12760423
]
Pradeep Kamath commented on PIG-953:
Here is a proposal for dealing with Sort Column
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760116#action_12760116
]
Ashutosh Chauhan commented on PIG-953:
--
Changes look good. Couple of points:
bq. I think
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12754671#action_12754671
]
Ashutosh Chauhan commented on PIG-953:
--
1. [Pradeep] zebra store function would basically
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12754811#action_12754811
]
Ashutosh Chauhan commented on PIG-953:
--
And couple more:
8.
bq. Findbugs complains about
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753801#action_12753801
]
Dmitriy V. Ryaboy commented on PIG-953:
---
Pradeep,
First, I think this is very important
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753827#action_12753827
]
Pradeep Kamath commented on PIG-953:
I see the first part as a coding style preference - I
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753833#action_12753833
]
Dmitriy V. Ryaboy commented on PIG-953:
---
I got my trues and falses reversed on the NPE
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753843#action_12753843
]
Alan Gates commented on PIG-953:
-1 to adding an orderPreserving flag on operators. We have
[
https://issues.apache.org/jira/browse/PIG-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753850#action_12753850
]
Olga Natkovich commented on PIG-953:
+1 on what Alan said
Enable merge join in pig to
13 matches
Mail list logo