Re: [Piglit] [PATCH 2/2] Add test to verify the functionality of polygon stipple with multisample FBO

2012-06-16 Thread Paul Berry
On 12 June 2012 12:42, Anuj Phogat wrote: > Test assumes that MSAA accuracy test already passes. > > Signed-off-by: Anuj Phogat > My comments on the previous patch apply to this one as well. Assuming they are addressed, Reviewed-by: Paul Berry > --- > tests/all.tests

Re: [Piglit] [PATCH 1/2] Add test to verify the functionality of glBitmap() with multisample FBO

2012-06-16 Thread Paul Berry
On 12 June 2012 12:40, Anuj Phogat wrote: > glBitmap() is expected to work exactly the same way on multisample FBO as > it works on single sample FBO. Test assumes that MSAA accuracy test already > passes. > > Signed-off-by: Anuj Phogat > --- > tests/all.tests

Re: [Piglit] [PATCH 4/4] Add test to verify sample alpha to one with multisample fbo

2012-06-16 Thread Paul Berry
On 8 June 2012 14:46, wrote: > From: Anuj Phogat > > This test varifies that with GL_SAMPLE_ALPHA_TO_ONE enabled, each sample's > alpha value is replaced by maximum alpha value i.e. 1.0. > This test is: Reviewed-by: Paul Berry I would recommend adding two additional tests, preferably in sepa

Re: [Piglit] [PATCH 3/4] Add test to verify sample alpha to coverage with multisample fbo

2012-06-16 Thread Paul Berry
On 8 June 2012 14:45, wrote: > From: Anuj Phogat > > This test varifies that with GL_SAMPLE_ALPHA_TO_COVERAGE enabled, the > coverage > value is set by fragment alpha value. Coverage value decides the number of > samples in multisample buffer covered by an incoming fragment, which > receive > th

Re: [Piglit] [PATCH 2/4] Add test to verify glSampleCoverage with multisample fbo

2012-06-16 Thread Paul Berry
On 8 June 2012 14:43, Anuj Phogat wrote: > This test varifies that the coverage value set by glSampleCoverage() > decides > the number of samples in multisample buffer covered by an incoming > fragment, > which will receive the fragment data. > This test seems to assume that the coverage specifi