[Piglit] [PATCH] Alter shader_runner GL/GLSL ES version requirement syntax.

The current syntax isn't compatible with the same shader_test supporting GL and GLES in the future. Modify existing GL ES tests to use the new syntax, and remove explicit #version directives, which will instead be inserted based on GLSL >= requirements. v2 Added check for trailing chars. Formatti

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

On Wed, Jan 16, 2013 at 12:07 AM, Carl Worth wrote: > Marek Olšák writes: >> The series is: Reviewed-by: Marek Olšák > > Thanks for the review, Marek. > >> I hope other tests are not broken by this change in the util code. > > That's a good point. I do expect my commits to cause some test result

Re: [Piglit] [PATCH 1/1] Alter shader_runner GL/GLSL ES version requirement syntax.

Apologies for the poorly constructed patch email. My hope is to ban explicit #version strings entirely, because otherwise we'll end up with tests that needlessly break with certain APIs. The simplest way to avoid unnecessary #version strings appearing is to make shader_runner reject them all. Th

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

Marek Olšák writes: > The series is: Reviewed-by: Marek Olšák Thanks for the review, Marek. > I hope other tests are not broken by this change in the util code. That's a good point. I do expect my commits to cause some test results to change from PASS to FAIL, (since the whole point of this ex

Re: [Piglit] test KHR_gl_image v2

Abdiel Janulgue writes: > This test is a bit more comprehensive and now adds cubemap > support. I've also tried to address the comments. > > Let me know if I still overlooked something. :) So, this is a good start on testing this extension. Other things we definitely want: - Test all those err

Re: [Piglit] [PATCH v2] KHR image from texture test

Abdiel Janulgue writes: > +#include > + > +#define WIDTH 448 > +#define HEIGHT 448 Just fold this #define into the config below, since it's never reused. Oh, and this happens to be TEXTURE_SIZE * (number of texture levels, which is 7, and that's why tex_box is divided by 7), right? It took me

Re: [Piglit] (no subject)

On 01/06/2013 06:12 AM, Marek Olšák wrote: Since we now have a GL 2.1 driver with MSAA support - r300g, I had to port most MSAA tests to GL 2.1, while not affecting the tests that *really* need GL 3. I have verified that the expected and reported precision of the accuracy tests wasn't changed, e

Re: [Piglit] [PATCH 2/6] MSAA tests: port all GLSL shaders to GLSL 1.20

On Wed, Jan 9, 2013 at 8:57 PM, Paul Berry wrote: > On 6 January 2013 06:12, Marek Olšák wrote: >> >> --- >> tests/spec/ext_framebuffer_multisample/common.cpp | 126 >> >> .../draw-buffers-common.cpp| 52 +--- >> .../ext_framebuffer_multisampl

Re: [Piglit] [PATCH] tests/es3conform.tests: run GTF for GLES3 tests

On Tue, Jan 15, 2013 at 4:09 AM, Jordan Justen wrote: > From: Kenneth Graunke > > [jordan.l.jus...@intel.com: use -minfmt rather than -id=77] > Signed-off-by: Jordan Justen > --- > tests/es3conform.tests | 80 > > 1 file changed, 80 insertions

Re: [Piglit] [PATCH] glsl-mat-attribute: Use result of link status check.

On 01/15/2013 12:15 AM, Vinson Lee wrote: Fixes unchecked return value defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/shaders/glsl-mat-attribute.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/shaders/glsl-mat-attribute.c b/tests/shaders/glsl

Re: [Piglit] [PATCH] texelFetch: Fix incorrect sizeof.

On 01/14/2013 10:47 PM, Vinson Lee wrote: On Mon, Jan 14, 2013 at 7:24 AM, Brian Paul wrote: On 01/11/2013 12:28 AM, Vinson Lee wrote: Fixes sizeof not portable defect reported by Coverity. Fixes allocator sizeof operand mismatch bug reported by Clang Static Analyzer. Signed-off-by: Vinson