[Piglit] [PATCH] arb_uniform_buffer_object: Fix tests with clarifications from Khronos

2013-01-21 Thread Ian Romanick
From: Ian Romanick OpenGL ES 3.0 (and presumably other versions of OpenGL) have two requirements that these tests expect to be violated: 1. Members of a uniform block that are not used will not be marked active. 2. It is an error to apply a row_major or column_major layout qualifier to a non-ma

[Piglit] [PATCH] glx-multithread-makecurrent: Fix expected values if the visual has alpha.

2013-01-21 Thread Eric Anholt
We don't ask for alpha, but if we got alpha bits anyway we would probe unexpected values. --- tests/glx/glx-multithread-makecurrent-1.c |4 ++-- tests/glx/glx-multithread-makecurrent-2.c |2 +- tests/glx/glx-multithread-makecurrent-3.c |2 +- tests/glx/glx-multithread-makecurrent-4.c |

[Piglit] [PATCH 2/2] shader_runner.c only read one [require] section

2013-01-21 Thread Tom Gall
When shader_runner parses the shader_test data file, only parse one [required] section, no longer parse the rest of the file. v2: better description. Remove warning. Signed-off-by: Tom Gall --- tests/shaders/shader_runner.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[Piglit] [PATCH 1/2] shader_runner.py Update regex to detect new require section syntax

2013-01-21 Thread Tom Gall
With commit dadf56dad25730556e36e9446aabfc80458cc12f the syntax for the [require] section in the shader test data files changed for GL ES. This patch, updates the shader_runner.py regex to also understand the new syntax since this code parses the [require] section of the shader test data file to d

[Piglit] [PATCH 2/3] gl-3.0: remove explit 100 x 100 window size

2013-01-21 Thread Brian Paul
--- .../gl-3.0/api/bindfragdata-invalid-parameters.c |3 --- tests/spec/gl-3.0/api/bindfragdata-link-error.c|3 --- .../gl-3.0/api/bindfragdata-nonexistent-variable.c |3 --- tests/spec/gl-3.0/api/clearbuffer-common.c |3 --- tests/spec/gl-3.0/api/clearbuffer-invalid-

[Piglit] [PATCH 3/3] gl-2.0: remove explicit 100 x 100 window size

2013-01-21 Thread Brian Paul
--- tests/spec/gl-2.0/api/clip-flag-behavior.c |3 --- .../gl-2.0/api/getattriblocation-conventional.c|3 --- tests/spec/gl-2.0/vertex-program-two-side.c|3 --- 3 files changed, 0 insertions(+), 9 deletions(-) diff --git a/tests/spec/gl-2.0/api/clip-flag-behavior.c

[Piglit] [PATCH 1/3] arb_blend_func_extended: remove explicit 100 x 100 window size

2013-01-21 Thread Brian Paul
--- .../api/bindfragdataindexed-invalid-parameters.c |3 --- tests/spec/arb_blend_func_extended/api/blend-api.c |3 --- .../arb_blend_func_extended/api/error-at-begin.c |3 --- .../arb_blend_func_extended/api/getfragdataindex.c |3 --- .../execution/fbo-extended-blend-explicit.

[Piglit] [PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-21 Thread Chad Versace
Generate the following test files: {const,vs,fs}-{pack,unpack}{Snorm,Unorm,Half}2x16.shader_test The tests are generated by a new Python script, gen_builtin_packing_tests.py, and placed into directory spec/glsl-es-3.00/execution/built-in-functions. v2: Add reduced_input_table. This allows us to

[Piglit] [PATCH] Test varying structs in GLSL ES 3.00.

2013-01-21 Thread Paul Berry
This patch adds the following GLSL ES 3.00 tests: - varying-struct-basic: a simple test case involving a single varying struct. - varying-struct-arrays: exercise complex interactions between structs and arrays in varyings. - varying-struct-copy-vs: exercise corner cases where a struct inte

Re: [Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-01-21 Thread Brian Paul
On 01/21/2013 01:43 PM, Tom Gall wrote: This ported test goes into tests/spec/arb_texture_rectangle. It tests the ARB_texture_rectangle extension. Create a 255x127 texture of varying colors and bind it as a GL_ARB_texture_recangle target. Draw that rectangle to the window, and check that the te

Re: [Piglit] [PATCH 2/2] shader_runner optimization

2013-01-21 Thread Chad Versace
On 01/21/2013 12:52 PM, Paul Berry wrote: > On 21 January 2013 12:03, Tom Gall > wrote: > Once we've done that, however, I'm afraid I'm still not understanding the > benefit of this patch. Do you have evidence that this patch will produce a > measurable performance im

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Chad Versace
On 01/17/2013 03:08 PM, Tom Gall wrote: > Augment the parser that examines the shader_test file passed in > with the test to determine which brand of shader_running to > execute, shader_runner, shader_runner_gles2, etc. > > This fixes a bug where GLSL ES if first in the [required] section > could

Re: [Piglit] [PATCH 2/2] shader_runner optimization

2013-01-21 Thread Paul Berry
On 21 January 2013 12:03, Tom Gall wrote: > On Mon, Jan 21, 2013 at 12:49 PM, Paul Berry > wrote: > > On 17 January 2013 15:08, Tom Gall wrote: > >> > >> When shader_runner parses the shader_test data file, add an > >> optimization such that after the [required] section is left to > >> no longe

[Piglit] [PATCH 2/2] rm tests/glean/ttexrect.*

2013-01-21 Thread Tom Gall
Remove ttexrect.* from glean as the previous patch ports the test to piglit. Remove texRect from all.tests. Signed-off-by: Tom Gall --- tests/all.tests |1 - tests/glean/CMakeLists.gl.txt |1 - tests/glean/ttexrect.cpp | 215 -

[Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-01-21 Thread Tom Gall
This ported test goes into tests/spec/arb_texture_rectangle. It tests the ARB_texture_rectangle extension. Create a 255x127 texture of varying colors and bind it as a GL_ARB_texture_recangle target. Draw that rectangle to the window, and check that the texture was drawn correctly. The common fai

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Tom Gall
On Mon, Jan 21, 2013 at 12:39 PM, Paul Berry wrote: > I'd suggest changing to a commit subject that describes precisely what > change you're making in the active voice, e.g. something like "Fix > shader_runner regexps to match new version requirement syntax". The > existing commit subject ("shade

Re: [Piglit] [PATCH 2/2] shader_runner optimization

2013-01-21 Thread Tom Gall
On Mon, Jan 21, 2013 at 12:49 PM, Paul Berry wrote: > On 17 January 2013 15:08, Tom Gall wrote: >> >> When shader_runner parses the shader_test data file, add an >> optimization such that after the [required] section is left to >> no longer parse the rest of the file. >> >> Signed-off-by: Tom Gal

Re: [Piglit] [PATCH 2/2] shader_runner optimization

2013-01-21 Thread Paul Berry
On 17 January 2013 15:08, Tom Gall wrote: > When shader_runner parses the shader_test data file, add an > optimization such that after the [required] section is left to > no longer parse the rest of the file. > > Signed-off-by: Tom Gall > --- > tests/shaders/shader_runner.c |5 - > 1 fi

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Paul Berry
I'd suggest changing to a commit subject that describes precisely what change you're making in the active voice, e.g. something like "Fix shader_runner regexps to match new version requirement syntax". The existing commit subject ("shader_runner regression with gles") is too vague. On 17 January

[Piglit] [RFC PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-21 Thread Chad Versace
Generate the following test files: {const,vs,fs}-{pack,unpack}{Snorm,Unorm,Half}2x16.shader_test The tests are generated by a new Python script, gen_builtin_packing_tests.py, and placed into directory spec/glsl-es-3.00/execution/built-in-functions. v2: Rewrite as a pure Python implementation. O