Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
LGTM. Are you asking for another review or do you need someone to commit/push it for you? -Brian On 02/06/2013 03:38 PM, Tom Gall wrote: It was a little over two weeks ago when v2 of these 2 patches to port ttexrect to piglit and remove it from glean were posted. It has a Reviewed-by: Brian

Re: [Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

2013-02-07 Thread Brian Paul
On 02/06/2013 05:06 PM, Marek Olšák wrote: This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests |1 + tests/texturing/getteximage-formats.c | 75

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Tom Gall
Hi Brian, It has your reviewed by. Ideally I was looking for it to be committed unless of course there's something egregious about it that we both missed. On Thu, Feb 7, 2013 at 9:04 AM, Brian Paul bri...@vmware.com wrote: LGTM. Are you asking for another review or do you need someone to

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
OK, I thought you had git-write ability. I'll commit/push soon. -Brian On 02/07/2013 08:23 AM, Tom Gall wrote: Hi Brian, It has your reviewed by. Ideally I was looking for it to be committed unless of course there's something egregious about it that we both missed. On Thu, Feb 7, 2013 at

Re: [Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Brian Paul
On 02/07/2013 08:35 AM, Brian Paul wrote: OK, I thought you had git-write ability. I'll commit/push soon. Actually, I found a few more issues with the code. The piglit_swap_buffers() call should be moved after the probing code. And you should use piglit_present_results() instead. After a

Re: [Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

2013-02-07 Thread Marek Olšák
On Thu, Feb 7, 2013 at 4:10 PM, Brian Paul bri...@vmware.com wrote: On 02/06/2013 05:06 PM, Marek Olšák wrote: This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests

Re: [Piglit] [PATCH] Add a basic CopyTexImage test for packed depth/stencil formats.

2013-02-07 Thread Paul Berry
On 5 February 2013 22:52, Kenneth Graunke kenn...@whitecape.org wrote: This test fills the window with expected depth/stencil values, and uses CopyTexImage2D to copy those to a texture. It then reads back the texture and verifies that both depth and stencil were successfully copied. This

[Piglit] [PATCH 0/3] Minor Fixes related to distributed testing.

2013-02-07 Thread Kenney Phillis
*** BLURB HERE *** Kenney Phillis (3): Add the shell script identifiers to the tests. Fix piglit resume path resolving. make some parts of the piglit framework unicode aware. framework/shader_test.py|5 +++-- piglit-run.py |2 +- tests/all.tests

[Piglit] [PATCH 1/3] Add the shell script identifiers to the tests.

2013-02-07 Thread Kenney Phillis
This is extremely useful for distributed testing where the test results are not in the same folder as piglit is. This happens regularly when piglit is installed through packages and then ran in the user home directory. --- tests/all.tests |1 +

[Piglit] [PATCH 2/3] Fix piglit resume path resolving.

2013-02-07 Thread Kenney Phillis
Fixes resolution of relative paths to absolute paths. This will help keep piglit from crashing out when resume path is not within source path. This happens regularly when using distributed testing. --- piglit-run.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Piglit] [PATCH 3/3] make some parts of the piglit framework unicode aware.

2013-02-07 Thread Kenney Phillis
This fixes resume failures when paths are interpreted as unicode when the script expects ascii. --- framework/shader_test.py |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/framework/shader_test.py b/framework/shader_test.py index 03478fc..f3920f9 100755 ---

Re: [Piglit] [PATCH 0/2] shader_runner: Add stricter requirements for [require] section

2013-02-07 Thread Stuart Abercrombie
Thanks for looking into the problem. The new version I sent in produced the same number of passes as Piglit with the revert on Sandy Bridge for all.tests without glean. Stuart On Wed, Feb 6, 2013 at 9:18 PM, Chad Versace chad.vers...@linux.intel.comwrote: On 02/06/2013 06:11 PM, Stuart

[Piglit] [PATCH] util-cl: Fix error output from piglit_cl_probe_floating()

2013-02-07 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com - Print 16 decimal places of floating point values - Fix the hex formatting --- tests/util/piglit-util-cl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-cl.c b/tests/util/piglit-util-cl.c index

[Piglit] [PATCH] util-cl: Fix error output from piglit_cl_probe_floating()

2013-02-07 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com - Print 16 decimal places of floating point values - Fix the hex formatting --- I sent out the wrong patch out last time. tests/util/piglit-util-cl.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Piglit] [PATCH] invalid-es3-queries: Check that GL_MAX_VARYING_COMPONENTS is rejected

2013-02-07 Thread Matt Turner
--- See associated Mesa patch: mesa: Allow glGet* queries of MAX_VARYING_COMPONENTS in ES 3 tests/spec/gles-2.0/invalid-es3-queries.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/spec/gles-2.0/invalid-es3-queries.c

[Piglit] [PATCH] Remove BindBufferRange out-of-range tests.

2013-02-07 Thread Paul Berry
In the documentation for BindBufferRange, OpenGL specs from 3.0 through 4.1 contain this language: The error INVALID_VALUE is generated if size is less than or equal to zero or if offset + size is greater than the value of BUFFER_SIZE. This text was dropped from OpenGL 4.2, and it

[Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean

2013-02-07 Thread Tom Gall
This ported test goes into tests/spec/arb_texture_rectangle. It tests the ARB_texture_rectangle extension. Create a 255x127 texture of varying colors and bind it as a GL_ARB_texture_recangle target. Draw that rectangle to the window, and check that the texture was drawn correctly. The common

[Piglit] [PATCH 2/2] rm tests/glean/ttexrect.*

2013-02-07 Thread Tom Gall
Remove ttexrect.* from glean as the previous patch ports the test to piglit. Remove texRect from all.tests. Signed-off-by: Tom Gall tom.g...@linaro.org --- tests/all.tests |1 - tests/glean/CMakeLists.gl.txt |1 - tests/glean/ttexrect.cpp | 215