[Piglit] PIGLIT_GL_VISUAL_RGBA not what it says on the tin

2013-03-22 Thread Dave Airlie
So I was debugging texelFetch today with multisample inside softpipe, when I found in non-fbo mode it was getting alpha values wrong, becuase PIGLIT_GL_VISUAL_RGB= 0, PIGLIT_GL_VISUAL_RGBA = 0, I expect someone thought that would get them an alpha visual, wh

Re: [Piglit] PIGLIT_GL_VISUAL_RGBA not what it says on the tin

2013-03-22 Thread Jose Fonseca
- Original Message - > So I was debugging texelFetch today with multisample inside softpipe, > when I found in non-fbo mode it was getting alpha values wrong, > becuase > > PIGLIT_GL_VISUAL_RGB= 0, > PIGLIT_GL_VISUAL_RGBA = 0, > > > I expect someone

Re: [Piglit] [PATCH] util: move #define GLXBadProfileARB from .c file to .h file

2013-03-22 Thread Jose Fonseca
- Original Message - > Some of the ES tests check for this error code. If the installed > glxproto.h file isn't new enough this symbol may be missing and > compilation will fail. > --- > tests/util/piglit-glx-util.c |4 > tests/util/piglit-glx-util.h |4 > 2 files change

[Piglit] [PATCH] primgen: new test for PRIMITIVES_GENERATED query

2013-03-22 Thread Marek Olšák
--- tests/all.tests|1 + .../spec/ext_transform_feedback/CMakeLists.gl.txt |1 + tests/spec/ext_transform_feedback/primgen.c| 114 3 files changed, 116 insertions(+) create mode 100644 tests/spec/ext_transform_feedback/pri

Re: [Piglit] [PATCH] primgen: new test for PRIMITIVES_GENERATED query

2013-03-22 Thread Eric Anholt
Marek Olšák writes: Could you give it a more informative name than "primgen"? Like "primgen-rasterizer-discard" or something? Other than that, 2 minor suggestions you can take or leave. > +enum piglit_result piglit_display(void) > +{ > + glClear(GL_COLOR_BUFFER_BIT); > + glBeginQuery(

[Piglit] [PATCH] Test some interactions with multiple inout parameters

2013-03-22 Thread Ian Romanick
From: Ian Romanick There are several variations of void foo(inout int i, inout float f); ... foo(i, f[i]); that Mesa's GLSL compiler gets wrong. NVIDIA's closed-source driver (version 304.64) fails vs-inout-index-inout-mat2-col.shader_test and vs-inout-index-inout-mat2-row.shader_test, but pas

[Piglit] [PATCH] glsl-1.30: add basic test for testing textureOffset functionality.

2013-03-22 Thread sroland
From: Roland Scheidegger This is pretty rough and doesn't really test all that much (just textureOffsetLod, but there's other texturing functions with offsets), doesn't test different wrap modes, NPOT sizes etc., but there's no other test using "ordinary" texture opcodes and texel offsets, so it'

Re: [Piglit] [PATCH] glsl-1.30: add basic test for testing textureOffset functionality.

2013-03-22 Thread Roland Scheidegger
Please disregard this sent the wrong stuff... Am 22.03.2013 23:21, schrieb srol...@vmware.com: > From: Roland Scheidegger > > This is pretty rough and doesn't really test all that much (just > textureOffsetLod, but there's other texturing functions with offsets), > doesn't test different wrap mo

[Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

2013-03-22 Thread sroland
From: Roland Scheidegger Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken (the gallivm code got it wrong and always did an early exit which got unno

Re: [Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

2013-03-22 Thread Ian Romanick
On 03/22/2013 03:28 PM, srol...@vmware.com wrote: From: Roland Scheidegger Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken (the gallivm code got

[Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

2013-03-22 Thread sroland
From: Roland Scheidegger Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken (the gallivm code got it wrong and always did an early exit which got unno

Re: [Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

2013-03-22 Thread Roland Scheidegger
Am 23.03.2013 01:41, schrieb Ian Romanick: > On 03/22/2013 03:28 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing >> using return in main. Contrary to the these other tests, this hits both >> the cases where t