Re: [Piglit] [PATCH] Test that transform feedback works with non-flat integers.

2013-04-06 Thread Jordan Justen
Reviewed-by: Jordan Justen On Sat, Apr 6, 2013 at 7:45 PM, Paul Berry wrote: > Commit 0fac0a6 (Modify tests for error checking on "flat" keyword to > match updated specs) adopted the GLSL 1.50 rules for "flat" varyings > for all desktop GL tests (the rationale was that this change likely > refle

[Piglit] [PATCH] Test interaction of primitive restart and transform feedback.

2013-04-06 Thread Paul Berry
--- tests/all.tests | 3 + tests/spec/gl-3.1/CMakeLists.gl.txt | 1 + tests/spec/gl-3.1/primitive-restart-xfb.c | 259 ++ 3 files changed, 263 insertions(+) create mode 100644 tests/spec/gl-3.1/primitive-restart-xfb.c diff --git a/t

[Piglit] [PATCH] Test that transform feedback works with non-flat integers.

2013-04-06 Thread Paul Berry
Commit 0fac0a6 (Modify tests for error checking on "flat" keyword to match updated specs) adopted the GLSL 1.50 rules for "flat" varyings for all desktop GL tests (the rationale was that this change likely reflects a bug fix rather than a deliberate behavioural difference). The GLSL 1.50 rules all

[Piglit] [PATCH] arb_texture_multisample: add test to check sample positions v2

2013-04-06 Thread Christoph Bumiller
From: Christoph Bumiller v2: Removed dependency on TextureBarrierNV and ARB_tfb_2, added comments. --- .../spec/arb_texture_multisample/CMakeLists.gl.txt |1 + .../spec/arb_texture_multisample/sample-position.c | 236 2 files changed, 237 insertions(+), 0 deletions(-)

[Piglit] [PATCH] arb_texture_multisample: add test to check sample positions

2013-04-06 Thread Christoph Bumiller
From: Christoph Bumiller Wrote this to figure out the sample positions on NVC0. Didn't find any test that checks if the driver reported sample positions match the behaviour of rendering. It's probably a bit too crazy, but I thought I'd just send it in case anyone wants to make use of it. --- ..

Re: [Piglit] [PATCH 5/5] gl-1.0: use default window size to fix Windows run

2013-04-06 Thread Jose Fonseca
- Original Message - > On 04/06/2013 03:21 AM, Jose Fonseca wrote: > > Brian, > > > > Series looks alright, but it looks to me this is a pervasive issue, and not > > just a few isolated cases: > > > > piglit $ git grep config.window_width | wc -l > > 461 > > > > So I wonder if there i

Re: [Piglit] [PATCH 5/5] gl-1.0: use default window size to fix Windows run

2013-04-06 Thread Brian Paul
On 04/06/2013 03:21 AM, Jose Fonseca wrote: Brian, Series looks alright, but it looks to me this is a pervasive issue, and not just a few isolated cases: piglit $ git grep config.window_width | wc -l 461 So I wonder if there isn't a more definite solution. For example, could we simply mo

Re: [Piglit] [PATCH 5/5] gl-1.0: use default window size to fix Windows run

2013-04-06 Thread Jose Fonseca
Brian, Series looks alright, but it looks to me this is a pervasive issue, and not just a few isolated cases: piglit $ git grep config.window_width | wc -l 461 So I wonder if there isn't a more definite solution. For example, could we simply modify tests/util/... helper code to sanitize wind

Re: [Piglit] [PATCH] lodbias: increase window size fix test on Windows

2013-04-06 Thread Jose Fonseca
- Original Message - > Before, the 96x96 window got bumped up to 116x96 by Windows and we > saw a "Got spurious window resize in automatic run" message and the > test reported "warn". > --- > tests/texturing/lodbias.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > dif