[Piglit] [PATCH v2] amd_performance_monitor: Fix multi-statement macro 'report'.

2013-05-07 Thread Vinson Lee
Fixes Nesting level does not match indentation defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/amd_performance_monitor/api.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/spec/amd_performance_monitor/api.c

Re: [Piglit] [v5 02/12] framework: hardware independent interface for dma buffers

2013-05-07 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: In order to test the EXT_image_dma_buf_import, one needs a way for creating dma buffers that can be imported to EGL and filling them with data for the GL-stack to sample. While dma buffer themselves are only defined for linux, the actual writing of

Re: [Piglit] [v5 03/12] framework: support for creating dma buffers through libdrm

2013-05-07 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers the support is to be built. v2 (first five according to Chad's

Re: [Piglit] [v5 02/12] framework: hardware independent interface for dma buffers

2013-05-07 Thread Chad Versace
On 05/07/2013 02:13 PM, Chad Versace wrote: On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: In order to test the EXT_image_dma_buf_import, one needs a way for creating dma buffers that can be imported to EGL and filling them with data for the GL-stack to sample. While dma buffer themselves are

Re: [Piglit] [v5 02/12] framework: hardware independent interface for dma buffers

2013-05-07 Thread Ken Phillis Jr
On Tue, May 7, 2013 at 4:13 PM, Chad Versace chad.vers...@linux.intel.com wrote: +void +piglit_destroy_dma_buf(struct piglit_dma_buf *buf); Is it safe to pass NULL to this function, like free()? Please document that. With that documentation, this patch is Reviewed-by: Chad Versace

Re: [Piglit] [v5 07/12] tests: spec: EXT_image_dma_buf_import fd ownership transfer

2013-05-07 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: Simple test checking that EGL can close the export file handle and the creator can in turn can its reference. Without a verb, the second phrase above is a bit too elliptical. How about can in turn $VERB its reference? Signed-off-by: Topi

Re: [Piglit] [PATCH v2] amd_performance_monitor: Fix multi-statement macro 'report'.

2013-05-07 Thread Brian Paul
On 05/07/2013 03:06 PM, Vinson Lee wrote: Fixes Nesting level does not match indentation defect reported by Coverity. Signed-off-by: Vinson Leev...@freedesktop.org --- tests/spec/amd_performance_monitor/api.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [v5 04/12] tests: spec: EXT_image_dma_buf_import invalid hints

2013-05-07 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: On 05/03/2013 02:23 PM, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: diff --git a/tests/spec/ext_image_dma_buf_import/CMakeLists.gles1.txt b/tests/spec/ext_image_dma_buf_import/CMakeLists.gles1.txt new file mode

Re: [Piglit] [v5 04/12] tests: spec: EXT_image_dma_buf_import invalid hints

2013-05-07 Thread Chad Versace
On 05/07/2013 04:04 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: On 05/03/2013 02:23 PM, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: diff --git a/tests/spec/ext_image_dma_buf_import/CMakeLists.gles1.txt

Re: [Piglit] [PATCH v2] amd_performance_monitor: Fix multi-statement macro 'report'.

2013-05-07 Thread Ian Romanick
On 05/07/2013 02:06 PM, Vinson Lee wrote: Fixes Nesting level does not match indentation defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/spec/amd_performance_monitor/api.c | 6 -- 1 file changed,

Re: [Piglit] [Mesa-dev] [PATCH v2] amd_performance_monitor: Fix multi-statement macro 'report'.

2013-05-07 Thread Kenneth Graunke
On 05/07/2013 02:04 PM, Vinson Lee wrote: Fixes Nesting level does not match indentation defect reported by Coverity. That has to be the stupidest defect I've ever heard of. But your patch looks reasonable nonetheless - most people use do-while blocks like that, so it's probably a good