[Piglit] [v10 01/13] glapi: fix parsing of extensions containing string "EGL_"

2013-08-20 Thread Topi Pohjolainen
Category for 'EGLImageTargetTexture2DOES' becomes 'GL_OES_EGL_image' instead of 'GL_OES_Eimage'. v2 (Chad): replace first occurence explicitly Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- glapi/parse_glspec.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Piglit] [v10] Tests for EXT_image_dma_buf_import

2013-08-20 Thread Topi Pohjolainen
Here are some tests for the dma buffer importing. These are mostly things specifically listed down in the spec itself regarding attributes and their values. This version does not test for planar buffers but leaves those for later. Framework is augmented to provide platform independent interface f

[Piglit] [v10 02/13] util/gl: gl-profile style image probe for gles

2013-08-20 Thread Topi Pohjolainen
As GLES reads pixels as non-normalized integers compare the integers directly instead of transforming to floats first. v2 (Chad): fix cut-paste error from core-gl - color component values for separate and combined alpha/luminance Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versa

[Piglit] [v10 03/13] framework: hardware independent interface for dma buffers

2013-08-20 Thread Topi Pohjolainen
In order to test the EXT_image_dma_buf_import, one needs a way for creating dma buffers that can be imported to EGL and filling them with data for the GL-stack to sample. While dma buffer themselves are only defined for linux, the actual writing of the buffers using CPU differs from hardware to ano

[Piglit] [v10 04/13] framework: support for creating dma buffers through libdrm

2013-08-20 Thread Topi Pohjolainen
In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers the support is to be built. v2 (first five according to Chad's advice): - replace manual search for drm with 'pkg

[Piglit] [v10 05/13] framework: automatic drm authentication for dma buffer support

2013-08-20 Thread Topi Pohjolainen
From: Chad Versace Fix tests to work as non-root user. Get DRM authentication before calling intel_bufmgr_gem_init(). v2: refactored into its own patch and allowing the dma buffer support to be compiled even without this (change by Topi) v3: use 'bool' instead of "zero for success, negative

[Piglit] [v10 07/13] tests/spec: EXT_image_dma_buf_import invalid attributes

2013-08-20 Thread Topi Pohjolainen
v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - use helper variables for width, height and cpp instead of repeating the magic numbers over and over again (Eric) - use the stride and off

[Piglit] [v10 08/13] tests/spec: EXT_image_dma_buf_import missing attributes

2013-08-20 Thread Topi Pohjolainen
v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - removed irrelevant quotes of the spec (Eric) - rewritten attribute test vector using a full set which is then trimmed down in individual

[Piglit] [v10 06/13] tests/spec: EXT_image_dma_buf_import invalid hints

2013-08-20 Thread Topi Pohjolainen
v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - use helper variables for width, height and cpp instead of repeating the magic numbers over and over again (Eric) - use the stride and off

[Piglit] [v10 10/13] tests/spec: EXT_image_dma_buf_import sample argb

2013-08-20 Thread Topi Pohjolainen
Tests that one can sample the given buffer without other mipmap levels by setting texture filtering accordingly. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - removed irrelevant quote of the

[Piglit] [v10 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-20 Thread Topi Pohjolainen
Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - use helper variables for width, heig

[Piglit] [v10 11/13] tests/spec: EXT_image_dma_buf_import intel unsupported format

2013-08-20 Thread Topi Pohjolainen
v2 (Chad): add dependency to 'EGL_KHR_image_base' Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- tests/all.tests| 1 + .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 1 + .../intel_unsupported_format.c | 114 ++

[Piglit] [v10 12/13] tests/spec: EXT_image_dma_buf_import intel dma-buf with img-ext only

2013-08-20 Thread Topi Pohjolainen
v2 (Chad): - be more specific: rename try_as_non_external_texture() as try_as_texture_2d() - skip the test if EGL stack does not support the chosen format - add dependency to 'EGL_KHR_image_base' Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace --- tests/all.tests

[Piglit] [v10 13/13] tests/spec: EXT_image_dma_buf_import intel img-ext with dma-buf only

2013-08-20 Thread Topi Pohjolainen
v2 (Chad): add dependency to 'EGL_KHR_image_base' v3: cast 'GLuint' into 'intptr_t' before trying to cast to 'EGLClientBuffer'. Makes compiler happy on platforms where integer and pointer are of different size. Signed-off-by: Topi Pohjolainen Reviewed-by: Chad Versace (v2) --- tests/al

[Piglit] [PATCH 2/2] Make use of piglit_build_simple_program_unlinked() in some tests.

2013-08-20 Thread Paul Berry
--- tests/spec/ext_framebuffer_multisample/common.cpp | 6 +- tests/spec/ext_texture_array/compressed.c | 6 +- tests/spec/ext_transform_feedback/change-size.c| 5 + tests/spec/ext_transform_feedback/nonflat-integral.c | 5

[Piglit] [PATCH 1/2] util: Add piglit_build_simple_program_unlinked().

2013-08-20 Thread Paul Berry
--- tests/util/piglit-shader.c | 29 + tests/util/piglit-shader.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c index 8172dfb..f7bd06f 100644 --- a/tests/util/piglit-shader.c +++ b/tests/util/piglit-shad

[Piglit] [PATCH 1/5] GL 3.2: Test functionality of ProvokingVertex()

2013-08-20 Thread Nicholas Mack
--- tests/spec/CMakeLists.txt | 1 + tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 14 tests/spec/arb_provoking_vertex/CMakeLists.txt | 1 + .../provoking-vertex-control.c | 77 ++ 4 files changed, 93 insertions(+)

[Piglit] [PATCH 2/5] GL 3.2: Test that the initial value of provoking vertex mode is LAST_VERTEX_CONVENTION

2013-08-20 Thread Nicholas Mack
--- tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 + .../provoking-vertex-initial.c | 64 ++ 2 files changed, 65 insertions(+) create mode 100644 tests/spec/arb_provoking_vertex/provoking-vertex-initial.c diff --git a/tests/spec/arb_provoking_ver

[Piglit] [PATCH 3/5] GL 3.2: Test the validity of QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

2013-08-20 Thread Nicholas Mack
Note: The spec refers to QUADS_FOLLOW_PROVOKING_VERTEX but this is a spec bug. --- tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 + .../quads-follow-provoking-vertex.c| 64 ++ 2 files changed, 65 insertions(+) create mode 100644 tests/spec/arb_provok

[Piglit] [PATCH 4/5] GL 3.2: Test that the Transform Feedback Buffer collects data before flatshading occurs

2013-08-20 Thread Nicholas Mack
--- tests/spec/arb_provoking_vertex/CMakeLists.gl.txt | 1 + .../arb_provoking_vertex/xfb-before-flatshading.c | 203 + 2 files changed, 204 insertions(+) create mode 100644 tests/spec/arb_provoking_vertex/xfb-before-flatshading.c diff --git a/tests/spec/arb_provoking_ver

[Piglit] [PATCH 5/5] Add provoking vertex tests to all.tests

2013-08-20 Thread Nicholas Mack
--- tests/all.tests | 8 1 file changed, 8 insertions(+) diff --git a/tests/all.tests b/tests/all.tests index 7491cae..54b1edb 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1196,6 +1196,14 @@ add_plain_test(arb_pixel_buffer_object, 'pbo-teximage') add_plain_test(arb_pixel_buffe

Re: [Piglit] [PATCH 1/2] util: Add piglit_build_simple_program_unlinked().

2013-08-20 Thread Anuj Phogat
On Tue, Aug 20, 2013 at 7:20 AM, Paul Berry wrote: > > --- > tests/util/piglit-shader.c | 29 + > tests/util/piglit-shader.h | 2 ++ > 2 files changed, 31 insertions(+) > > diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c > index 8172dfb..f7bd06f 1

[Piglit] [PATCH v2 02/10] GL3.2 GL_ARB_sync: Test for valid return values from ClientWaitSync

2013-08-20 Thread Nicholas Mack
v2: Fix comments, initialize variables. Still need to figure out if GPU commands needed before testing these. --- tests/spec/arb_sync/CMakeLists.gl.txt| 3 +- tests/spec/arb_sync/ClientWaitSync-returns.c | 109 +++ 2 files changed, 111 insertions(+), 1 delet

[Piglit] [PATCH v2 03/10] GL3.2 GL_ARB_sync: Test DeleteSync errors returned

2013-08-20 Thread Nicholas Mack
v2: Remove DeleteSync-errors.c --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_sync/CMakeLists.gl.txt b/tests/spec/arb_sync/CMakeLists.gl.txt index ff8ca85..1996c75 100644 --- a/tests/spec/arb_sync/CMakeLists.gl.txt +++ b/tests/spec/arb

[Piglit] [PATCH v2 01/10] GL3.2 GL_ARB_sync: Test to check the correct error messages are returned for invalid inputs for ClientWaitSync

2013-08-20 Thread Nicholas Mack
v2: Fix comments, initialize variables, rewrite loop through all bit masks --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/ClientWaitSync-errors.c | 103 2 files changed, 104 insertions(+) create mode 100644 tests/spec/arb_sync/ClientWaitS

[Piglit] [PATCH v2 04/10] GL3.2 GL_ARB_sync: Basic test for DeleteSync

2013-08-20 Thread Nicholas Mack
v2: Fix comments, add test for passing invalid sync to IsSync(), change variable types. --- tests/spec/arb_sync/CMakeLists.gl.txt | 2 +- tests/spec/arb_sync/DeleteSync.c | 71 +++ 2 files changed, 72 insertions(+), 1 deletion(-) create mode 100644 tests/

[Piglit] [PATCH v2 05/10] GL3.2 GL_ARB_sync: Test for the correct error messages caused by invalid input to FenceSync

2013-08-20 Thread Nicholas Mack
v2: Fix comments, remove unnecessary tests. --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/FenceSync-errors.c | 71 ++ 2 files changed, 72 insertions(+) create mode 100644 tests/spec/arb_sync/FenceSync-errors.c diff --git a/tests/spec/arb_s

[Piglit] [PATCH v2 09/10] GL3.2 GL_ARB_sync: Test that the correct error messages are returned from invalid input for WaitSync

2013-08-20 Thread Nicholas Mack
v2: Fix comments, remove redundant code --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/WaitSync-errors.c | 82 +++ 2 files changed, 83 insertions(+) create mode 100644 tests/spec/arb_sync/WaitSync-errors.c diff --git a/tests/spec/arb_sync/CM

[Piglit] [PATCH v2 06/10] GL3.2 GL_ARB_sync: Test that GetSynciv sets correct error codes.

2013-08-20 Thread Nicholas Mack
v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/GetSynciv-errors.c | 94 ++ 2 files changed, 95 insertions(+) create mode 100644 tests/spec/arb_sync/GetSynciv-errors.c diff --git a/tests/spec/arb_sync/C

[Piglit] [PATCH v2 10/10] Add the arb_sync tests to all.tests

2013-08-20 Thread Nicholas Mack
--- tests/all.tests | 8 1 file changed, 8 insertions(+) diff --git a/tests/all.tests b/tests/all.tests index 7491cae..f97c65b 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -989,8 +989,16 @@ import_glsl_parser_tests(spec['ARB_shader_stencil_export'], # Group ARB_sync arb_sync =

[Piglit] [PATCH v2 08/10] GL3.2 GL_ARB_sync: Test that a sync object is initialized with the correct properties

2013-08-20 Thread Nicholas Mack
v2: Fix comments, add extra checks for length variable being modified --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/sync-initialize.c | 125 ++ 2 files changed, 126 insertions(+) create mode 100644 tests/spec/arb_sync/sync-initialize.c dif

[Piglit] [PATCH v2 07/10] GL3.2 GL_ARB_sync: Test that IsSync returns true/false if it is given a valid/invalid sync object name

2013-08-20 Thread Nicholas Mack
v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/IsSync.c | 82 +++ 2 files changed, 83 insertions(+) create mode 100644 tests/spec/arb_sync/IsSync.c diff --git a/tests/spec/arb_sync/CMakeLists.g

[Piglit] [PATCH 3/4] fbo-storage-formats: Fix reporting of invalid formats.

2013-08-20 Thread Kenney Phillis
Currently Invalid formats is reported from the formats data structure. This is incorrect because the invalid formats set should not use this system. --- tests/fbo/fbo-storage-formats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-storage-formats.c b/tests/fb

[Piglit] [PATCH 2/4] util/waffle: reinitialize extensions

2013-08-20 Thread Kenney Phillis
Implements reinitialization on waffle based contexts to allow context fallbacks to work as intended. --- .../piglit-framework-gl/piglit_wfl_framework.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/piglit-framework-

[Piglit] [PATCH 4/4] fbo-storage-formats: enable tests for OpenGl 3.0 formats.

2013-08-20 Thread Kenney Phillis
This enabled the Floating point and Integer formats introduced in OpenGL 3.0. This currently uses an OpenGL 3.1 Core context to enable this for Mesa based drivers, however the test should work without any faults on any drivers that also support Compatibility contexts that are OpenGl 3.0 or newer. -

[Piglit] [PATCH 1/4] piglit-util-gl-common: Add Function to clear extensions list.

2013-08-20 Thread Kenney Phillis
The default handling of Extension fall backs does not work in specific cases where the list of supported extensions changes. The list of extensions for a Core profile may be different from the same context created using a Compatibility profile. --- tests/util/piglit-util-gl-common.c |8 +++

[Piglit] [PATCH 0/4] Minor Improvements

2013-08-20 Thread Kenney Phillis
A couple of minor improvements in handling OpenGL Context fallback and how to determine feature support in fbo-storage-formats. Kenney Phillis (4): piglit-util-gl-common: Add Function to clear extensions list. util/waffle: reinitialize extensions fbo-storage-formats: Fix reporting of invali

[Piglit] [PATCH] Move visualize_image function to util/piglit-util-gl.c

2013-08-20 Thread Anuj Phogat
This function might be useful to develop new piglit test cases. Signed-off-by: Anuj Phogat --- tests/spec/ext_framebuffer_multisample/common.cpp | 82 - tests/spec/ext_framebuffer_multisample/common.h| 5 -- .../draw-buffers-common.cpp| 10 +-- t

[Piglit] [PATCH] gs: test all input primitive types.

2013-08-20 Thread Paul Berry
Verified using the NVIDIA proprietary driver for Linux. --- tests/all.tests| 8 + .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 1 + .../glsl-1.50/execution/geometry/primitive-types.c | 435 + 3 files changed, 444 insertions(+) cr

[Piglit] [PATCH 1/2] Add utility functions to convert a color value to srgb or linear color space

2013-08-20 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- tests/util/piglit-util-gl-common.h | 2 ++ tests/util/piglit-util-gl.c| 28 2 files changed, 30 insertions(+) diff --git a/tests/util/piglit-util-gl-common.h b/tests/util/piglit-util-gl-common.h index e2df89d..0078041 100644

[Piglit] [PATCH 2/2] Use utility function piglit_srgb_to_linear()

2013-08-20 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- tests/spec/ext_framebuffer_multisample/common.cpp | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp b/tests/spec/ext_framebuffer_multisample/common.cpp index c96a935..89d07dd 1

[Piglit] [PATCH] cl: Add tests for local memory atomic_inc and atomic_add builtins

2013-08-20 Thread Tom Stellard
From: Tom Stellard --- tests/all_cl.tests | 1 + .../execute/builtin/atomic/atomic_add-local.cl | 61 ++ .../execute/builtin/atomic/atomic_inc-local.cl | 58 3 files changed, 120 insertions(+) create mode 100644 t

[Piglit] [PATCH v2] CORE FRAMEWORK: don't reporting failed cases as PASS

2013-08-20 Thread Homer Hsing
If in multiple subtests, first failed, last passed, then subtests was looked as "passed". Because "interpretResult" function overwrote previous results. See framework/exectest.py, interpretResult(): if piglit.startswith('subtest'): if not 'subtest' in results:

[Piglit] [PATCH] framework/summary.py: Fix path resolution by using relative paths.

2013-08-20 Thread Kenney Phillis
Fixes problems with path resolution when files change location. NOTE: This patch is probably not be PEP8 Compliant. --- framework/summary.py |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/framework/summary.py b/framework/summary.py index 35500bf..3929fd1 100644 ---

Re: [Piglit] [PATCH] framework/summary.py: Fix path resolution by using relative paths.

2013-08-20 Thread Dylan Baker
I have two concerns, first, it you've used tabs and space mixed. Please do not use tabs, please only use spaces for the python portions of piglit. There is a wonderful pep8 tool available from the python 'pip' tool, or from most linux distros package managers, that can be very helpful in catchin