[Piglit] [PATCH 3/7] cl-program-tester: Add a helper function for getting type sizes

From: Tom Stellard --- tests/cl/program/program-tester.c | 99 +-- tests/util/piglit-util-cl.c | 20 tests/util/piglit-util-cl.h | 20 3 files changed, 84 insertions(+), 55 deletions(-) diff --git a/tests/cl/program/program-teste

[Piglit] [PATCH 4/7] cl-program-tester: Rename test_arg::size to test_arg::size_in_mem

From: Tom Stellard The value being stored in this field is actually the size of the argument if it were to be stored in memory (for a type like int3, its size is 12 bytes, but its size in memory is 16 bytes per the OpenCL spec). --- tests/cl/program/program-tester.c | 30 +++-

[Piglit] [PATCH 5/7] cl-progam-tester: Pass correct size to piglit_cl_set_kernel_arg()

From: Tom Stellard --- tests/cl/program/program-tester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index ea16c81..557dc4b 100644 --- a/tests/cl/program/program-tester.c +++ b/tests/cl/program/program

[Piglit] [PATCH 2/7] piglit-cl-util: Add a helper for getting the alignment of vector types

From: Tom Stellard --- tests/cl/program/program-tester.c | 2 +- tests/util/piglit-util-cl.c | 13 + tests/util/piglit-util-cl.h | 6 ++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-test

[Piglit] [PATCH 1/7] cl-program-tester: Use more appropriate member names for struct test_arg

From: Tom Stellard cl_size has been renamed to vec_elements and cl_mem_size has been renamed to vec_mem_elements. This use of size is confusing, because size generally means number of bytes when used to describe a type, and in this case the value being stored was the number of elements in the ve

[Piglit] [PATCH 7/7] cl-program-tester: Add gentype option to config section

From: Tom Stellard The gentype option allows a test file to specify a list of types and vector sizes to be used for each test. cl-program-tester will run each test once for each comibnation of type and vector size. This makes it possible to write a generic test that can be run on a number of di

[Piglit] [PATCH 6/7] cl-program-tester: Defer parsing of input/output values until test execution

From: Tom Stellard This will make it possible to write tests using generic types. --- tests/cl/program/program-tester.c | 61 +-- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-test

Re: [Piglit] [PATCH 6/7] cl-program-tester: Defer parsing of input/output values until test execution

On Mon, Sep 30, 2013 at 9:47 AM, Tom Stellard wrote: > From: Tom Stellard > > This will make it possible to write tests using generic types. > --- > tests/cl/program/program-tester.c | 61 > +-- > 1 file changed, 40 insertions(+), 21 deletions(-) > > diff --g

[Piglit] [PATCH v2] Test that all vertex shader inputs are enumerated by GetActiveAttrib(). This includes built-ins such as gl_InstanceID and gl_VertexID.

v2: Restructure test to check attrib names on an individual basis --- tests/all.tests| 2 + tests/spec/gl-3.2/CMakeLists.gl.txt| 1 + .../gl-3.2/get-active-attrib-returns-all-inputs.c | 127 + 3 files changed, 130 inserti

Re: [Piglit] [PATCH v2 04/10] GL3.2 GL_ARB_sync: Basic test for DeleteSync

On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, add test for passing invalid sync to IsSync(), change variable types. --- tests/spec/arb_sync/CMakeLists.gl.txt | 2 +- tests/spec/arb_sync/DeleteSync.c | 71 +++ 2 files changed, 72 inse

Re: [Piglit] [PATCH v2 04/10] GL3.2 GL_ARB_sync: Basic test for DeleteSync

On 09/30/2013 12:34 PM, Chad Versace wrote: On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, add test for passing invalid sync to IsSync(), change variable types. --- tests/spec/arb_sync/CMakeLists.gl.txt | 2 +- tests/spec/arb_sync/DeleteSync.c | 71 +

Re: [Piglit] [PATCH v2 06/10] GL3.2 GL_ARB_sync: Test that GetSynciv sets correct error codes.

On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/GetSynciv-errors.c | 94 ++ 2 files changed, 95 insertions(+) create mode 100644 tests/spec/arb_sync/Get

Re: [Piglit] [PATCH v2 07/10] GL3.2 GL_ARB_sync: Test that IsSync returns true/false if it is given a valid/invalid sync object name

On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/IsSync.c | 82 +++ 2 files changed, 83 insertions(+) create mode 100644 tests/spec/arb_sync/IsSy

Re: [Piglit] [PATCH v2 08/10] GL3.2 GL_ARB_sync: Test that a sync object is initialized with the correct properties

On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, add extra checks for length variable being modified --- tests/spec/arb_sync/CMakeLists.gl.txt | 1 + tests/spec/arb_sync/sync-initialize.c | 125 ++ 2 files changed, 126 insertions(+) create mod

Re: [Piglit] [PATCH v2 10/10] Add the arb_sync tests to all.tests

On 08/20/2013 11:26 AM, Nicholas Mack wrote: --- tests/all.tests | 8 1 file changed, 8 insertions(+) diff --git a/tests/all.tests b/tests/all.tests index 7491cae..f97c65b 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -989,8 +989,16 @@ import_glsl_parser_tests(spec['ARB_shade

Re: [Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

Sorry for the slow responses, Nick. I got behind in patch review in the last two weeks and I'm only just now catching up. On 16 September 2013 09:35, Nicholas Mack wrote: > --- > tests/all.tests| 12 ++ > .../glsl-1.50/execution/geometry/CMakeLists.gl.txt |

Re: [Piglit] [PATCH 2/4] GS: Test geometry input layout qualifier rules

On 16 September 2013 09:35, Nicholas Mack wrote: > --- > .../compiler/layout-in-only-input-qualifier.geom | 23 > + > .../compiler/layout-in-only-one-qualifier-id.geom | 24 > ++ > 2 files changed, 47 insertions(+) > create mode 100644 > tests/spec/gls

Re: [Piglit] [PATCH 3/4] GS: Test geometry output layout qualifier rules

On 16 September 2013 09:35, Nicholas Mack wrote: > --- > ...ayout-only-one-out-declaration-per-program.geom | 22 > ++ > .../compiler/layout-out-only-output-qualifier.geom | 22 > ++ > .../compiler/layout-out-order-irrelevant.geom | 21 > +

Re: [Piglit] [PATCH 4/4] GS: Test that max_vertices cannot be greater than glMaxGeometryOutputVertices

On 16 September 2013 09:35, Nicholas Mack wrote: > --- > .../glsl-1.50/compiler/layout-max-verts-limited.geom| 17 > + > 1 file changed, 17 insertions(+) > create mode 100644 > tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom > > diff --git a/tests/spec/glsl-1.50/

Re: [Piglit] [PATCH 1/2] threadpool.py: Completely rewrite threadpool.py

On Monday, September 16, 2013 09:09:34 AM Dylan Baker wrote: > This patch completely rewrites the threadpool module. This new > implementation is less complicated than the previous version. It also is > not an external project pulled in, but an original implementation. > > This tries to be largely

Re: [Piglit] [PATCH 1/7] cl-program-tester: Use more appropriate member names for struct test_arg

I hope to have time to dig into the actual changes themselves in more detail (my first skim through looked fairly good besides my comment on patch 6). If I don't get time to do a full review of the changes, I just wanted to mention that I tested this on my CEDAR without any regressions to existing

Re: [Piglit] [PATCH v2 02/10] GL3.2 GL_ARB_sync: Test for valid return values from ClientWaitSync

On 08/20/2013 11:26 AM, Nicholas Mack wrote: v2: Fix comments, initialize variables. Still need to figure out if GPU commands needed before testing these. --- tests/spec/arb_sync/CMakeLists.gl.txt| 3 +- tests/spec/arb_sync/ClientWaitSync-returns.c | 109 ++

[Piglit] [PATCH 1/4] GS: Test that geometry shader input/output layout qualifiers only compile if valid

v2: Tests check against list of valid layouts instead of invalid layouts --- tests/all.tests| 12 ++ .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 2 + .../geometry/gs-input-layout-qualifiers.c | 128 + .../geometry/gs-outp

[Piglit] [PATCH 2/4] GS: Test geometry input layout qualifier rules

v2: Remove unnecessary test --- .../compiler/layout-in-only-one-qualifier-id.geom | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/layout-in-only-one-qualifier-id.geom diff --git a/tests/spec/glsl-1.50/compiler/layout-in-only-one-qu

[Piglit] [PATCH 4/4 v2] GS: Test that max_vertices cannot be set to INT_MAX

v2: Add comment Reviewed-by: Paul Berry --- .../compiler/layout-max-verts-limited.geom | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/layout-max-verts-limited.geom diff --git a/tests/spec/glsl-1.50/compiler/layout-max-vert

[Piglit] [PATCH 3/4] GS: Test geometry output layout qualifier rules

v2: Split first test into two separate tests and remove the unnecessary second test --- ...-one-out-declaration-per-program-max-verts.geom | 22 ++ ...-one-out-declaration-per-program-prim-type.geom | 22 ++ .../compiler/layout-out-order-irrelevant.geom

Re: [Piglit] [PATCH] GL 3.2: Test that GetTexLevelParameterfv() generates an error when passed TEXTURE_BORDER

On 09/27/2013 03:07 PM, Nicholas Mack wrote: --- tests/spec/gl-3.2/CMakeLists.gl.txt | 1 + tests/spec/gl-3.2/texture-border-deprecated.c | 63 +++ 2 files changed, 64 insertions(+) create mode 100644 tests/spec/gl-3.2/texture-border-deprecated.c This n

Re: [Piglit] [PATCH] Test accuracy of dFdx and dFdy functions.

On 09/28/2013 03:24 PM, Paul Berry wrote: > On 27 September 2013 14:18, Ian Romanick > wrote: > > On 09/20/2013 10:15 AM, Paul Berry wrote: > > Mesa/i965 currently (as of commit 1cc3b90) has an inaccurate > > implementation of dFdy() which produces the sam

Re: [Piglit] [PATCH v2] Test that all vertex shader inputs are enumerated by GetActiveAttrib(). This includes built-ins such as gl_InstanceID and gl_VertexID.

On 09/30/2013 12:27 PM, Nicholas Mack wrote: > v2: Restructure test to check attrib names on an individual basis With the two nits below fixed, Reviewed-by: Ian Romanick > --- > tests/all.tests| 2 + > tests/spec/gl-3.2/CMakeLists.gl.txt|

[Piglit] [ANNOUNCE] waffle-1.3.0

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Waffle 1.3.0 (30 Sept 2013) === Waffle 1.3.0 is now available. This release introduces the ability create forward-compatible and debug contexts as well as improved support for Mac OS. Details below. As usual, the release is av

[Piglit] [PATCH 0/8] Various Fixes on Cmake and opengl.

Cmake fix 1: Fix problems involving out of tree builds cmake fix 2: fix some missing files from installer. config.h.in: applied a slightly more correct location for the HAVE_STRNDUP define. tests/util fixes: Updated changelog from previous commit. Kenney Phillis (8): cmake: fix out of tree Ins

[Piglit] [PATCH 1/8] cmake: fix out of tree Installation and package generation.

When building and installing out of source tree the generated tests are not installed. This commit fixes that. --- CMakeLists.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a39d9df..c86ffe5 100644 --- a/CMakeLists.txt +++ b/CMakeLis

[Piglit] [PATCH 2/8] cmake: add *.geom to the list of installed files.

*.geom files are the shader files used for testing geometry shaders. --- CMakeLists.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c86ffe5..8404d9a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -312,13 +312,13 @@ install (

[Piglit] [PATCH 6/8] config.h.in: add define for HAVE_STRNDUP

This fixes compile problems on various systems where strndup can be found but the HAVE_STRNDUP define is not being set. V2: Made the changes that Petri Latvala suggested. However the exact line for the define of HAVE_STRNDUP needed to be placed next to the other function defines in config.

[Piglit] [PATCH 3/8] cmake: add *.cl to the list of installed generated tests.

Files with the extension ".cl" are usually used for OpenCL and this installs all .cl files that are in the generated_tests folder when either making a package or actually installing the tests on a system. --- CMakeLists.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMa

[Piglit] [PATCH 4/8] cmake: ignore the "CMakeFiles" folder in generated_tests installer

This is an Automatically generated file that is not used by any test and only appears during build. --- CMakeLists.txt |1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 775b25a..f064b35 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -319,6 +319,7 @@

[Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

Increase the Minimum version of CMake that is required from version 2.6 to version 2.8. This is because the minimum requirement to compile waffle is version 2.8 --- CMakeLists.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f064b35..

[Piglit] [PATCH 7/8] piglit-util-gl-common: Add Function to clear extensions list.

The default handling of Extension fall backs does not work in specific cases where the list of supported extensions changes. The list of extensions for a Core profile may be different from the same context created using a Compatibility profile. V2: applied the changes suggested by Chad to improve

[Piglit] [PATCH 8/8] util/waffle: reinitialize extensions

Implements reinitialization on waffle based contexts to allow context fallbacks to work as intended. v2: applied the changes that Chad suggested. --- .../piglit-framework-gl/piglit_wfl_framework.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_w