Re: [Piglit] [PATCH 5/5] arb_texture_query_levels: add execution tests

2013-10-04 Thread Matt Turner
On Fri, Oct 4, 2013 at 9:08 PM, Chris Forbes wrote: > Ensure that the returned level count is correct in various situations. > > Signed-off-by: Chris Forbes > --- > .../execution/fs-baselevel.shader_test | 40 +++ > .../execution/fs-maxlevel.shader_test |

[Piglit] [PATCH 5/5] arb_texture_query_levels: add execution tests

2013-10-04 Thread Chris Forbes
Ensure that the returned level count is correct in various situations. Signed-off-by: Chris Forbes --- .../execution/fs-baselevel.shader_test | 40 +++ .../execution/fs-maxlevel.shader_test | 40 +++ .../execution/fs-miptree.shader_test

[Piglit] [PATCH 4/5] arb_texture_query_levels: add compiler tests for textureQueryLevels()

2013-10-04 Thread Chris Forbes
This tests that all the required signatures exist. Signed-off-by: Chris Forbes --- .../compiler/builtin-functions-float-samplers.frag | 46 ++ .../compiler/builtin-functions-float-samplers.vert | 46 ++ .../compiler/builtin-functions-int-samplers.frag |

[Piglit] [PATCH 1/5] shader_runner: add ability to specify GL_TEXTURE_BASE_LEVEL

2013-10-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- tests/shaders/shader_runner.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index ba76cd0..ca571ec 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1585,6 +15

[Piglit] [PATCH 1/5] shader_runner: add ability to specify GL_TEXTURE_BASE_LEVEL

2013-10-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- tests/shaders/shader_runner.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index ba76cd0..ca571ec 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1585,6 +15

[Piglit] [PATCH 2/5] shader_runner: add ability to specify GL_TEXTURE_MAX_LEVEL

2013-10-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- tests/shaders/shader_runner.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index ca571ec..fbc1964 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -1585,6 +15

[Piglit] [PATCH 3/5] arb_texture_query_levels: add group and shader-runner dir

2013-10-04 Thread Chris Forbes
Signed-off-by: Chris Forbes --- tests/all.tests | 8 1 file changed, 8 insertions(+) diff --git a/tests/all.tests b/tests/all.tests index f353217..c45f1cb 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1278,6 +1278,14 @@ add_shader_test_dir(arb_gpu_shader5,

[Piglit] [PATCH 2/4] util: Add common framework for command-line invoked subtests

2013-10-04 Thread Ian Romanick
From: Ian Romanick There are two parts to this. First, command line options of the form "-subtest foo" have their argument (the "foo" part) stored in a list in the piglit_gl_test_config. Tests can use this functionality without having to use any of the other parts. This allows every piglit tes

[Piglit] [PATCH 4/4] arb_transform_feedback2: Misc. API error checks

2013-10-04 Thread Ian Romanick
From: Ian Romanick This covers most of the errors mentioned in the spec that aren't already covered in cannot-bind-when-active.c and gen-names-only.c. Most of the other errors should be covered by existing EXT_transform_feedback tests. Mesa currently passes all of these tests. NVIDIA (304.64 on

[Piglit] [PATCH 3/4] util: Add a -list-subtests option that will list all the subtests

2013-10-04 Thread Ian Romanick
From: Ian Romanick This required some ugly hacking about to get the list of subtests to process_args. Suggestions? The utility is that all.tests can do 'sometest -list-subtests' to automatically get the list of subtests to run. Since the syntax for selecting subtests is regularized, this works

[Piglit] [PATCH 1/4] util: Add utility function to accumulate results of subtests

2013-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- tests/util/piglit-util.c | 25 + tests/util/piglit-util.h | 4 2 files changed, 29 insertions(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index 71d55a7..20015ce 100644 --- a/tests/util/pigl

Re: [Piglit] [PATCH V9] KHR_debug: test ObjectLabel(), GetObjectLabel(), ObjectPtrLabel() and GetObjectPtrLabel()

2013-10-04 Thread Timothy Arceri
Bump. Is this latest patch ok? It would be good to get this committed if no one has any further issues to point out. Tim ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] egl-1.4: Add test egl-terminate-then-unbind-context

2013-10-04 Thread Paul Berry
On 4 October 2013 13:49, Chad Versace wrote: > On 10/04/2013 01:42 PM, Paul Berry wrote: > >> On 20 September 2013 12:38, Chad Versace ** >> wrote: >> > > It's not obvious clear why EGL_KHR_surfaceless_context is necessary for >> this test. Can we remove this check, or add a comment explaining

Re: [Piglit] [PATCH] egl-1.4: Add test egl-terminate-then-unbind-context

2013-10-04 Thread Chad Versace
On 10/04/2013 01:42 PM, Paul Berry wrote: On 20 September 2013 12:38, Chad Versace wrote: It's not obvious clear why EGL_KHR_surfaceless_context is necessary for this test. Can we remove this check, or add a comment explaining why it's necessary? With that addressed, this patch is: Reviewed

Re: [Piglit] [PATCH] egl-1.4: Add test egl-terminate-then-unbind-context

2013-10-04 Thread Paul Berry
On 20 September 2013 12:38, Chad Versace wrote: > This test makes current a context, terminates the context's display, then > unbinds the context. According to the EGL 1.4 spec (2011.04.06), Section > 3.2 Initialization, no errors should occur. > > Exposes a use-after-free crash on mesa-9.2 with i

Re: [Piglit] [PATCH 09/11] arb_get_program_binary: Execercise GL_PROGRAM_BINARY_RETRIEVABLE_HINT

2013-10-04 Thread Ian Romanick
On 10/04/2013 11:47 AM, Paul Berry wrote: > On 21 August 2013 09:08, Ian Romanick > wrote: > > From: Ian Romanick > > > This test fails on NVIDIA (304.64 on GTX 260). It fails because the > value of GL_PROGRAM_BINARY

Re: [Piglit] usage of C++11 STL features in a Piglit test

2013-10-04 Thread Ian Romanick
On 10/02/2013 02:32 PM, Jon Ashburn wrote: > I am working on Piglit tests for arb_texture_view. I was considering > using C++11 features in STL (e.g. unordered_set). Any reason not to What do you want to do that would significantly benefit from such features? For the most part, we want to kee

Re: [Piglit] [PATCH 00/11] Misc old piglit tests

2013-10-04 Thread Paul Berry
On 21 August 2013 09:07, Ian Romanick wrote: > A few months ago my piglit tree got really broken, and I had to > re-clone it. When that happened, I left a bunch of in-progress tests > in the old tree. Since Ken was looking for some > GL_ARB_transform_feedback2 tests, I had to revive some of the

Re: [Piglit] [PATCH 11/11] Test some interactions with multiple inout parameters

2013-10-04 Thread Paul Berry
On 21 August 2013 09:08, Ian Romanick wrote: > From: Ian Romanick > > There are several variations of > > void foo(inout int i, inout float f); > ... > foo(i, f[i]); > > that Mesa's GLSL compiler gets wrong. NVIDIA (304.64 on GTX 260) fails > vs-inout-index-inout-mat2-col.shader_test and > vs-i

Re: [Piglit] [PATCH 09/11] arb_get_program_binary: Execercise GL_PROGRAM_BINARY_RETRIEVABLE_HINT

2013-10-04 Thread Paul Berry
On 21 August 2013 09:08, Ian Romanick wrote: > From: Ian Romanick > > This test fails on NVIDIA (304.64 on GTX 260). It fails because the > value of GL_PROGRAM_BINARY_RETRIEVABLE_HINT is not "latched" by > glLinkProgram. The spec is a little unclear on this topic, and I filed > a bug in the Kh

Re: [Piglit] [PATCH 08/11] arb_get_program_binary: Verify glGet* doesn't over-run the buffer for binary format queries

2013-10-04 Thread Paul Berry
On 21 August 2013 09:08, Ian Romanick wrote: > From: Ian Romanick > > This test works with both GL_PROGRAM_BINARY_FORMATS (from > ARB_get_program_binary) and GL_SHADER_BINARY_FORMATS (from > ARB_ES2_compatibility). Mesa fails GL_SHADER_BINARY_FORMATS because it > generates an error (!) for the

Re: [Piglit] [PATCH 02/11] arb_transform_feedback2: Cannot bind an xfb object when one is already active

2013-10-04 Thread Paul Berry
On 21 August 2013 09:07, Ian Romanick wrote: > From: Ian Romanick > > NVIDIA (304.64 on GTX 260) passes this test. AMD has not been tested. > > Signed-off-by: Ian Romanick > Cc: Kenneth Graunke > --- > tests/all.tests| 1 + > .../spec/arb_transform_feedb

Re: [Piglit] [PATCH 01/11] arb_transform_feedback2: Require that xfb object names come from Gen

2013-10-04 Thread Paul Berry
On 21 August 2013 09:07, Ian Romanick wrote: > From: Ian Romanick > > NVIDIA (304.64 on GTX 260) passes this test. AMD has not been tested. > > Signed-off-by: Ian Romanick > Cc: Kenneth Graunke > --- > tests/all.tests| 1 + > .../spec/arb_transform_feedba

[Piglit] [v2 6/7] tests/spec: relax config for ARB_transform_feedback2 redrawing

2013-10-04 Thread Topi Pohjolainen
Now able to run with 4.2.0 NVIDIA 304.88. Signed-off-by: Topi Pohjolainen --- tests/spec/arb_transform_feedback2/draw-auto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_transform_feedback2/draw-auto.c b/tests/spec/arb_transform_feedback2/draw-auto.c in

[Piglit] [v2 7/7] tests/spec: ARB_transform_feedback3 interleaved stream re-draw

2013-10-04 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- tests/all.tests| 1 + .../spec/arb_transform_feedback3/CMakeLists.gl.txt | 1 + .../ext_interleaved_draw_streams.c | 388 + 3 files changed, 390 insertions(+) create mode 100644 tests

[Piglit] [v2 4/7] tests/spec: ARB_transform_feedback3 interleaved in multiple streams

2013-10-04 Thread Topi Pohjolainen
v2: - fixed indentation: spaces -> tabs (Ian) - require core/compatibility version 3.2 instead of ARB_geometry_shader4 which is not going to be supported by mesa (Ian) - drop _EXT, use core names instead (Ian) - now using piglit_build_simple_program_multiple_shaders() Signed-off-by

[Piglit] [v2 5/7] tests/spec: ARB_transform_feedback3 interleaved in two buffers

2013-10-04 Thread Topi Pohjolainen
v2: - tests also multiple geometry shader invocations outputting into same buffer(s) - checks also the primitive write counter - fixed indentation: spaces -> tabs (Ian) - require core/compatibility version 3.2 instead of ARB_geometry_shader4 which is not going to be supported

[Piglit] [v2 2/7] util: buffer object probe

2013-10-04 Thread Topi Pohjolainen
Make feedback buffer probe accessible also for other tests. Original behavior is altered not to print matching values anymore. v2: - call piglit_probe_buffer() instead of thin wrapper (Ian) - use bool instead of GLboolean Signed-off-by: Topi Pohjolainen --- tests/spec/ext_transform_feedba

[Piglit] [v2 3/7] tests/spec: ARB_transform_feedback3 interleaved in separate buffers

2013-10-04 Thread Topi Pohjolainen
v2: - fixed indentation: spaces -> tabs (Ian) - require core/compatibility version 3.2 instead of ARB_geometry_shader4 which is not going to be supported by mesa (Ian) - drop _EXT, use core names instead (Ian) - now using piglit_build_simple_program_multiple_shaders() Signed-

[Piglit] [v2 1/7] tests/spec: relax config for EXT_transform_feedback separate

2013-10-04 Thread Topi Pohjolainen
Now able to run with 4.2.0 NVIDIA 304.88. Signed-off-by: Topi Pohjolainen --- tests/spec/ext_transform_feedback/separate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/ext_transform_feedback/separate.c b/tests/spec/ext_transform_feedback/separate.c index e410be

[Piglit] [v2] ARB_transform_feedback3 tests

2013-10-04 Thread Topi Pohjolainen
This series is still work in progress. There is some overlap between as I've been trying different things out in order to understand the spec better. The first test in the series experiments with mixed mode where multiple attributes are recorded into multiple separate buffers. Previously one could

Re: [Piglit] [PATCH] sso: Add compile tests for the location layout qualifier

2013-10-04 Thread Ian Romanick
On 10/03/2013 04:33 PM, Wen Su wrote: > Piers and I reviewed the glsl spec v1.3 and v1.4. The layout qualifier was > not added until v1.4. See page 18 in the pdf below. > http://www.opengl.org/registry/doc/GLSLangSpec.Full.1.40.05.pdf That is true. It is also added by GL_ARB_fragment_coord_conve

Re: [Piglit] [PATCH 7/8] piglit-util-gl-common: Add Function to clear extensions list.

2013-10-04 Thread Ken Phillis Jr
On Mon, Sep 30, 2013 at 10:11 PM, Kenney Phillis wrote: > The default handling of Extension fall backs does not work in specific > cases where the list of supported extensions changes. The list of > extensions for a Core profile may be different from the same > context created using a Compatibilit