[Piglit] [PATCH 1/7] ARB_texture_view: Test for API coverage of subset of input params

2013-10-24 Thread Jon Ashburn
Tests GL_ARB_texture_view and validity of input parameters. Use both valid and invalid parameters, although mostly invalid parameters are tested since other tests will use valid parameters. Only the parameters texture, origtexture, minlevel, numlevels, minlayer, numlayers are tested for

[Piglit] [PATCH 7/7] ARB_texture_view: Test texture view format changes and lifetimes

2013-10-24 Thread Jon Ashburn
Tests texture views with data format changes. 1D textures only. Uses multiple simultaneous views with different lifetimes and check results via glGetTexImage(). Tested on Nvidia Quadro 600, all subtests pass. --- tests/all.tests | 1 +

[Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-24 Thread Jon Ashburn
Tests GL_ARB_texture_view rendering with various texture targets. Creates texture maps with different solid colors for each level or layer reads the framebuffer to ensure the rendered color is correct. Tested on Nvidia Quadro 600, all subtests pass. --- tests/all.tests

[Piglit] [PATCH 6/7] ARB_texture_view: Test for rendering various levels and layers in texture view

2013-10-24 Thread Jon Ashburn
Tests GL_ARB_texture_view rendering with various layers and levels. Creates texture maps with different solid colors for each level or layer, reads the framebuffer to ensure the rendered color is correct. Tested on Nvidia Quadro 600, all subtests pass. --- tests/all.tests

Re: [Piglit] [PATCH 7/7] ARB_texture_view: Test texture view format changes and lifetimes

2013-10-24 Thread Brian Paul
On 10/24/2013 03:49 PM, Jon Ashburn wrote: Tests texture views with data format changes. 1D textures only. Uses multiple simultaneous views with different lifetimes and check results via glGetTexImage(). Tested on Nvidia Quadro 600, all subtests pass. --- tests/all.tests

Re: [Piglit] [PATCH 6/7] ARB_texture_view: Test for rendering various levels and layers in texture view

2013-10-24 Thread Brian Paul
Another quick review. Minor things below. On 10/24/2013 03:49 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view rendering with various layers and levels. Creates texture maps with different solid colors for each level or layer, reads the framebuffer to ensure the rendered color is correct.

Re: [Piglit] [PATCH 3/7] ARB_texture_view:Test valid and invalid targets for TextureView

2013-10-24 Thread Brian Paul
In the subject, space after colon. Reviewed-by: Brian Paul bri...@vmware.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/7] ARB_texture_view: Test for API coverage of subset of input params

2013-10-24 Thread Brian Paul
Minor suggestions below. On 10/24/2013 03:48 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view and validity of input parameters. Use both valid and invalid parameters, although mostly invalid parameters are tested since other tests will use valid parameters. Only the parameters texture,

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-24 Thread Brian Paul
I didn't really study this test, but some things jumped out... On 10/24/2013 03:49 PM, Jon Ashburn wrote: Tests GL_ARB_texture_view rendering with various texture targets. Creates texture maps with different solid colors for each level or layer reads the framebuffer to ensure the rendered

[Piglit] Python 2.7.4/5 bad file descriptor bug should be fixed soon

2013-10-24 Thread Kenneth Graunke
A number of people (at least me, cworth, and ajax) have been hitting a bug where tests randomly fail with a Bad file descriptor error. It only occurs with Python 2.7.4 and 2.7.5. Other people have strangely not been affected. I did some searching and discovered this Python bug: