Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-25 Thread Jon Ashburn
RE your comment: +config.window_width = 128; +config.window_height = 128; Is 128 special? Can you just go with the defaults? In the past we've had trouble on Windows when the width is 130 or so pixels. Long story. 128 isn't special and I could use a larger number (130).

[Piglit] [PATCH 1/2] query_renderer: Add some common infrastructure for GLX_MESA_query_renderer tests

2013-10-25 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com All of the tests for this extension will require a bunch of function pointers, etc. This patch adds a function to get these function pointers and some macros to wrap calls using them. Signed-off-by: Ian Romanick ian.d.roman...@intel.com ---

Re: [Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

2013-10-25 Thread Brian Paul
On 10/25/2013 10:41 AM, Jon Ashburn wrote: RE your comment: +config.window_width = 128; +config.window_height = 128; Is 128 special? Can you just go with the defaults? In the past we've had trouble on Windows when the width is 130 or so pixels. Long story. 128 isn't special

[Piglit] [PATCH v2 2/2] summary.py: Replace buildDictionary function with a much simpler method

2013-10-25 Thread Dylan Baker
This patch produces the exact same output as the previous approach, just in a much simpler way. It also moves some more of the status information out of if branches and into the Status class in the status module. There are a few side effects of using a defaultdict class, namely that they do not

[Piglit] [PATCH] cl: Add sqrt tests

2013-10-25 Thread Aaron Watry
Pretty basic, but we didn't have any tests for this before... Tested on r600g w/ CEDAR. --- generated_tests/generate-cl-math-builtins.py | 8 1 file changed, 8 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index

[Piglit] [PATCH V2 2/6] ARB_sample_shading: Add test to verify the functionality of gl_NumSamples

2013-10-25 Thread Anuj Phogat
V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 6 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 + .../execution/builtin-gl-num-samples.cpp | 220 +

[Piglit] [PATCH V2 1/6] ARB_sample_shading: Add test to verify new functions and enums

2013-10-25 Thread Anuj Phogat
Tests basic functionality of function: MinSampleShadingARB() and enums: SAMPLE_SHADING_ARB MIN_SAMPLE_SHADING_VALUE_ARB Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 ++ tests/spec/CMakeLists.txt | 1 +

[Piglit] [PATCH V2 3/6] ARB_sample_shading: Add test to verify the functionality of gl_SampleID

2013-10-25 Thread Anuj Phogat
V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 + .../execution/builtin-gl-sample-id.cpp | 230 +

[Piglit] [PATCH V2 4/6] ARB_sample_shading: Add test to verify the functionality of gl_SampleMask[]

2013-10-25 Thread Anuj Phogat
V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 + .../execution/builtin-gl-sample-mask.cpp | 236 +

[Piglit] [PATCH V2 6/6] ARB_sample_shading: Add compiler tests for new builtins

2013-10-25 Thread Anuj Phogat
Tests gl_SamplePosition, gl_SampleID, gl_NumSamples, gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests | 4 tests/spec/arb_sample_shading/compiler/gl_NumSamples.frag | 12

[Piglit] [PATCH V2 5/6] ARB_sample_shading: Add test to verify the functionality of gl_SamplePosition

2013-10-25 Thread Anuj Phogat
V2: Use better technique to verify sample positions in fragment shader. Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests| 5 + .../arb_sample_shading/execution/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH 2/6] arb_transform_feedback3: add test for querying with invalid index

2013-10-25 Thread Ian Romanick
On 10/22/2013 06:48 AM, Topi Pohjolainen wrote: NVIDIA (319.60 on GTX 660) fails by reporting INVALID_OPERATION instead of INVALID_VALUE. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- .../spec/arb_transform_feedback3/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH 3/6] arb_transform_feedback3: add test for ending non-active query

2013-10-25 Thread Ian Romanick
On 10/22/2013 06:48 AM, Topi Pohjolainen wrote: Passes on NVIDIA (319.60 on GTX 660). Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com With the non-fatal failure issue fixed (same as on the previous two patches), this one is Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

Re: [Piglit] [PATCH 3/6] arb_transform_feedback3: add test for ending non-active query

2013-10-25 Thread Ian Romanick
On 10/25/2013 04:59 PM, Ian Romanick wrote: On 10/22/2013 06:48 AM, Topi Pohjolainen wrote: Passes on NVIDIA (319.60 on GTX 660). Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com With the non-fatal failure issue fixed (same as on the previous two patches), this one is

Re: [Piglit] [PATCH 5/6] arb_transform_feedback3: add test trying to set invalid varyings

2013-10-25 Thread Ian Romanick
On 10/22/2013 06:48 AM, Topi Pohjolainen wrote: Non-existing program case crashes on NVIDIA (319.60 on GTX 660) but exceeding maximum attribute case passes. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- tests/all.tests| 1 +

Re: [Piglit] [PATCH 4/6] arb_transform_feedback3: add test trying to draw an invalid stream

2013-10-25 Thread Ian Romanick
On 10/22/2013 06:48 AM, Topi Pohjolainen wrote: Passes on NVIDIA (319.60 on GTX 660). Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- tests/all.tests| 1 + .../spec/arb_transform_feedback3/CMakeLists.gl.txt | 1 +

Re: [Piglit] [PATCH] cl: Add sqrt tests

2013-10-25 Thread Tom Stellard
On Fri, Oct 25, 2013 at 05:40:47PM -0500, Aaron Watry wrote: Pretty basic, but we didn't have any tests for this before... Tested on r600g w/ CEDAR. --- generated_tests/generate-cl-math-builtins.py | 8 1 file changed, 8 insertions(+) diff --git