[Piglit] [PATCH] update the HACKING file's Coding style section

2013-11-01 Thread Brian Paul
I've tried to describe Piglit's coding style and conventions in more detail. Hopefully, new contributors will read this and it'll save some some time and effort for the reviewers. Please feel free to add/update this info. --- HACKING | 57

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..ea8c3a6 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c @@

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

2013-11-01 Thread Fredrik Höglund
On Tuesday 29 October 2013, Eric Anholt wrote: Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/errors.c b/tests/spec/arb_vertex_attrib_binding/errors.c new file mode

Re: [Piglit] [PATCH 2/7] arb_vertex_attrib_binding: Test new states

2013-11-01 Thread Fredrik Höglund
On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: Test setting and quering all new states. This also tests interactions with glVertexAttribPointer(). Same MIN2 and uncreached comments as the previous test. +#include piglit-util-gl-common.h +

Re: [Piglit] [PATCH 6/7] arb_vertex_attrib_binding: Test instance-divisor

2013-11-01 Thread Fredrik Höglund
On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/instance-divisor.c b/tests/spec/arb_vertex_attrib_binding/instance-divisor.c new file mode 100644 index 000..88ae454 --- /dev/null +++

Re: [Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Eric Anholt
Marek Olšák mar...@gmail.com writes: From: Marek Olšák marek.ol...@amd.com Given that the spec says 4, this should have a comment explaining what led to us deviating from the spec. pgpVOZBLurk0z.pgp Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

2013-11-01 Thread Eric Anholt
Fredrik Höglund fred...@kde.org writes: On Tuesday 29 October 2013, Eric Anholt wrote: Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/errors.c

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..c965ebe 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c @@

Re: [Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Ken Phillis Jr
On Fri, Nov 1, 2013 at 12:20 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..c965ebe

Re: [Piglit] [PATCH 1/7] arb_vertex_attrib_binding: Test error conditions

2013-11-01 Thread Fredrik Höglund
On Friday 01 November 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: On Tuesday 29 October 2013, Eric Anholt wrote: Sorry we all dropped this on the floor. I'm taking a look at your series now. Fredrik Höglund fred...@kde.org writes: diff --git

Re: [Piglit] [PATCH 7/7] arb_vertex_attrib_binding: Test zero-stride bindings

2013-11-01 Thread Fredrik Höglund
On Wednesday 30 October 2013, Eric Anholt wrote: Fredrik Höglund fred...@kde.org writes: diff --git a/tests/spec/arb_vertex_attrib_binding/zero-stride.c b/tests/spec/arb_vertex_attrib_binding/zero-stride.c new file mode 100644 index 000..83b56e4 --- /dev/null +++

Re: [Piglit] [PATCH] fbo-blit-after-swap: New test for partial blits after a buffer swap

2013-11-01 Thread Federico Mena Quintero
On Wed, 2013-10-30 at 11:48 -0700, Ian Romanick wrote: Does the test need a non-default size? The rest of the test code appears to adapt to any window size. Fixed; I just copied the initial code from fbo-sys-sub-blit, and that's what it did :) +#if SWAP_BUFFERS_BEFORE_BLIT Ideally, the

Re: [Piglit] [PATCH 00/13] Signal Handler and GLFW framework

2013-11-01 Thread Ken Phillis Jr
I added two more changes to this patch series. For patches the following patches * piglit-framework-gl: Add piglit signal handler. * util: Implement signal handler on windows. The change is to have all output except for... PIGLIT: {'result': 'crash' } changed to print to stderr instead of

Re: [Piglit] [PATCH] update the HACKING file's Coding style section

2013-11-01 Thread Chad Versace
On 11/01/2013 08:14 AM, Brian Paul wrote: I've tried to describe Piglit's coding style and conventions in more detail. Hopefully, new contributors will read this and it'll save some some time and effort for the reviewers. Please feel free to add/update this info. --- HACKING | 57

Re: [Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Ian Romanick
On 11/01/2013 10:20 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..c965ebe 100644 ---

[Piglit] [PATCH] fbo-blit-after-swap: New test for partial blits after a buffer swap

2013-11-01 Thread Federico Mena Quintero
From: Federico Mena Quintero feder...@suse.com Supports a no-swap command-line argument; see below. The clutter/cogl libraries try to minimize the area that gets updated on every frame. They do this by doing glBlitFramebufferEXT() from the back buffer to the front buffer. However, this is

Re: [Piglit] [PATCH] fbo-blit-after-swap: New test for partial blits after a buffer swap

2013-11-01 Thread Federico Mena Quintero
On Wed, 2013-10-30 at 11:48 -0700, Ian Romanick wrote: Ideally, the test binary should be able to do both these things based on a commandline parameter. BTW, I couldn't figure out how to modify piglit/tests/all.tests to make it call both variants. Help is appreciated with that :) It should

Re: [Piglit] [PATCH] update the HACKING file's Coding style section

2013-11-01 Thread Paul Berry
On 1 November 2013 08:14, Brian Paul bri...@vmware.com wrote: I've tried to describe Piglit's coding style and conventions in more detail. Hopefully, new contributors will read this and it'll save some some time and effort for the reviewers. Please feel free to add/update this info.

Re: [Piglit] [PATCH V2 3/6] ARB_sample_shading: Add test to verify the functionality of gl_SampleID

2013-11-01 Thread Anuj Phogat
On Tue, Oct 29, 2013 at 8:01 AM, Paul Berry stereotype...@gmail.com wrote: On 25 October 2013 16:49, Anuj Phogat anuj.pho...@gmail.com wrote: V2: Get rid of redundant projection matrix. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests

Re: [Piglit] [PATCHES] arb_viewport_array

2013-11-01 Thread Jon Ashburn
Upcoming patches 1-4, 9 for ARB_viewport_array: Patches 1-3: Changes for code review comments from Brian and Ian Patch 4: Code review changes plus bug fix where glGet value was used after being clamped Patch 9: Code review changes from Brian Note: Patches 5-8, minor changes from code

[Piglit] [PATCH 3/4] ARB_viewport_array: Validity test for scissor index related params

2013-11-01 Thread Jon Ashburn
Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glScissorArrayv, glScissorIndexed, glScissorIndexedv. Also test SCISSOR_TEST indices with glEnablei and others. Tested on Nvidia Quadro 600 all test

[Piglit] [PATCH 2/4] ARB_viewport_array: Validity test for depth range index/first/count params

2013-11-01 Thread Jon Ashburn
Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for all these new API entry points: glDepthRangeArrayv, glDepthRangeIndexed, glGetDoublei_v. Tested on Nvidia Quadro 600 all tests pass. Signed-off-by: Jon Ashburn j...@lunarg.com ---

[Piglit] [PATCH 4/4] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-11-01 Thread Jon Ashburn
Tests for the validity of Viewport bounds, Depth Range bounds and Scissor Box bounds with viewport arrays (0 to GL_MAX_VIEWPORTS-1). Bounds refer to the bounding rectangle or range (eg x, y, width, height). Tested with Nvidia Quadro 600. All tests pass except Scissor Box with a negative

[Piglit] [PATCH 1/4] ARB_viewport_array: Validity test for viewport index/first/count params

2013-11-01 Thread Jon Ashburn
Tests GL_ARB_viewport_array regarding the validity for the indices. Use both valid and invalid parameters (index, first, count) for these new API entry points: glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v. Also test that writing to an invalid viewport index for