[Piglit] [PATCH] fbo-drawbuffers-maxtargets: use different colors for different buffers

2013-11-07 Thread Brian Paul
Before, the test always drew green rects for all the target buffers. Now we draw a different color into each buffer to be more thorough. Plus, replace 16 with MAX_TARGETS, add some comments, etc. Note: the test now fails with Mesa's swrast because swrast errantly writes the same color to all

Re: [Piglit] [PATCH 1/7] glsl-1.10: Delete bogus generated test.

2013-11-07 Thread Chad Versace
Patches 1-3, 6-7 are Reviewed-by: Chad Versace chad.vers...@linux.intel.com Glad I wasn't the only one confused by the removal of glClear. By the way, I have some patches that do similar things for the python test generators. The patches make the tests run faster on simulation. I need to revive

[Piglit] [PATCH 1/2] arb_vertex_type_10f_10f_11f_rev: add test for api-errors

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 4 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 14 ++ .../arb_vertex_type_10f_11f_11f_rev/CMakeLists.txt | 1 + .../arb_vertex_type_10f_11f_11f_rev/api-errors.c |

[Piglit] [PATCH 2/2] arb_vertex_type_10f_10f_11f_rev: add test for draw-vertices

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 1 + .../CMakeLists.gl.txt | 1 + .../draw-vertices.c| 252 + 3 files changed, 254 insertions(+) create mode 100644

Re: [Piglit] [PATCH 1/2] arb_vertex_type_10f_10f_11f_rev: add test for api-errors

2013-11-07 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: +static bool +test_vertex_attribs() +{ + bool pass = true; + GLuint data = 0; + + /* The error INVALID_OPERATION is generated by ... , or VertexAttribPointer + * if type is UNSIGNED_INT_10F_11F_11F_REV and size is not 3. + */

[Piglit] [PATCH 3/8] add test for DrawElementsIndirect

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + tests/spec/arb_draw_indirect/draw-elements.c | 129 + 3 files changed, 131 insertions(+) create mode 100644 tests/spec/arb_draw_indirect/draw-elements.c

[Piglit] [PATCH 6/8] ARB_draw_indirect: add test for glDrawElementsIndirect with primitive restart

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../arb_draw_indirect/draw-elements-prim-restart.c | 133 + 3 files changed, 135 insertions(+) create mode 100644

[Piglit] [PATCH 1/8] arb_draw_indirect: add test for api errors

2013-11-07 Thread Chris Forbes
This initial test covers the new buffer binding point and expected API errors only; no successful Draw*Indirect calls are made. Future tests will exercise positive cases. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests| 5 +

[Piglit] [PATCH 5/8] ARB_draw_indirect: add test for DrawElementsIndirect with base instance

2013-11-07 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../draw-elements-base-instance.c | 152 + 3 files changed, 154 insertions(+) create mode

[Piglit] [PATCH 8/8] ARB_draw_indirect: add instances test

2013-11-07 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../spec/arb_draw_indirect/draw-arrays-instances.c | 123 + 3 files changed, 125 insertions(+) create mode

[Piglit] [PATCH 4/8] ARB_draw_indirect: add test for DrawArraysIndirect with base instance

2013-11-07 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../arb_draw_indirect/draw-arrays-base-instance.c | 142 + 3 files changed, 144 insertions(+) create mode

[Piglit] [PATCH 7/8] add ugly primitive restart case

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../draw-elements-prim-restart-ugly.c | 134 + 3 files changed, 136 insertions(+) create mode 100644

[Piglit] [PATCH 2/8] add new test for glDrawArraysIndirect

2013-11-07 Thread Chris Forbes
--- tests/all.tests| 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + tests/spec/arb_draw_indirect/draw-arrays.c | 119 + 3 files changed, 121 insertions(+) create mode 100644 tests/spec/arb_draw_indirect/draw-arrays.c

Re: [Piglit] [PATCH 2/2] arb_vertex_type_10f_10f_11f_rev: add test for draw-vertices

2013-11-07 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: diff --git a/tests/spec/arb_vertex_type_10f_11f_11f_rev/draw-vertices.c b/tests/spec/arb_vertex_type_10f_11f_11f_rev/draw-vertices.c new file mode 100644 index 000..1019777 --- /dev/null +++

Re: [Piglit] [PATCH 2/4] ARB_viewport_array: Validity test for depth range index/first/count params

2013-11-07 Thread Brian Paul
Just some formatting issues on this one and the same for patch 3/4. On 11/01/2013 04:51 PM, Jon Ashburn wrote: Tests GL_ARB_viewport_array validity for indices. Use both valid and invalid parameters (index, first, count) for all these new API entry points: glDepthRangeArrayv,

Re: [Piglit] [PATCH 4/4] ARB_viewport_array: Test validity of bounds for viewport, depthRange, scissor

2013-11-07 Thread Brian Paul
Minor formatting nits at the end. On 11/01/2013 04:51 PM, Jon Ashburn wrote: Tests for the validity of Viewport bounds, Depth Range bounds and Scissor Box bounds with viewport arrays (0 to GL_MAX_VIEWPORTS-1). Bounds refer to the bounding rectangle or range (eg x, y, width, height). Tested

Re: [Piglit] [PATCH 9/9 v2] ARB_viewport_array: Rendering test with multiple scissor rectangles/enables

2013-11-07 Thread Brian Paul
Typos below. On 11/04/2013 08:15 AM, Jon Ashburn wrote: Tests rendering into a single framebuffer surface with multiple viewports via a geometry shader. Scissoring is used to restrict quads to a smaller area on the surface. Confirm that each area of the surface delineated by a scissor