The render will only cover a single layer, and the code expects the
other layers to be 0'd out, so do a big clear first.
Signed-off-by: Ilia Mirkin
---
tests/spec/gl-3.2/layered-rendering/gl-layer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/spec/gl-3.2/layered-rendering/gl-laye
On Mon, 2014-01-13 at 14:12 -0800, Dylan Baker wrote:
> I don't see a problem with always using --quick, however, I believe that --
> quick is in effect when loading the quick profile.
>
> Here is how I verified it:
> cd into the piglit root and run the attached script with python. It should
> pr
On Tue, Jan 14, 2014 at 12:09 PM, Dylan Baker wrote:
> @@ -46,6 +48,19 @@ if 'MESA_DEBUG' not in os.environ:
>
>
> class Environment:
> +""" Object cointaining the piglit testing environment
s/cointaining/containing/
> +
> +Keyword Arguments:
> +concurrent -- run tests concurrently
On Mon, Jan 13, 2014 at 08:30:16PM +0800, Daniel Kurtz wrote:
> Hi Chad,
>
> With this patch applied, we don't even get as far as glGetIntegerv(),
> since we can't even resolve "glGetString" to deduce the GL_VERSION in
> piglit_dispatch_default_init()->piglit_dispatch_init()->piglit_get_gl_version
On Fri, 20 Dec 2013 16:31:52 -0800
"Ian Romanick" wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> Cc: Lauri Kasanen
> ---
> Lauri's patches to Mesa's implementation of glXGetMscRateOML inspired me
> to write this test. Previously there were *no* calls to
> glXGetMscRateOML anyw
You're right, this one is a bit odd, and the commit message didn't
really explain what I was getting at...
Most of what I was trying to do here is eliminate the hardware lod
selection as a complicating factor -- since we're really testing that
levels are view-relative. It's possible that I've misu
Hey Chris:
I think the texture level used should be clamped when using immutable
texture so if
the MAX_LEVEL is out of range it shouldn't matter. Also an unset
BASE_LEVEL should default to 0
which is relative to the view.
From arb_texture_storage:
"
Redefine level_base, level_max to be clam
For just this patch, or the series?
On Tue, Jan 14, 2014 at 1:02 PM, Jon Ashburn wrote:
> Looks good to me.
> Reviewed-by: Jon Ashburn
>
>
> On 01/11/2014 05:39 PM, Chris Forbes wrote:
>>
>> These aren't core-profile-clean. They don't bother to set up a VAO,
>> and rendering_levels tests some fi
This patch fixes a minor bug. An exception catch calls a function with a
single leading underscore instead of two leading underscores.
CC: chad.vers...@linux.intel.com
Signed-off-by: Dylan Baker
---
framework/shader_test.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
Reviewed-by: Brian Paul
On 01/13/2014 02:34 PM, Ilia Mirkin wrote:
ping^2?
On Fri, Dec 20, 2013 at 3:04 PM, Ilia Mirkin wrote:
ping?
On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
tests/texturing/array-texture.c | 12
1 file changed, 8
Looks good to me.
Reviewed-by: Jon Ashburn
On 01/11/2014 05:39 PM, Chris Forbes wrote:
These aren't core-profile-clean. They don't bother to set up a VAO,
and rendering_levels tests some fixed-function behavior.
Signed-off-by: Chris Forbes
---
tests/spec/arb_texture_view/rendering_levels.c
On Mon, Jan 13, 2014 at 09:41:20PM +0800, Daniel Kurtz wrote:
> Currently we are building a single binary for both GL and GLES.
> However, it can only be added by either CMakelists.gl or .gles, but not
> both.
>
> Instead, build two differente binaries, install each in the respective
> CMakelists,
This series is a starting point for splitting up the core module, and at
the same time cleaning them up and getting the coding standards up on
them.
Patch 1: splits the environment function out of core into it's own module
Patch 2-6: Cleans up various aspects of the code, including removing
static
This was incorrectly formatted and should have been using block comments
from the begining.
Signed-off-by: Dylan Baker
---
framework/environment.py | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/framework/environment.py b/framework/environment.py
index f7027ba..0ff20
This is really a constant, not just a variable, since changing it will
cause undefined behavior. Behond that lower cammelCase is not allowed
for variable names in pep8, so this should be changed.
This was implemented with the following command:
find . -name '*.py' | xargs -n sed -i -e 's!testBinDi
This module contains the testBinDir variable and the Environemnt class,
and is meant to hold environment settings for piglit
Signed-off-by: Dylan Baker
---
framework/core.py | 81 +-
framework/environment.py | 100
The list comprehensions are easier to read.
Signed-off-by: Dylan Baker
---
framework/environment.py | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/framework/environment.py b/framework/environment.py
index c991622..f7027ba 100644
--- a/framework/environment.py
+++ b/fra
First, static methods are ugly, and python's namespaces make them even
less interesting, since a toplevel function is like a static method but
without being part of a class. Second this static method was even worse
since it had nothing to do with the class it was attached.
This is replaced with a
This patch adds docstrings to the remaining places that are needed.
Signed-off-by: Dylan Baker
---
framework/environment.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/framework/environment.py b/framework/environment.py
index 0ff2055..c40f813 100644
--- a/framework/envir
ping^2?
On Fri, Dec 20, 2013 at 3:04 PM, Ilia Mirkin wrote:
> ping?
>
> On Sun, Dec 8, 2013 at 2:48 AM, Ilia Mirkin wrote:
>> Signed-off-by: Ilia Mirkin
>> ---
>> tests/texturing/array-texture.c | 12
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/text
I don't see a problem with always using --quick, however, I believe that --
quick is in effect when loading the quick profile.
Here is how I verified it:
cd into the piglit root and run the attached script with python. It should
print ['--quick']
On Monday, January 13, 2014 12:59:33 PM Jose Fons
I'll take a look at this. It was a concern when I was initially creating the
patch, and I thought it was working, but I might have missed something.
I can see a quick solution if this is regressed.
On Monday, January 13, 2014 12:56:23 PM Jose Fonseca wrote:
> Dylan,
>
> All my piglit jobs are t
Another solution is to hardcode "--quick" on all glean tests. I mean, does
anybody ever really want to test all possible blend state combinations? Seems
overkill..
Jose
- Original Message -
> Dylan,
>
> All my piglit jobs are timing out after this series. They appear to be taking
> fo
Dylan,
All my piglit jobs are timing out after this series. They appear to be taking
forever on
[Mon Jan 13 16:12:54 2014] :: running :: glean/blendFunc
I suspect that with the recent changes, the glean is no longer receiving the
--quick option, which is essential.
Probably because with th
On Thu, Jan 9, 2014 at 3:43 PM, Anuj Phogat wrote:
> ARB_sample_shading extension says:
> "When the sample shading fraction is 1.0, a separate set of colors
> and other associated data are evaluated for each sample, each set
> of values are evaluated at the sample location."
>
> Test passes o
On Tue, Jan 07, 2014 at 06:21:36PM -0500, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
These patches should fix this test:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20131216/199497.html
> ---
>
> Resending to not be forgotten.
>
> The last two tes
On Mon, Jan 06, 2014 at 09:54:48AM +0800, Yi Sun wrote:
> According to spec 1.1 Chapter 6.3 bullet g:
> The logical operators and (&&), or (||) operate on all scalar and vector
> built-in types except
> the built-in scalar and vector float types.
>
Reviewed-by: Tom Stellard
> Signed-off-by: Yi
Currently we are building a single binary for both GL and GLES.
However, it can only be added by either CMakelists.gl or .gles, but not
both.
Instead, build two differente binaries, install each in the respective
CMakelists, and add them both to tests/all.py.
Signed-off-by: Daniel Kurtz
---
tes
Hi Chad,
With this patch applied, we don't even get as far as glGetIntegerv(),
since we can't even resolve "glGetString" to deduce the GL_VERSION in
piglit_dispatch_default_init()->piglit_dispatch_init()->piglit_get_gl_version().
# bin/egl-create-context-valid-flag-debug gles3 -auto
piglit_dispat
29 matches
Mail list logo
