Re: [Piglit] [PATCH 1/2] KHR_debug: Support GLES2

2014-03-12 Thread Felipe Tonello
Hi Fabian, On Wed, Mar 12, 2014 at 2:24 PM, Fabian Bieler wrote: > On 2014-03-12 19:51, Felipe Tonello wrote: >> >> Hi Fabian, >> >> On Tue, Mar 11, 2014 at 5:24 PM, Fabian Bieler >> wrote: >>> >>> Hello! >>> >>> Sync objects, vertex arrays, queries, transform feedback objects and >>> sampler >>

Re: [Piglit] [PATCH 1/2] KHR_debug: Support GLES2

2014-03-12 Thread Fabian Bieler
On 2014-03-12 19:51, Felipe Tonello wrote: Hi Fabian, On Tue, Mar 11, 2014 at 5:24 PM, Fabian Bieler wrote: Hello! Sync objects, vertex arrays, queries, transform feedback objects and sampler objects are not supported by gles2. Ok. But then how would this extension work with GLES2? I don't

[Piglit] [PATCH] teximage-errors: Make changes to support core profile

2014-03-12 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- tests/texturing/teximage-errors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/texturing/teximage-errors.c b/tests/texturing/teximage-errors.c index 30b7875..1198514 100644 --- a/tests/texturing/teximage-errors.c +++ b/tests/texturing/t

Re: [Piglit] [PATCH 2/2] teximage-errors: Test the combinations of depth and depth-stencil formats

2014-03-12 Thread Brian Paul
On 03/12/2014 12:56 PM, Anuj Phogat wrote: On Wed, Mar 12, 2014 at 6:24 AM, Brian Paul mailto:bri...@vmware.com>> wrote: On 03/11/2014 06:51 PM, Anuj Phogat wrote: This patch is to verify a bug fix in mesa commit 079bff5. This commit allowed GL_DEPTH_COMPONENT and

Re: [Piglit] [PATCH 2/2] teximage-errors: Test the combinations of depth and depth-stencil formats

2014-03-12 Thread Anuj Phogat
On Wed, Mar 12, 2014 at 6:24 AM, Brian Paul wrote: > On 03/11/2014 06:51 PM, Anuj Phogat wrote: > >> This patch is to verify a bug fix in mesa commit 079bff5. This commit >> allowed GL_DEPTH_COMPONENT and GL_DEPTH_STENCIL combinations in >> glTexImage{123}D functions. >> >> Signed-off-by: Anuj Ph

Re: [Piglit] [PATCH 1/2] KHR_debug: Support GLES2

2014-03-12 Thread Felipe Tonello
Hi Fabian, On Tue, Mar 11, 2014 at 5:24 PM, Fabian Bieler wrote: > Hello! > > Sync objects, vertex arrays, queries, transform feedback objects and sampler > objects are not supported by gles2. Ok. But then how would this extension work with GLES2? I don't see anywhere in the spec saying what's t

Re: [Piglit] [PATCH 2/2] teximage-errors: Test the combinations of depth and depth-stencil formats

2014-03-12 Thread Anuj Phogat
On Wed, Mar 12, 2014 at 4:20 AM, Ken Phillis Jr wrote: > The patch looks like it has a major problem. > Do you have any objections to the changes made in this patch? > Mesa does not support OpenGL 3.x compatibility profile. This test is > currently only using a compatibility profile. I would sugg

Re: [Piglit] [PATCH 0/3] ARB_explicit_uniform_location initial tests

2014-03-12 Thread Ian Romanick
On 03/12/2014 04:22 AM, Tapani Pälli wrote: > Hi; > > Here are first tests for the ARB_explicit_uniform_location extension. > My plan is to continue writing more execution type of tests which test > setting and getting of locations and different corner cases. This set > is for the basic function

Re: [Piglit] [PATCH 1/2] teximage-errors: Run all the tests before returning result

2014-03-12 Thread Brian Paul
On 03/11/2014 06:51 PM, Anuj Phogat wrote: Signed-off-by: Anuj Phogat --- tests/texturing/teximage-errors.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/texturing/teximage-errors.c b/tests/texturing/teximage-errors.c index 221007f..39b7e9b 100644 --- a

Re: [Piglit] [PATCH 2/2] teximage-errors: Test the combinations of depth and depth-stencil formats

2014-03-12 Thread Brian Paul
On 03/11/2014 06:51 PM, Anuj Phogat wrote: This patch is to verify a bug fix in mesa commit 079bff5. This commit allowed GL_DEPTH_COMPONENT and GL_DEPTH_STENCIL combinations in glTexImage{123}D functions. Signed-off-by: Anuj Phogat --- tests/texturing/teximage-errors.c | 73 ++

[Piglit] [PATCH 2/3] util: Add INTEL_performance_query support to piglit_get_gl_enum_name().

2014-03-12 Thread Petri Latvala
Signed-off-by: Petri Latvala --- tests/util/piglit-util-gl-enum.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/util/piglit-util-gl-enum.c b/tests/util/piglit-util-gl-enum.c index 8deb58f..43032ad 100644 --- a/tests/util/piglit-util-gl-enum.c +++ b/tests/util/piglit-util-gl-enum.c

[Piglit] [PATCH 1/3] glapi: Support for INTEL_performance_query.

2014-03-12 Thread Petri Latvala
Signed-off-by: Petri Latvala --- glapi/enum.spec | 22 ++ glapi/gl.spec | 132 +++- 2 files changed, 153 insertions(+), 1 deletion(-) diff --git a/glapi/enum.spec b/glapi/enum.spec index c854b91..e0ac933 100644 --- a/glapi/enum.spec

[Piglit] [PATCH 0/3] Tests for INTEL_performance_query

2014-03-12 Thread Petri Latvala
This patch series is for testing INTEL_performance_query. The tests are based on the tests for AMD_performance_monitor. Tested with Mesa (patches for implementing this extension in Mesa are sent to mesa-dev). All tests pass. Petri Latvala (3): glapi: Support for INTEL_performance_query. util:

[Piglit] [PATCH 3/3] Add tests for the INTEL_performance_query extension.

2014-03-12 Thread Petri Latvala
As with AMD_performance_monitor, one of the challenging aspects of testing this extension is that it defines an implementation-specific set of groups and counters. Many of the tests here arbitrarily operate on the counters in the first query, while a few sanity check all counters in all queries. S

[Piglit] [PATCH 2/3] ARB_explicit_uniform_location: location qualifier compiler test

2014-03-12 Thread Tapani Pälli
Test checks that shaders using a location qualifier for uniform variable compile succesfully. Signed-off-by: Tapani Pälli --- .../compiler/layout-01.frag| 18 ++ .../compiler/layout-01.vert| 15 +++ 2 files chang

[Piglit] [PATCH 1/3] ARB_explicit_uniform_location: preprocessor define test

2014-03-12 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- tests/all.py | 7 +++ .../preprocessor/define.frag | 19 +++ .../preprocessor/define.vert | 19 +++ 3 files changed, 45 insertions(+) cr

[Piglit] [PATCH 0/3] ARB_explicit_uniform_location initial tests

2014-03-12 Thread Tapani Pälli
Hi; Here are first tests for the ARB_explicit_uniform_location extension. My plan is to continue writing more execution type of tests which test setting and getting of locations and different corner cases. This set is for the basic functionality part. These are skipped with current Mesa as it d

[Piglit] [PATCH 3/3] ARB_explicit_uniform_location: GL_MAX_UNIFORM_LOCATIONS enum test

2014-03-12 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- tests/all.py | 1 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 12 + .../arb_explicit_uniform_location/CMakeLists.txt | 1 + tests/spec/arb_explicit_u

Re: [Piglit] [PATCH 2/2] teximage-errors: Test the combinations of depth and depth-stencil formats

2014-03-12 Thread Ken Phillis Jr
The patch looks like it has a major problem. Mesa does not support OpenGL 3.x compatibility profile. This test is currently only using a compatibility profile. I would suggest copying the test into a new file for further review and to cleanly separate the core and compatibility profile tests.