If the framebuffer has no attachments at all, the first incomplete
status generated is FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT.
Adjust the tests for FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER and
FRAMEBUFFER_INCOMPLETE_READ_BUFFER to avoid tripping over this, by
adding a depth renderbuffer attachment.
I just looked over the set of patches and I noticed a few things.
1) Have you tested packaging with this? I noticed that "tese" and
"tesc" file extensions are not in the install parameter for
generated_tests and tests. I would suggest adding this to guarantee
that distributed testing continues to
Signed-off-by: Fabian Bieler
---
tests/all.py | 3 +++
.../spec/arb_tessellation_shader/compiler/define.tesc | 19 +++
.../spec/arb_tessellation_shader/compiler/define.tese | 19 +++
3 files changed, 41 insertions(+)
creat
>From the ARB_tessellation_shader spec (Section 2.14.2):
Linking will fail if the program object contains objects to form a
tessellation control shader (see section 2.X.1), and
* the program contains no objects to form a vertex shader;
>From the ARB_tessellation_shader spec (Section 2
From the ARB_tessellation_shader spec (Errors section):
"The error INVALID_OPERATION is generated by GetProgramiv if
identifies a tessellation control or evaluation shader-specific property
and has not been linked successfully, or does not contain
objects to form a shader whose type
>From the ARB_tessellation_shader spec (Section 4.3.8.2):
"It is a compile-time error if the output patch vertex count specified in
an output layout qualifier does not match the array size specified in any
output variable declaration in the same shader."
Signed-off-by: Fabian Bieler
---
.
From the ARB_tessellation_shader spec (Errors section):
"The error INVALID_OPERATION is generated by Begin (or vertex array
commands that implicitly call Begin) if the active program contains a
tessellation control or evaluation shader and the primitive mode is not
PATCHES.
The
Signed-off-by: Fabian Bieler
---
tests/util/piglit-shader.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c
index b326abd..5c7a16e 100644
--- a/tests/util/piglit-shader.c
+++ b/tests/util/piglit-shader.c
@@ -119,6 +119,10 @@ shader_n
Tessellation control shaders require the vertices output layout qualifier.
Tessellation evaluation shaders require the primitive mode input layout
qualifier. Test that linnking fails without them.
Signed-off-by: Fabian Bieler
---
.../compiler/no-input-layout.tese | 17 +
Use glGetProgramiv() to test tessellation control shader output layouts.
Signed-off-by: Fabian Bieler
---
tests/all.py | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt | 1 +
.../spec/arb_tessellation_shader/get-tcs-params.c | 114 +
Add support for tessellation control and tessellation evaluation shaders.
Signed-off-by: Fabian Bieler
---
tests/shaders/shader_runner.c | 77 +++
1 file changed, 77 insertions(+)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
Signed-off-by: Fabian Bieler
---
tests/spec/arb_tessellation_shader/compiler/sanity.tesc | 16
tests/spec/arb_tessellation_shader/compiler/sanity.tese | 12
2 files changed, 28 insertions(+)
create mode 100644 tests/spec/arb_tessellation_shader/compiler/sanity.tesc
From the ARB_tessellation_shader spec (Errors section):
"The error INVALID_VALUE is generated by PatchParameteri if is
PATCH_VERTICES and is less than or equal to zero or is greater
than the implementation-dependent maximum patch size."
Signed-off-by: Fabian Bieler
---
tests/al
Use glGetProgramiv() to test tessellation evaluation shader input layouts.
Both explicitly specified layouts as well as default layouts are tested.
Signed-off-by: Fabian Bieler
---
tests/all.py | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt |
Use glGet*v() to test GL limits and default state introduced by
arb_tessellation_shader.
Signed-off-by: Fabian Bieler
---
tests/all.py | 5 +
tests/spec/CMakeLists.txt | 1 +
.../spec/arb_tessellation_shader/CMakeLists.gl.txt |
Signed-off-by: Fabian Bieler
---
framework/glsl_parser_test.py | 11 ++-
tests/glslparsertest/glslparsertest.c | 21 -
2 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/framework/glsl_parser_test.py b/framework/glsl_parser_test.py
index 82292b5..d
Add patch parameter directive to set GL_PATCH_VERTICES,
GL_PATCH_DEFAULT_OUTER_LEVEL and GL_PATCH_DEFAULT_INNER_LEVEL.
e.g.:
patch parameter vertices 4
patch parameter default level outer 1.5 2.0 2.5 3.5
patch parameter default level inner 0.0 0.0
Signed-off-by: Fabian Bieler
---
tests/shaders/
Reviewed-by: Brian Paul
On 03/22/2014 12:20 PM, Marek Olšák wrote:
From: Marek Olšák
Instead of offsetting the vertex position for the second half of the screen,
setup both halves as separate viewports.
---
tests/general/primitive-restart-draw-mode.c | 10 --
1 file changed, 8 inse
Test has a structure with explicit location, all its elements should get
sequential locations as specified.
Signed-off-by: Tapani Pälli
---
tests/all.py | 1 +
.../CMakeLists.gl.txt | 1 +
.../struct-elements.c
On 03/24/2014 12:52 PM, Tapani Pälli wrote:
Test has a shader with only one uniform which is not used. Test checks
that uniform gets its defined explicit location and that there are no
errors generated when glUniform is called to update its value.
Test test does not pass with GTX 660 running the
Test has a shader with only one uniform which is not used. Test checks
that uniform gets its defined explicit location and that there are no
errors generated when glUniform is called to update its value.
Test test does not pass with GTX 660 running the Nvidia proprietary
driver for Linux version 3
Hi;
I'm currently implementing support for inactive uniforms with explicit
lcoation set for glGetUniformLocation and glUniform* functions.
Following test now passes with my Mesa branch, however it did not pass
on Nvidia. Hopefully I'm reading the spec right, I would appreciate
comments on this.
22 matches
Mail list logo
