On Thursday, March 27, 2014 17:01:24 Dylan Baker wrote:
> On Thursday, March 27, 2014 15:34:03 Dylan Baker wrote:
> > Rather than have 2 base classes, let's just have one.
> >
> > v2: - remove test that no longer is valid
> >
> > Signed-off-by: Dylan Baker
> > ---
> >
> > framework/exectest.py
Rather than have 2 base classes, let's just have one.
v2: - remove test that no longer is valid
Signed-off-by: Dylan Baker
---
framework/exectest.py| 26 +-
framework/gleantest.py | 12 ++--
framework/gtest.py | 4 ++--
framew
This vastly simplifies the way that GLSLParserTest works. This
simplification has a couple of advantages. First, we call
PlainExecTest's __init__ rather than ExecTest's __init__, which is good
OO practice; second we reduce the number of regex's used, which yields
enhanced performance. In tests this
Shader_test has a bizarre capability to be run as a standalone script as
well as be used as a module. This was probably useful when developing
the original shader_test implementation, but at this point it's unused
code just waiting to bit-rot adding needless complexity
Signed-off-by: Dylan Baker
Since PlainExecTest is either used directly or as a parent for running
"native" piglit tests, it seems fitting to give it a name that reflects
that purpose.
This patch was mostly generated with the following command:
find . -name '*.py' | xargs sed -i -e 's!PlainExecTest!PiglitTest!g
Then a handf
The example glsl parser test doesn't list end_config as acceptable, and
there are only 5 tests using end_config, so it makes sense to just fix
those tests rather than generating slower more complicated regex for
handling end_config.
Signed-off-by: Dylan Baker
---
.../spec/glsl-1.20/compiler/qual
This adds some additional tests for ShaderTest behavior. Some of these
tests fail because of dumb implementation details.
Signed-off-by: Dylan Baker
---
framework/tests/shader_test_tests.py | 57 ++--
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git a/
These tests model future behavior rather than current behavior, some of
them pass, others fail.
Signed-off-by: Dylan Baker
---
framework/tests/glsl_parser_test_tests.py | 120 ++
framework/tests/glsl_parser_tests.py | 29
2 files changed, 120 insertions
Since Test is exclusively used as a parent for ExecTest, the two classes
should be in the same module.
Signed-off-by: Dylan Baker
---
framework/core.py| 70 --
framework/exectest.py| 72 +++-
fram
This patch almost completely reworks ShaderTest. It was originally much
more complicated than was necessary, this code should be much easier to
work with, and removes some quirks. One of those was that ShaderTest
inherited from PlainExecTest, but used ExecTest's __init__ method, which
has implicati
This is mostly consumed by Test's children, so putting it in the same
module makes sense. This should reduce the number of imports from core
as well, since most consumers of testBinDir also make use of ExecTest or
PlainExecTest.
Signed-off-by: Dylan Baker
---
framework/core.py
This removes the standalone run functionality from glsl_parser_test.
Like shader_test this was probably useful for testing while in
development, but at this point it's just dead code.
Signed-off-by: Dylan Baker
---
framework/glsl_parser_test.py | 35 +--
1 file ch
This series refactors and simplifies the Test classes in piglit. It's
goal is to have a single abstract base class Test, which should be the
parent of most test classes. PlainExecTest (renamed PiglitTest) derives
from this class, while GLSLParserTest and ShaderTest derive from
PiglitTest. IGTTest,
On Thursday, March 27, 2014 15:52:49 Thomas Wood wrote:
> The extra newline is no longer necessary as the final summary line
> includes one.
>
> Signed-off-by: Thomas Wood
> ---
> piglit-resume.py | 3 +--
> piglit-run.py| 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --g
On Thu, Mar 27, 2014 at 08:08:50AM -0700, Jose Fonseca wrote:
> I think it would be more portable to use FindThreads module that comes with
> cmake. e.g.:
>
> find_package (Threads)
>
> target_link_libraries (my_program
> ${CMAKE_THREAD_LIBS_INIT}
> )
>
> if (CMAKE_USE_PTHREADS_INIT
Updated series based on Dylan Baker's review.
Thomas Wood (3):
framework/log.py: ensure any previous output is cleared
framework: print a summary line after a run has finished
Remove extra newline from the end of run message
framework/core.py | 2 ++
framework/log.py | 37 +++
v2: split output writing into a private method (Dylan Baker)
Signed-off-by: Thomas Wood
---
framework/core.py | 2 ++
framework/log.py | 44 +++-
2 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/framework/core.py b/framework/core.py
index
The extra newline is no longer necessary as the final summary line
includes one.
Signed-off-by: Thomas Wood
---
piglit-resume.py | 3 +--
piglit-run.py| 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/piglit-resume.py b/piglit-resume.py
index c9cb72b..09d0664 100755
---
If the new summary line is shorter than the previous one, clear the
remaining characters.
v2: remove unused variable and use str.format (Dylan Baker)
Signed-off-by: Thomas Wood
---
framework/log.py | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/framewor
I think it would be more portable to use FindThreads module that comes with
cmake. e.g.:
find_package (Threads)
target_link_libraries (my_program
${CMAKE_THREAD_LIBS_INIT}
)
if (CMAKE_USE_PTHREADS_INIT)
add_definitions(-DPIGLIT_HAS_PTHREADS)
endif ()
etc.
Jose
- Origin
v2: Also test GL_COMPILE_AND_EXECUTE mode.
---
tests/all.py |1 +
tests/spec/CMakeLists.txt |1 +
tests/spec/gl-1.4/CMakeLists.gl.txt | 14 ++
tests/spec/gl-1.4/CMakeLists.txt |1 +
tests/spec/gl-1.4/dlist-multidrawarrays.c
21 matches
Mail list logo
