[Piglit] [PATCH] cl: Add test for the r600g mapping bug

2014-05-19 Thread Bruno Jiménez
--- tests/cl.py| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/r600-mapping-bug.c | 95 ++ 3 files changed, 97 insertions(+) create mode 100644 tests/cl/custom/r600-mapping-bug.c diff --git a/tests/cl.py

[Piglit] [PATCH 1/5] fbo-drawbuffers-none: Add the instructions for running subtests

2014-05-19 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../arb_framebuffer_object/fbo-drawbuffers-none.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_framebuffer_object/fbo-drawbuffers-none.c

[Piglit] [PATCH 4/5] fbo-drawbuffers-none: Add a sub test for fragment shader out variables

2014-05-19 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.py | 1 + .../arb_framebuffer_object/fbo-drawbuffers-none.c | 22 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index

[Piglit] [PATCH 2/5] fbo-drawbuffers-none: Move the drawing code to piglit_display()

2014-05-19 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../arb_framebuffer_object/fbo-drawbuffers-none.c | 39 -- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/tests/spec/arb_framebuffer_object/fbo-drawbuffers-none.c

[Piglit] [PATCH 3/5] fbo-drawbuffers-none: Refactor the code to add a sub test

2014-05-19 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/spec/arb_framebuffer_object/fbo-drawbuffers-none.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/spec/arb_framebuffer_object/fbo-drawbuffers-none.c

[Piglit] [PATCH 5/5] fbo-drawbuffers-none: Use util function streq() in place of strcmp()

2014-05-19 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../spec/arb_framebuffer_object/fbo-drawbuffers-none.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/spec/arb_framebuffer_object/fbo-drawbuffers-none.c

Re: [Piglit] [PATCH 4/5] fbo-drawbuffers-none: Add a sub test for fragment shader out variables

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 4:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.py | 1 + .../arb_framebuffer_object/fbo-drawbuffers-none.c | 22 +- 2 files changed, 22

[Piglit] [PATCH 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 77 +--- 1 file changed, 29 insertions(+), 48 deletions(-) diff --git a/generated_tests/gen_const_builtin_equal_tests.py

[Piglit] [PATCH 1/4] gen_const_builtin_equal_tests.py: Use mako

2014-05-19 Thread Dylan Baker
This uses mako to render tests. It's faster than the previous method, and is much easier to understand. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 87 ++-- 1 file changed, 50 insertions(+), 37 deletions(-) diff

[Piglit] Cleanups for gen_const_builtine_equal_tests.py

2014-05-19 Thread Dylan Baker
This series does some small cleanups and optimizations to this test generator. Patch 1: converts to using mako. This is cleaner and easier to read than the previous implementation Patch 2: Use a main() function Patch 3: simplify and combine loops with enumerate Patch 4: small cleanups

[Piglit] [PATCH 2/4] gen_const_builtin_equal_tests.py: Wrap main in a function

2014-05-19 Thread Dylan Baker
This creates main() function and puts things in it. This is good python style. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 54 +--- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git

[Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
This combines the two loops into a single loop using enumerate. This should be a little faster since we loop over the data only once, and since it uses enumerate instead of math. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 17

Re: [Piglit] [PATCH 1/4] gen_const_builtin_equal_tests.py: Use mako

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: This uses mako to render tests. It's faster than the previous method, and is much easier to understand. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 87

Re: [Piglit] [PATCH 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 77 +--- 1 file changed, 29 insertions(+), 48 deletions(-) diff --git

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: This combines the two loops into a single loop using enumerate. This should be a little faster since we loop over the data only once, and since it uses enumerate instead of math. Signed-off-by: Dylan Baker

Re: [Piglit] [PATCH 1/4] gen_const_builtin_equal_tests.py: Use mako

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 5:48 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, May 19, 2014 17:47:47 Ilia Mirkin wrote: On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: This uses mako to render tests. It's faster than the previous method, and is much

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
On Monday, May 19, 2014 17:56:41 Ilia Mirkin wrote: On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: This combines the two loops into a single loop using enumerate. This should be a little faster since we loop over the data only once, and since it uses enumerate

Re: [Piglit] [PATCH 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 6:00 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, May 19, 2014 17:54:28 Ilia Mirkin wrote: On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: Signed-off-by: Dylan Baker baker.dyla...@gmail.com ---

Re: [Piglit] [PATCH 4/5] fbo-drawbuffers-none: Add a sub test for fragment shader out variables

2014-05-19 Thread Anuj Phogat
On Mon, May 19, 2014 at 1:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 19, 2014 at 4:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.py | 1 +

Re: [Piglit] [PATCH 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Dylan Baker
On Monday, May 19, 2014 18:04:29 Ilia Mirkin wrote: On Mon, May 19, 2014 at 6:00 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, May 19, 2014 17:54:28 Ilia Mirkin wrote: On Mon, May 19, 2014 at 5:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: Signed-off-by: Dylan Baker

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
[snip] +for test_id, x in enumerate(test_vectors, 2): While I'm not totally against this, I'd like you to consider just adding the 2 below to test_id. I believe that I'm fairly knowledgeable about python builtins, and I still had to look that up -- I had never come across it

Re: [Piglit] [PATCH 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Ilia Mirkin
On Mon, May 19, 2014 at 6:12 PM, Dylan Baker baker.dyla...@gmail.com wrote: [snip] + for test_id, x in enumerate(test_vectors, 2): While I'm not totally against this, I'd like you to consider just adding the 2 below to test_id. I believe that I'm fairly knowledgeable about python

[Piglit] [Patch v2 3/4] gen_const_builtin_equal_tests.py: use enumerate instead of a flag

2014-05-19 Thread Dylan Baker
This combines the two loops into a single loop using enumerate. This should be a little faster since we loop over the data only once, and since it uses enumerate instead of math. v2: - explicitly name enumerate's start parameter to make it clearer Signed-off-by: Dylan Baker

[Piglit] [Patch v2 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Dylan Baker
v2: - fix one additional pylint warning for long lines - reformat the TEST_VECTORS list to have better whitespace between the groups. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 90 +++- 1 file changed,

[Piglit] [Patch v2 1/4] gen_const_builtin_equal_tests.py: Use mako

2014-05-19 Thread Dylan Baker
This uses mako to render tests. It's faster than the previous method, and is much easier to understand. v2: - set write mode to 'w' instead of 'w+'. w+ is a development artifact and should have been set to 'w' before submission Signed-off-by: Dylan Baker baker.dyla...@gmail.com ---

[Piglit] [Patch v2 2/4] gen_const_builtin_equal_tests.py: Wrap main in a function

2014-05-19 Thread Dylan Baker
This creates main() function and puts things in it. This is good python style. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- generated_tests/gen_const_builtin_equal_tests.py | 55 +--- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git

Re: [Piglit] [Patch v2 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Thanks for bearing with my nitpicks :) On Mon, May 19, 2014 at 8:42 PM, Dylan Baker baker.dyla...@gmail.com wrote: v2: - fix one additional pylint warning for long lines - reformat the TEST_VECTORS list to have better whitespace

Re: [Piglit] [Patch v2 4/4] gen_const_builtin_equal_tests.py: cleanup a few pylint errors

2014-05-19 Thread Dylan Baker
On Monday, May 19, 2014 20:50:17 Ilia Mirkin wrote: Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Thanks for bearing with my nitpicks :) no problem, you're a much better programmer than I am, I always learn something new and better for your nitpicks :) [snip] signature.asc

[Piglit] I want to know how to add blacklist for piglit?

2014-05-19 Thread Fu, Ping
Hi kenneth, I have lots of test cases which should be shield because of ASIC hang, I want to know how to add them to blacklist, it seems commit bd73f16376295692dd0e3656dd69505f564659b3 had removed this feature. But for some hang bugs it's very useful, I want to know if there is alternative

Re: [Piglit] I want to know how to add blacklist for piglit?

2014-05-19 Thread Kenneth Graunke
On 05/19/2014 08:58 PM, Fu, Ping wrote: Hi kenneth, I have lots of test cases which should be shield because of ASIC hang, I want to know how to add them to blacklist, it seems commit bd73f16376295692dd0e3656dd69505f564659b3 had removed this feature. But for some hang bugs it’s very useful,

Re: [Piglit] I want to know how to add blacklist for piglit?

2014-05-19 Thread Fu, Ping
Yes, it is of great help for me, thanks very much! -Original Message- From: Kenneth Graunke [mailto:kenn...@whitecape.org] Sent: Tuesday, May 20, 2014 12:55 To: Fu, Ping Cc: piglit@lists.freedesktop.org Subject: Re: I want to know how to add blacklist for piglit? On 05/19/2014 08:58 PM,