Re: [Piglit] [PATCH] Add a test to reject semicolons after #extension.

2014-06-12 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2] glsl-1.30: test unsigned vs signed in switch statement

2014-06-12 Thread Matt Turner
Thanks Tapani. Looks good to me. Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] framework/summary/html: Prevent forward slashes in URLs.

2014-06-12 Thread jfonseca
From: José Fonseca jfons...@vmware.com It's fine for URLs to have forward slash directory separators when viewing the HTML on Windows. But if one moves the HTML report to a Linux machine or puts it on a web-server and accesses it from a Linux machine then URLs with forward slashes become dead.

Re: [Piglit] [PATCH] framework/summary/html: Prevent forward slashes in URLs.

2014-06-12 Thread Brian Paul
Just to be clear, I think forward slash is / while backward slash is \. -Brian On 06/12/2014 06:22 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com It's fine for URLs to have forward slash directory separators when viewing the HTML on Windows. But if one moves the HTML

[Piglit] [PATCH] piglit (executable): Make PIGLIT_SOURCE_DIR detection more robust

2014-06-12 Thread Dylan Baker
The initial implementation I committed was a bit hackish and I knew it at the time, but it seemed to work for all the cases that I tested. However, there were corner cases. The biggest of these cases is problems running out of tree with piglit built in tree. ex: src/piglit/piglit run ... This

Re: [Piglit] [PATCH] cl: Add test for the r600g mapping bug

2014-06-12 Thread Tom Stellard
On Mon, May 19, 2014 at 06:23:30PM +0200, Bruno Jiménez wrote: --- tests/cl.py| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/r600-mapping-bug.c | 95 ++ 3 files changed, 97 insertions(+) create mode 100644

Re: [Piglit] [PATCH 4/5] cl: Add isnotequal(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:14PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-relational-builtins.py

Re: [Piglit] [PATCH 2/5] cl: Add isgreater(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:12PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

Re: [Piglit] [PATCH 1/5] cl: Add TRUE definition with type dependent value for generated tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:11PM -0500, Aaron Watry wrote: Scalar true is 1, but vector true is -1. This means that getValue needs to know if we are requesting TRUE for a scalar or vector. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com ---

Re: [Piglit] [PATCH 3/5] cl: Add isgreaterequal(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:13PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 5/5] cl: Add signbit(float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:15PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 9 + 1 file changed, 9 insertions(+) diff --git a/generated_tests/generate-cl-relational-builtins.py

Re: [Piglit] [PATCH 1/3] cl: Add isequal(float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:29PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [Piglit] [PATCH 2/3] cl: Add 3-arg TTS kernel type

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:30PM -0500, Aaron Watry wrote: For built-ins with (vec, vec, scalar) arguments (such as mix) Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/genclbuiltins.py | 20 +--- 1 file

Re: [Piglit] [PATCH 3/3] cl: Add mix tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:31PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Piglit] [PATCH] cl-program-tester: Fix regexec usage.

2014-06-12 Thread Tom Stellard
On Sun, Jun 01, 2014 at 08:28:32PM -0700, Vinson Lee wrote: This patch fixes this GCC warning. program-tester.c: In function ‘parse_name’: program-tester.c:1131:2: warning: passing argument 4 of ‘regexec’ from incompatible pointer type [enabled by default] if (!regexec(regex, input, 1,