Re: [Piglit] [PATCH] tests/all.py: Fix bug that erases tests

2014-06-18 Thread Jordan Justen
Reviewed-by: Jordan Justen On Tue, Jun 17, 2014 at 8:45 AM, Dylan Baker wrote: > Previously spec['glsl-3.30'] was initialized to {} twice, meaning all > tests added before the second assignment were discarded. > > Signed-off-by: Dylan Baker > --- > tests/all.py | 5 ++--- > 1 file changed, 2 i

Re: [Piglit] [PATCH V4 02/11] arb_arrays_of_arrays: add more initializer tests

2014-06-18 Thread Matt Turner
On Wed, Jun 18, 2014 at 4:03 PM, Marek Olšák wrote: > These tests (and others) are run even if ARB_arrays_of_arrays isn't > supported. Maybe the extension checking is broken? >> + * require_extensions: GL_ARB_arrays_of_arrays >> + * require_extensions: GL_ARB_shading_language_420pack Probably be

Re: [Piglit] [PATCH V4 02/11] arb_arrays_of_arrays: add more initializer tests

2014-06-18 Thread Marek Olšák
These tests (and others) are run even if ARB_arrays_of_arrays isn't supported. Maybe the extension checking is broken? Marek On Sat, Jun 14, 2014 at 2:35 PM, Timothy Arceri wrote: > Test results are from the following hardware/driver combinations: > > AMD Radeon HD 6670 - Catalyst 13.251 OpenGL

Re: [Piglit] [PATCH] tests/all.py: Fix bug that erases tests

2014-06-18 Thread Dylan Baker
This is a pretty trivial bugfix, I'm gonna push it at the end of the day if no one objects before then On Tuesday, June 17, 2014 08:45:49 AM Dylan Baker wrote: > Previously spec['glsl-3.30'] was initialized to {} twice, meaning all > tests added before the second assignment were discarded. > > S

Re: [Piglit] Core vs compat 3.1 contexts

2014-06-18 Thread Ken Phillis Jr
I think this is a case where using the forward compatibility bit may be a reasonable fix. This is because it will always disable the compatibility profile on core... http://www.opengl.org/wiki/Core_And_Compatibility_in_Contexts On Jun 18, 2014 4:43 PM, "Chad Versace" wrote: > On Wed, Jun 18, 201

Re: [Piglit] Core vs compat 3.1 contexts

2014-06-18 Thread Chad Versace
On Wed, Jun 18, 2014 at 12:29:09AM +0100, Emil Velikov wrote: > On 17/06/14 23:50, Ian Romanick wrote: > > On 06/16/2014 11:29 PM, Ilia Mirkin wrote: > > This poses a problem for piglit. We want to make tests for things that > > don't have GL_ARB_compatibility, but we can't actually ask for that.

Re: [Piglit] [PATCH 1/2] arb_shader_atomic_counters: fix gs support check

2014-06-18 Thread Chris Forbes
These are both Reviewed-by: Chris Forbes On Tue, Jun 17, 2014 at 5:52 PM, Ilia Mirkin wrote: > --- > > Not actually an issue on the blob, since it supports ARB_geometry_shader4, but > Chris Forbes pointed it out. This also works. > > tests/spec/arb_shader_atomic_counters/common.c | 2 +- > 1 f

Re: [Piglit] [PATCH] arb_texture_query_lod: allow some tolerance for comparisons

2014-06-18 Thread Marek Olšák
On Wed, Jun 18, 2014 at 6:47 AM, Matt Turner wrote: > I'm sort of skeptical. Firstly, why are you only modifying three of > the four tests? I only modified the conditionals which need changes for radeonsi. I didn't modify all of them. > > On Tue, Jun 17, 2014 at 12:49 PM, Marek Olšák wrote: >>

Re: [Piglit] [PATCH 1/3] shader_runner: Add 'atomic counters' command

2014-06-18 Thread Jordan Justen
On 2014-06-18 01:47:21, Chris Forbes wrote: > Not really thrilled with the parens in 2/3, but I need this working > for the tests I'm writing :) I'll drop the parens. > This series is: > > Reviewed-by: Chris Forbes Thanks! > On Sun, Jun 8, 2014 at 6:58 AM, Jordan Justen > wrote: > > This co

Re: [Piglit] [PATCH] ARB_explicit_uniform_location: change compiler test requirements

2014-06-18 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] pbo-readpixels-small: restore 2x2 window size, report SKIP for other sizes

2014-06-18 Thread Brian Paul
This test requires a 2x2 window size- it's not just the glReadPixels(2x2) that matters. --- tests/general/pbo-readpixels-small.c |9 + 1 file changed, 9 insertions(+) diff --git a/tests/general/pbo-readpixels-small.c b/tests/general/pbo-readpixels-small.c index 900a929..9f2f338 10064

Re: [Piglit] [PATCH 3/4] pbo-readpixels-small: use default window size

2014-06-18 Thread Brian Paul
On 06/17/2014 04:38 PM, Ian Romanick wrote: This test is specifically trying to exercise a bug with reading very small windows. Changing the window size makes the test useless. From the test: /** @file pbo-readpixels-small.c * * Tests that reading 2x2 BGRA UNSIGNED_BYTE buffers work correc

[Piglit] [PATCH] ARB_explicit_uniform_location: change compiler test requirements

2014-06-18 Thread Tapani Pälli
This is a leftover from commit 238768a changes. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80118 --- tests/spec/arb_explicit_uniform_location/compiler/layout-01.frag | 2 +- tests/spec/arb_explicit_uniform_location/compiler/layout-01.vert | 2 +- 2 files c