Re: [Piglit] [Patch v2 4/5] framework: refactor the log module

On Mon, Jul 7, 2014 at 8:17 PM, Dylan Baker wrote: > On Monday, July 07, 2014 07:35:55 PM Ilia Mirkin wrote: >> On Sun, Jul 6, 2014 at 3:13 AM, Dylan Baker wrote: >> > This refactors the log module away from a single class that does >> > everything to having two classes. The first class LogFactor

Re: [Piglit] [Patch v2 4/5] framework: refactor the log module

On Monday, July 07, 2014 07:35:55 PM Ilia Mirkin wrote: > On Sun, Jul 6, 2014 at 3:13 AM, Dylan Baker wrote: > > This refactors the log module away from a single class that does > > everything to having two classes. The first class LogFactory, is a state > > manager that returns BaseLog derived ob

Re: [Piglit] [Patch v2 5/5] framework: Add dummy logger that produces no output

On Sun, Jul 6, 2014 at 3:13 AM, Dylan Baker wrote: > This adds a new logger option that produces no output. This is aimed at > headless setups or for systems like jenkins where the output data isn't > very useful. > > Signed-off-by: Dylan Baker > --- > framework/log.py | 13 +

Re: [Piglit] [Patch v2 4/5] framework: refactor the log module

On Sun, Jul 6, 2014 at 3:13 AM, Dylan Baker wrote: > This refactors the log module away from a single class that does > everything to having two classes. The first class LogFactory, is a state > manager that returns BaseLog derived objects when it's get() method is > called. However, it mainly act

Re: [Piglit] [Patch v2 1/4] framework: allow loading a piglit.conf from more locations

On Monday, July 07, 2014 04:20:35 PM Dylan Baker wrote: > With this patch piglit.conf can live in a number of different places. It > can live in the current directory, then in XDG_CONFIG_HOME > ($HOME/.config by default), and finally in the piglit source directory. > > v2: - fix types (chadv) >

[Piglit] [Patch v2 3/4] igt: use piglit.conf instead of a symlink

v2: - change bindir to path (chadv) Signed-off-by: Dylan Baker --- piglit.conf.example | 4 tests/igt.py| 12 +--- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/piglit.conf.example b/piglit.conf.example index bff3cfe..8ebef8f 100644 --- a/piglit.conf.exampl

[Piglit] Use config file for external suite locations v2

This is a v2 of a series I sent out previously, it changes external suite integration to use piglit.conf instead of symlinks in the bin directory. It also adds support for putting piglit.conf files in more persistent locations, namely $HOME/.config or $XDG_CONFIG_HOME. With these two changes it is

[Piglit] [Patch v2 1/4] framework: allow loading a piglit.conf from more locations

With this patch piglit.conf can live in a number of different places. It can live in the current directory, then in XDG_CONFIG_HOME ($HOME/.config by default), and finally in the piglit source directory. v2: - fix types (chadv) - change load order to make ./.piglit.conf load first (chadv)

[Piglit] [Patch v2 2/4] xts.py: Use piglit.conf to set bindir

v2: - replace config name bindir with path (chadv) Signed-off-by: Dylan Baker --- piglit.conf.example | 3 +++ tests/xts.py| 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/piglit.conf.example b/piglit.conf.example index 72ee1ef..bff3cfe 100644 --- a/piglit.conf.e

[Piglit] [Patch v2 4/4] oglconform.py: Use config file instead of symlink

v2: - change bindir to path (chadv) Signed-off-by: Dylan Baker --- piglit.conf.example | 4 tests/oglconform.py | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/piglit.conf.example b/piglit.conf.example index 8ebef8f..61a28cf 100644 --- a/piglit.conf.example +++ b/p

Re: [Piglit] [PATCH 1/4] glean/glsl1: Delete duplicated conditional expressions tests.

Series is Reviewed-by: Chris Forbes On Tue, Jul 8, 2014 at 9:14 AM, Matt Turner wrote: > --- > tests/all.py | 2 -- > tests/glean/tglsl1.cpp | 24 > 2 files changed, 26 deletions(-) > > diff --git a/tests/all.py b/tests/all.py > index fc92d51..8951f9e 100644

[Piglit] [PATCH 3/4] glean/glsl1: Delete duplicated uniform/varying tests.

--- tests/all.py | 4 --- tests/glean/tglsl1.cpp | 78 -- 2 files changed, 82 deletions(-) diff --git a/tests/all.py b/tests/all.py index 802d415..7cb2936 100644 --- a/tests/all.py +++ b/tests/all.py @@ -167,10 +167,6 @@ glean_glsl_tests

[Piglit] [PATCH 4/4] glean/glsl1: Delete duplicated gl_FrontFacing tests.

Tested by tests/shaders/glsl-fs-frontfacing.shader_test. --- tests/all.py | 2 -- tests/glean/tglsl1.cpp | 22 -- 2 files changed, 24 deletions(-) diff --git a/tests/all.py b/tests/all.py index 7cb2936..5e78fea 100644 --- a/tests/all.py +++ b/tests/all.py @@ -174,8

[Piglit] [PATCH 2/4] glean/glsl1: Delete duplicated indexing tests.

--- tests/all.py | 11 --- tests/glean/tglsl1.cpp | 209 - 2 files changed, 220 deletions(-) diff --git a/tests/all.py b/tests/all.py index 8951f9e..802d415 100644 --- a/tests/all.py +++ b/tests/all.py @@ -165,17 +165,6 @@ glean_glsl_test

[Piglit] [PATCH 1/4] glean/glsl1: Delete duplicated conditional expressions tests.

--- tests/all.py | 2 -- tests/glean/tglsl1.cpp | 24 2 files changed, 26 deletions(-) diff --git a/tests/all.py b/tests/all.py index fc92d51..8951f9e 100644 --- a/tests/all.py +++ b/tests/all.py @@ -164,8 +164,6 @@ glean_glsl_tests = [ 'gl

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

On Fri, Jul 4, 2014 at 7:09 AM, Marek Olšák wrote: > This adds tests for all GLSL texture function. The tex-miplevel-selection > test is used, since it's a good foundation for testing texturing with mipmaps. Once this goes in, could you make a pass over tests/glean/tglsl1.cpp and delete the text

[Piglit] [PATCH] builtin tests: Add abs with neg/not tests for logical instructions.

Obviously the abs(-x) cases shouldn't generate instructions with both source modifiers, but might as well test them. --- generated_tests/builtin_function.py | 36 1 file changed, 36 insertions(+) diff --git a/generated_tests/builtin_function.py b/generated_te

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

On Mon, Jul 7, 2014 at 1:37 PM, Marek Olšák wrote: > Thanks. > > Again, the only thing which isn't tested is textureGrad with cubemaps. > Hopefully I will find some time to add those too. I think the only > driver which actually does textureGrad with cubemaps correctly is > llvmpipe. > > BTW, I ki

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

Thanks. Again, the only thing which isn't tested is textureGrad with cubemaps. Hopefully I will find some time to add those too. I think the only driver which actually does textureGrad with cubemaps correctly is llvmpipe. BTW, I kinda like () and *, because they look good in the summary and I alw

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

I still think it'd be nice not to have to have special shell chars as args. Also the fact is that piglit doesn't escape them on the summary... not even sure how you'd do that... I definitely don't want to see texture\(\). I'd just remove the *'s entirely, and 'texture()' -> texture, 'texture(bias)'

Re: [Piglit] [PATCH] cmake: Require Mako >= 0.7

On 07/07/2014 09:26 AM, Brian Paul wrote: I'm having trouble with Mako since the requirement bump. I had an older version of Mako installed. I tried upgrading with "sudo pip install --user --upgrade Mako" but that didn't seem to work. Then I uninstalled Mako and tried installing again. The i

Re: [Piglit] [PATCH] cmake: Require Mako >= 0.7

I'm having trouble with Mako since the requirement bump. I had an older version of Mako installed. I tried upgrading with "sudo pip install --user --upgrade Mako" but that didn't seem to work. Then I uninstalled Mako and tried installing again. The installation had some warnings but seems

Re: [Piglit] [PATCH] ext_framebuffer_multisample: Add NORETURN attribute to print_usage_and_exit.

On 07/03/2014 06:04 PM, Vinson Lee wrote: Silence clang sometimes-uninitialized warning. accuracy.cpp:130:13: warning: variable 'test_type' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] } else if (strcmp(argv[2], "depth_resolve") == 0) {

[Piglit] [PATCH] gl-3.0: add a test to stress the bound resource limits

With this patch, we add a test that will stress the bound resource limits as determined by the GL API getInteger values. The bound resources are populated with floats given a table of primes. Each contribution is multiplied into the final expression, and uniquely represents the successful reference

[Piglit] [PATCH] glsl-1.30: test modf

From: Dave Airlie The generated tests don't test this due to its unusual output nature, and we had no other tests that I could find for it. So plug that hole. I just handcoded up this batch of tests in the same style as generated ones. Signed-off-by: Dave Airlie --- .../glsl-1.30/execution/fs