Re: [Piglit] [PATCH]tests/all.py: Fix built-in-constants* tests to use fullpath to shaders.

2014-07-10 Thread Dylan Baker
On Thursday, July 10, 2014 12:34:21 PM Alan Hourihane wrote: > The built-in-constants tests have been crashing for me due to them not > passing the full path as do other tests. > > Alan. > - > Author: Alan Hourihane > Date: Thu Jul 10 12:28:12 2014 +0100 > > tests/all.py: Fix built-in-

Re: [Piglit] [PATCH] shader_runner: Set uniform block bindings for multiple UBOs

2014-07-10 Thread Anuj Phogat
On Sun, Jul 6, 2014 at 1:08 AM, Chris Forbes wrote: > glLinkProgram (re)sets all uniform block bindings to zero. If we want > to actually use multiple uniform blocks, we need to call > glUniformBlockBinding to specify which binding point goes with which > uniform block. > > Signed-off-by: Chris Fo

Re: [Piglit] [PATCH] glsl-1.30: test modf

2014-07-10 Thread Ian Romanick
I looked at the first couple closely, and I skimmed the rest. Did you test these on any non-Mesa drivers? Either way, Reviewed-by: Ian Romanick On 07/07/2014 01:27 AM, Dave Airlie wrote: > From: Dave Airlie > > The generated tests don't test this due to its unusual output nature, and > we ha

Re: [Piglit] [PATCH 1/2] Remove tests/shaders/link-mismatch-layout-0[13]

2014-07-10 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 07/06/2014 03:01 AM, Chris Forbes wrote: > These date back to a time before shader_runner was capable of testing > this case. Now redundant. > > Signed-off-by: Chris Forbes > --- > tests/all.py| 2 - > tests/shaders/CMakeList

Re: [Piglit] [Patch v2 2/4] xts.py: Use piglit.conf to set bindir

2014-07-10 Thread Chad Versace
On 07/07/2014 04:20 PM, Dylan Baker wrote: v2: - replace config name bindir with path (chadv) Signed-off-by: Dylan Baker --- piglit.conf.example | 3 +++ tests/xts.py| 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/piglit.conf.example b/piglit.conf.example i

Re: [Piglit] [Patch v2 1/4] framework: allow loading a piglit.conf from more locations

2014-07-10 Thread Chad Versace
On 07/07/2014 04:20 PM, Dylan Baker wrote: With this patch piglit.conf can live in a number of different places. It can live in the current directory, then in XDG_CONFIG_HOME ($HOME/.config by default), and finally in the piglit source directory. v2: - fix types (chadv) - change load order

Re: [Piglit] [PATCH]tests/all.py: Fix built-in-constants* tests to use fullpath to shaders.

2014-07-10 Thread Brian Paul
On 07/10/2014 05:34 AM, Alan Hourihane wrote: The built-in-constants tests have been crashing for me due to them not passing the full path as do other tests. Alan. - Author: Alan Hourihane Date: Thu Jul 10 12:28:12 2014 +0100 tests/all.py: Fix built-in-constants* tests to use fullpa

[Piglit] [PATCH]tests/all.py: Fix built-in-constants* tests to use fullpath to shaders.

2014-07-10 Thread Alan Hourihane
The built-in-constants tests have been crashing for me due to them not passing the full path as do other tests. Alan. - Author: Alan Hourihane Date: Thu Jul 10 12:28:12 2014 +0100 tests/all.py: Fix built-in-constants* tests to use fullpath to shaders. diff --git a/tests/all.py b/tests