Re: [Piglit] [PATCH] Add test to verify glTexSubImage2D() with depth formats

2014-08-06 Thread Brian Paul
On 08/05/2014 08:07 PM, Anuj Phogat wrote: This test verifies the bug fix in i965 drivers in mesa commit 984a02b. Reproduces another bug in the driver with GL_DEPTH_COMPONENT16 internal format. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/texturing/CMakeLists.gl.txt |

Re: [Piglit] [PATCH] Add test to verify glTexSubImage2D() with depth formats

2014-08-06 Thread Anuj Phogat
On Wed, Aug 6, 2014 at 5:53 AM, Brian Paul bri...@vmware.com wrote: On 08/05/2014 08:07 PM, Anuj Phogat wrote: This test verifies the bug fix in i965 drivers in mesa commit 984a02b. Reproduces another bug in the driver with GL_DEPTH_COMPONENT16 internal format. Signed-off-by: Anuj Phogat

Re: [Piglit] Help with finishing ARB_arrays_of_arrays

2014-08-06 Thread Matt Turner
On Thu, Jul 31, 2014 at 5:04 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Hi guys. Is anyone interested in helping me finish of the arrays of arrays extension by taking on a mentor type role for reviewing my piglit tests? I'm just looking for someone I can cc in on the tests that will get

[Piglit] [PATCH 1/3] attribs: add support for the SNORM equation 2.3

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/general/attribs.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 3f02142..f48d8b9 100644 --- a/tests/general/attribs.c +++

[Piglit] [PATCH 2/3] draw-vertices-2101010: add support for the SNORM equation 2.3

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/arb_vertex_type_2_10_10_10_rev/draw-vertices-2101010.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/spec/arb_vertex_type_2_10_10_10_rev/draw-vertices-2101010.c

[Piglit] [PATCH 3/3] oes_compressed_etc2_texture-miptree: fix the R11 test

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Clearing a buffer with masked channels results in not clearing anything in those channels, so there is always random garbage. No wonder that the test was always failing. Apparently, i965 ignores the colormask, otherwise it wouldn't have been unnoticed. ---

[Piglit] [PATCH] egl-create-context-valid-flag-debug-gles: Add missing break.

2014-08-06 Thread Vinson Lee
Fixes Coverity Missing break in switch defect. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/egl/spec/egl_khr_create_context/valid-flag-debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/egl/spec/egl_khr_create_context/valid-flag-debug.c

Re: [Piglit] [PATCH] egl-create-context-valid-flag-debug-gles: Add missing break.

2014-08-06 Thread Matt Turner
Reviewed-by: Matt Turner matts...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] ext_unpack_subimage: Ensure piglit_probe_pixel_rgba is checked.

2014-08-06 Thread Vinson Lee
Fixes Coverity Unchecked return value defects. Signed-off-by: Vinson Lee v...@freedesktop.org --- .../spec/ext_unpack_subimage/ext_unpack_subimage.c | 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/spec/ext_unpack_subimage/ext_unpack_subimage.c

[Piglit] [PATCH] arb_shader_atomic_counters-unique-id: Fix memory leak.

2014-08-06 Thread Vinson Lee
Fixes Coverity Resource leak defect. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/arb_shader_atomic_counters/unique-id.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_shader_atomic_counters/unique-id.c b/tests/spec/arb_shader_atomic_counters/unique-id.c

[Piglit] [PATCH] glsl-1.50-geometry-tri-strip-ordering-with-prim-restart: Remove dead code.

2014-08-06 Thread Vinson Lee
tests is a static array. Fixes Coverity Array compared against 0 defect. Signed-off-by: Vinson Lee v...@freedesktop.org --- .../glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Piglit] [PATCH] ext_unpack_subimage: Ensure piglit_probe_pixel_rgba is checked.

2014-08-06 Thread Matt Turner
On Wed, Aug 6, 2014 at 5:32 PM, Vinson Lee v...@freedesktop.org wrote: Fixes Coverity Unchecked return value defects. Signed-off-by: Vinson Lee v...@freedesktop.org --- .../spec/ext_unpack_subimage/ext_unpack_subimage.c | 24 +++--- 1 file changed, 12 insertions(+), 12

[Piglit] [PATCH] tex-miplevel-selection: use GL_CLAMP_TO_EDGE instead of GL_REPEAT

2014-08-06 Thread sroland
From: Roland Scheidegger srol...@vmware.com GL_REPEAT is not legal for the rectangle targets, and because the test uses sampler objects the default GL_REPEAT value will be used even for rectangle target because unlike texture objects they can't be initialized to the legal CLAMP_TO_EDGE value.