I'd caught this error in a branch as well, but noticed there were no users
of this function so it didn't seem pressing to fix it.
If you wanted a little less code:
group[name] = PiglitTest(args, run_concurrent=True)
On Wed, Sep 3, 2014 at 4:35 PM, Ilia Mirkin wrote:
> On Wed, Sep 3, 2014 at 7:
On Wed, Sep 3, 2014 at 8:56 PM, Jan Vesely wrote:
> On Wed, 2014-09-03 at 19:33 -0400, Ilia Mirkin wrote:
>> On Wed, Sep 3, 2014 at 7:16 PM, Jan Vesely wrote:
>> > Signed-off-by: Jan Vesely
>> > ---
>> >
>> > There is none reported for quick.py profile, and tons for cl.py
>> >
>> > framework/re
On Wed, 2014-09-03 at 19:33 -0400, Ilia Mirkin wrote:
> On Wed, Sep 3, 2014 at 7:16 PM, Jan Vesely wrote:
> > Signed-off-by: Jan Vesely
> > ---
> >
> > There is none reported for quick.py profile, and tons for cl.py
> >
> > framework/results.py | 8 +---
> > 1 file changed, 5 insertions(+),
Avoid duplicate subtest names
Signed-off-by: Jan Vesely
---
tests/cl/program/execute/v2i32-stack.cl | 17 ++---
tests/cl/program/execute/v3i32-stack.cl | 15 ++-
tests/cl/program/execute/v4i32-stack.cl | 15 ++-
3 files changed, 18 insertions(+), 29 deletions(
Avoid duplicate subtest names
Signed-off-by: Jan Vesely
---
tests/cl/program/execute/i32-stack-array.cl | 125 +++-
1 file changed, 49 insertions(+), 76 deletions(-)
diff --git a/tests/cl/program/execute/i32-stack-array.cl
b/tests/cl/program/execute/i32-stack-array.cl
i
Signed-off-by: Jan Vesely
---
tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++--
tests/cl/program/execute/builtin/atomic/atomic_dec-local.cl | 4 ++--
tests/cl/program/execute/builtin/atomic/atomic_inc-local.cl | 4 ++--
tests/cl/program/execute/builtin/atomic/atomic_sub-local.
These use lte kernels
Also fixes duplicate subtest names
Signed-off-by: Jan Vesely
---
tests/cl/program/execute/scalar-comparison-uchar.cl | 2 +-
tests/cl/program/execute/scalar-comparison-uint.cl | 2 +-
tests/cl/program/execute/scalar-comparison-ulong.cl | 2 +-
tests/cl/program/execute/s
Signed-off-by: Jan Vesely
---
tests/cl/program/execute/scalar-bitwise-int.cl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/cl/program/execute/scalar-bitwise-int.cl
b/tests/cl/program/execute/scalar-bitwise-int.cl
index 1a0668b..e5f836c 100644
--- a/tests/cl/program/ex
On Wed, Sep 3, 2014 at 7:28 PM, Tom Stellard wrote:
> On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote:
>> Signed-off-by: Jan Vesely
>
> Reviewed-by: Tom Stellard
>
>> ---
>>
>> seemed wrong. Wonder if we can use concurrent tests.
>>
>
> If you have render-nodes enabled, then you can r
On Wed, Sep 3, 2014 at 7:16 PM, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
> ---
>
> There is none reported for quick.py profile, and tons for cl.py
>
> framework/results.py | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/framework/results.py b/framework/resul
On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote:
> Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
> ---
>
> seemed wrong. Wonder if we can use concurrent tests.
>
If you have render-nodes enabled, then you can run the cl tests
concurrently by adding the -c flag when running p
Previously, we only ever worked on level 0. Now we work on levels 1 and 3
so that cross-level copying gets tested.
---
tests/spec/arb_copy_image/formats.c | 92 -
1 file changed, 61 insertions(+), 31 deletions(-)
diff --git a/tests/spec/arb_copy_image/formats.
Signed-off-by: Jan Vesely
---
seemed wrong. Wonder if we can use concurrent tests.
tests/cl.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/cl.py b/tests/cl.py
index fd698fc..b59368d 100644
--- a/tests/cl.py
+++ b/tests/cl.py
@@ -21,7 +21,7 @@ def add_plain_test(gro
Signed-off-by: Jan Vesely
---
There is none reported for quick.py profile, and tons for cl.py
framework/results.py | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/framework/results.py b/framework/results.py
index ddadcc1..7d3a375 100644
--- a/framework/results.py
+++
No problem. I assumed that the information wasn't in the
documentation.
On Wednesday, September 03, 2014 03:32:36 PM tiffany wrote:
> Sorry, I've moved it to a proper location. The README and HACKING documents
> didn't give much indication of how and where to make tests, so I picked the
> first sp
Sorry, I've moved it to a proper location. The README and HACKING documents
didn't give much indication of how and where to make tests, so I picked the
first spot I saw that contained glsl shaders.
This test is only a little bit different from the one which was already present
at
tests/spec/glsl/
---
tests/glslparsertest/glsl2/array-index.frag | 19 ---
.../array-index-as-uint-02.frag | 19 +++
2 files changed, 19 insertions(+), 19 deletions(-)
delete mode 100644 tests/glslparsertest/glsl2/array-index.frag
create mode 100644
Hi tiffany,
We're trying not to add more tests to ambiguous locations like glsl2,
the goal is to put tests in locations based on the extension, gl, or
glsl version the test exercises. Looking at the content of your test it
belongs in tests/spec/glsl-1.30/compiler/structure-and-array-operations
We
This test corresponds with commit 7f61ab2f20633443834ff8e832892d5c4cc1c675,
which fixes an assertion in Mesa when indexing an array can cause a failure
under certain circumstances.
---
tests/glslparsertest/glsl2/array-index.frag | 19 +++
1 file changed, 19 insertions(+)
create
On 03/09/14 16:45, Dylan Baker wrote:
> On Wednesday, September 03, 2014 11:42:34 AM Ilia Mirkin wrote:
>> On Wed, Sep 3, 2014 at 11:35 AM, Dylan Baker wrote:
>>> The commit above changed the template to take a single value rather than
>>> nearly a dozen, but the template arguments changed a few o
On Wed, Sep 3, 2014 at 2:45 AM, Ken Phillis Jr wrote:
> I looked over the specifications and see that the following changes should
> suffice...
>
> 1) make a call to piglit_require_GLSL before checking for other extensions.
> 2) check for the GL_ARB_explicit_attrib_location when opengl 3.30 is not
On Wed, Sep 3, 2014 at 11:35 AM, Dylan Baker wrote:
> The commit above changed the template to take a single value rather than
> nearly a dozen, but the template arguments changed a few of the names to
> shorter versions, including environment to env. The template was updated
> incorrectly in the
On Wednesday, September 03, 2014 11:42:34 AM Ilia Mirkin wrote:
> On Wed, Sep 3, 2014 at 11:35 AM, Dylan Baker wrote:
> > The commit above changed the template to take a single value rather than
> > nearly a dozen, but the template arguments changed a few of the names to
> > shorter versions, incl
The commit above changed the template to take a single value rather than
nearly a dozen, but the template arguments changed a few of the names to
shorter versions, including environment to env. The template was updated
incorrectly in the template, and environment has not been printed since
then.
T
No problem, thanks for testing.
On Wednesday, September 03, 2014 01:43:24 PM Emil Velikov wrote:
> On 03/09/14 07:14, Dylan Baker wrote:
> > CC: Emil Velikov
> > Signed-off-by: Dylan Baker
> Works like a charm, thank you :)
>
> Tested-by: Emil Velikov
> > ---
> > framework/summary.py | 2 +-
>
This is a sort of odd bug. The behavior before this patch was that env
was written into the options dictionary in the json, and each pair out
of the env dictionary was written directly into the root of the json
dictionary. Due to a feature that throws out keys that the json isn't
aware of in the ro
On 03/09/14 07:14, Dylan Baker wrote:
> CC: Emil Velikov
> Signed-off-by: Dylan Baker
Works like a charm, thank you :)
Tested-by: Emil Velikov
> ---
> framework/summary.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/summary.py b/framework/summary.py
> in
I looked over the specifications and see that the following changes should
suffice...
1) make a call to piglit_require_GLSL before checking for other extensions.
2) check for the GL_ARB_explicit_attrib_location when opengl 3.30 is not
found.
3) check for GL_ARB_explicit_uniform_location when OpenG
28 matches
Mail list logo
