Re: [Piglit] [RFC] Piglit tags/releases

2014-10-01 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 07:19:35AM -0700, Dylan Baker wrote: And finally on the topic of piglit itself, I think release for piglit-the-testrunner (as opposed to piglit the gl test suite) would make tons of sense. At least it would simplify using piglit for igt, which is still something I

[Piglit] [PATCH] gles2: add linker test for varying that is not written but read

2014-10-01 Thread Tapani Pälli
Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .../gles-2.0/glsl-undefined-varying.shader_test| 24 ++ 1 file changed, 24 insertions(+) create mode 100644 tests/spec/gles-2.0/glsl-undefined-varying.shader_test diff --git

[Piglit] [PATCH] summary: add a csv output option

2014-10-01 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/summary.py | 32 +++- piglit| 4 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/framework/programs/summary.py b/framework/programs/summary.py index

Re: [Piglit] [PATCH v2 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-10-01 Thread Tom Stellard
On Sun, Sep 28, 2014 at 04:30:34PM -0400, Jan Vesely wrote: v2: make the flag a module parameter Pushed, thanks! -Tom Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- This still restricts CPU implementations to run serial on linux machines without render nodes, but I guess those

[Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Emil Velikov
Otherwise we end up leaking the drawable. Spotted by Valgrind Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Perhaps we can simplify the call chain for the following a bit make_current make_current_singlepass special_case31 make_curren_singlepass... But that for another day :P

[Piglit] [PATCH] gles2: add test to render a point without vertex attributes

2014-10-01 Thread Tapani Pälli
Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/spec/gles-2.0/CMakeLists.gles2.txt | 1 + tests/spec/gles-2.0/glsl-no-vertex-attribs.c | 75 2 files changed, 76 insertions(+) create mode 100644 tests/spec/gles-2.0/glsl-no-vertex-attribs.c diff

[Piglit] [PATCH v2] gles2: add test to render a point without vertex attributes

2014-10-01 Thread Tapani Pälli
v2: instead of c, make it a shader_runner_gles2 test Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .../gles-2.0/glsl-no-vertex-attribs.shader_test| 25 ++ 1 file changed, 25 insertions(+) create mode 100644 tests/spec/gles-2.0/glsl-no-vertex-attribs.shader_test

Re: [Piglit] [PATCH 1/2] cl: Add cospi tests

2014-10-01 Thread Tom Stellard
On Mon, Sep 29, 2014 at 10:01:06AM -0500, Aaron Watry wrote: v2: Remove stray ', pi' in Arg0 list Reviewed-by: Tom Stellard thomas.stell...@amd.com CC: Bruno Jiménez brunoji...@gmail.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 10

Re: [Piglit] [PATCH] summary: add a csv output option

2014-10-01 Thread Dylan Baker
I have one style comment, with that fixed: Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Wednesday, October 01, 2014 02:56:10 PM Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/programs/summary.py | 32 +++- piglit

Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Ilia Mirkin
I've applied this patch, and your other patch, and can confirm that things are a *lot* better. There appears to be a leak from stuff done by _mesa_glsl_initialize_builtin_functions -- investigating whether that's a mesa thing or piglit still not shutting things down. These are Tested-by: Ilia

Re: [Piglit] [PATCH] util/wfl: unbound the current context before destroying its window

2014-10-01 Thread Dylan Baker
Should the subject say 'unbind' rather than 'unbound'? On Wednesday, October 01, 2014 02:01:57 AM Emil Velikov wrote: Otherwise we end up leaking the drawable. Spotted by Valgrind Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Perhaps we can simplify the call chain for the

Re: [Piglit] Atomic Writes for piglit backends

2014-10-01 Thread Dylan Baker
I'm gonna push these tomorrow unless someone objects. On Tuesday, September 23, 2014 05:55:47 PM Dylan Baker wrote: For a long time piglit has had a considerable problem with resuming interrupted runs. This problem comes from the recovery tool, a very fragile piece of code that relies on the