Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v3)

2014-12-12 Thread Dylan Baker
On Saturday, December 13, 2014 12:53:42 AM Mason, Michael W wrote: > A couple questions... > > First, deqp-gles3 has many command line options. Is there any way in piglit > to pass them to deqp-gles3 from the piglit command line? I don't see a way. > One option in particular is important whe

Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v3)

2014-12-12 Thread Matt Turner
On Fri, Dec 12, 2014 at 4:53 PM, Mason, Michael W wrote: > Second, how do you kill a piglit test run once it's started? I tried > multiple ctrl-C's without success. I couldn't get it to stop. Is this a > piglit limitation or something to do with the piglit/deqp combo? CTRL+\

Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v3)

2014-12-12 Thread Mason, Michael W
A couple questions... First, deqp-gles3 has many command line options. Is there any way in piglit to pass them to deqp-gles3 from the piglit command line? I don't see a way. One option in particular is important when testing on Freon. I have to pass "--deqp-gl-config-name=rgbad24s8" to

Re: [Piglit] [Patch v2] generated_tests: Catch exception in os.makedirs

2014-12-12 Thread Mark Janes
Thanks, this is a superior implementation imho. -Mark Dylan Baker writes: > + > +def safe_makedirs(dirs): > +"""A safe function for creating a directory tree. > + > +This function wraps os.makedirs, and provides a couple of sanity checks, > +first, if the directory already exists it

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
On Fri, 2014-12-12 at 14:49 -0800, Matt Turner wrote: > On Fri, Dec 12, 2014 at 2:13 PM, Jan Vesely wrote: > > On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: > >> On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > >> > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: > >> >> I'm cur

Re: [Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-12 Thread Vinson Lee
On Fri, Dec 12, 2014 at 9:47 AM, Jan Vesely wrote: > v2: protect the include with guards > > Signed-off-by: Jan Vesely > --- > tests/spec/arb_timer_query/timestamp-get.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/spec/arb_timer_query/timestamp-get.c > b/tests/spec/arb_tim

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Matt Turner
On Fri, Dec 12, 2014 at 2:13 PM, Jan Vesely wrote: > On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: >> On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: >> > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: >> >> I'm curious what the motivation for removing variably-sized arrays is,

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: > On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: > >> I'm curious what the motivation for removing variably-sized arrays is, > >> but if I accept that that's a good thing to do then

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Dylan Baker
It's impossible for them to be built on MSVC, they're guarded in cmake by LBIDRM_FOUND On Friday, December 12, 2014 01:37:09 PM Matt Turner wrote: > On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: > >> I'm curious what the motivation f

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Matt Turner
On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely wrote: > On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: >> I'm curious what the motivation for removing variably-sized arrays is, >> but if I accept that that's a good thing to do then the first patch >> makes sense, but I don't understand this on

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote: > I'm curious what the motivation for removing variably-sized arrays is, > but if I accept that that's a good thing to do then the first patch > makes sense, but I don't understand this one. > > How is a variably-size array different from using

[Piglit] [PATCH 1/2] CL: refactor genclbuiltins.py to allow TSS functions with different arg types

2014-12-12 Thread Aaron Watry
Before, if you had a function that had 2-3 args, it was assumed that all arguments were of the same base type. Now, that assumption is removed and we used the argument type defined in the test profile. This will be useful in the next commit, where ldexp(floatN,int) is introduced. This patch upda

[Piglit] [PATCH 2/2] CL: Add ldexp tests

2014-12-12 Thread Aaron Watry
Signed-off-by: Aaron Watry --- generated_tests/generate-cl-math-builtins.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 7e475f2..490c0b8 100644 --- a/generated_tests/generat

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Matt Turner
I'm curious what the motivation for removing variably-sized arrays is, but if I accept that that's a good thing to do then the first patch makes sense, but I don't understand this one. How is a variably-size array different from using alloca()? ___ Pigli

[Piglit] [PATCH 1/3] cl: Don't use variable length array

2014-12-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/cl/program/program-tester.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index d6dbc55..3905679 100644 --- a/tests/cl/program/program-tester.c +++ b/tests/cl/p

[Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

2014-12-12 Thread Jan Vesely
Fixes Target links to itself cmake warnings Signed-off-by: Jan Vesely --- compile tested. no missing symbols or libraries reported for libpiglitutils_glesX.so tests/util/CMakeLists.gles1.txt | 1 - tests/util/CMakeLists.gles2.txt | 1 - tests/util/CMakeLists.gles3.txt | 1 - 3 files changed,

[Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2014-12-12 Thread Jan Vesely
Signed-off-by: Jan Vesely --- tests/spec/ext_image_dma_buf_import/intel_external_sampler_only.c | 2 +- tests/spec/ext_image_dma_buf_import/intel_unsupported_format.c| 2 +- tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 2 +- tests/spec/ext_image_dma_buf_import/invalid_h

[Piglit] [Patch v2] generated_tests: Catch exception in os.makedirs

2014-12-12 Thread Dylan Baker
Currently we check for the existence of a directory, and if it doesn't exist we create it. This would be fine, except that multiple generators can create the same directory trees and when os.makedirs tries to create a tree that already exists it raises and OSError exception, with the errno set to 1

[Piglit] [PATCH v2 3/5] arb_timer_query: Add missing header

2014-12-12 Thread Jan Vesely
v2: protect the include with guards Signed-off-by: Jan Vesely --- tests/spec/arb_timer_query/timestamp-get.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/arb_timer_query/timestamp-get.c b/tests/spec/arb_timer_query/timestamp-get.c index 031c7a1..bcfc3f9 100644 --- a/tests/s

Re: [Piglit] [PATCH] generated_tests: Except error for os.makedirs

2014-12-12 Thread Mark Janes
Thanks for making this fix. Dylan Baker writes: > -os.makedirs(dirname) > +try: > +os.makedirs(dirname) > +except OSError as e: > +if e.errno == 17: # file exists > +pass > +raise This works

[Piglit] [PATCH 1/2] remove generate-glean-tests.py

2014-12-12 Thread Dylan Baker
This python module was used to generate a test list for glean. It really isn't needed for a couple of reasons: 1) Its been broken for a long time 2) Glean tests are basically only being removed at this point 3) What it generates isn't the same format as piglit uses today Signed-off-by: Dylan Baker

[Piglit] [PATCH 2/2] remove framework/threads.py

2014-12-12 Thread Dylan Baker
This file hasn't been used for quite some time, at least since the atomic backend work landed. Signed-off-by: Dylan Baker --- framework/threads.py | 43 --- 1 file changed, 43 deletions(-) delete mode 100644 framework/threads.py diff --git a/framework/th

Re: [Piglit] [PATCH 01/10] grouptools.py: Add a module specifically for working with group strings

2014-12-12 Thread Dylan Baker
On Friday, December 12, 2014 05:13:43 PM Jose Fonseca wrote: > On 12/12/14 17:01, Dylan Baker wrote: > > On Friday, December 12, 2014 11:50:25 AM Jose Fonseca wrote: > >> On 05/12/14 19:24, Dylan Baker wrote: > >>> On Friday, December 05, 2014 11:55:41 AM Jose Fonseca wrote: > On 04/12/14 23:0

Re: [Piglit] [PATCH 01/10] grouptools.py: Add a module specifically for working with group strings

2014-12-12 Thread Jose Fonseca
On 12/12/14 17:01, Dylan Baker wrote: On Friday, December 12, 2014 11:50:25 AM Jose Fonseca wrote: On 05/12/14 19:24, Dylan Baker wrote: On Friday, December 05, 2014 11:55:41 AM Jose Fonseca wrote: On 04/12/14 23:09, Dylan Baker wrote: This module is largely just posixpath (sometimes the func

Re: [Piglit] [PATCH 01/10] grouptools.py: Add a module specifically for working with group strings

2014-12-12 Thread Dylan Baker
On Friday, December 12, 2014 11:50:25 AM Jose Fonseca wrote: > On 05/12/14 19:24, Dylan Baker wrote: > > On Friday, December 05, 2014 11:55:41 AM Jose Fonseca wrote: > >> On 04/12/14 23:09, Dylan Baker wrote: > >>> This module is largely just posixpath (sometimes the functions are > >>> renamed), w

[Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

2014-12-12 Thread Andres Gomez
Exposes a bug in the i965 driver. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82991 --- tests/shaders/glsl-deriv-varyings.c | 131 +++- 1 file changed, 130 insertions(+), 1 deletion(-) diff --git a/tests/shaders/glsl-deriv-varyings.c b/tests/shaders/gl

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

2014-12-12 Thread Jose Fonseca
On 23/11/14 15:09, Emil Velikov wrote: On 23/11/14 09:38, Jose Fonseca wrote: On 21/11/14 19:52, Emil Velikov wrote: [snip] --- /dev/null +++ b/tests/util/piglit-framework-gl/piglit_wgl_framework.c [snip] +static void +enter_event_loop(struct piglit_winsys_framework *winsys_fw) +{ + +/*

Re: [Piglit] [PATCH 01/10] grouptools.py: Add a module specifically for working with group strings

2014-12-12 Thread Jose Fonseca
On 05/12/14 19:24, Dylan Baker wrote: On Friday, December 05, 2014 11:55:41 AM Jose Fonseca wrote: On 04/12/14 23:09, Dylan Baker wrote: This module is largely just posixpath (sometimes the functions are renamed), with a couple of unique functions, which are basically wrappers around posixpath