Re: [Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

2015-03-11 Thread Ilia Mirkin
On Wed, Mar 11, 2015 at 9:59 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Mar 11, 2015 at 3:56 AM, Iago Toral Quiroga ito...@igalia.com wrote: The textureProj tests multiply expected texture coordinates by the projector in advance so that when the driver does the division we obtain the

[Piglit] [PATCH] ext_framebuffer_multisample/samples: check all samples values

2015-03-11 Thread Marc-André Lureau
Actually check all samples values, and not just the maximum. --- tests/spec/ext_framebuffer_multisample/samples.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/ext_framebuffer_multisample/samples.c b/tests/spec/ext_framebuffer_multisample/samples.c index

[Piglit] [PATCH] glsl-1.10: Add test for bug in i965 gl_FrontFacing optimization

2015-03-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com These patterns gl_FrontFacing ? -1.0 : 1.0 gl_FrontFacing ? 1.0 : -1.0 gl_FrontFacing ? 0.0 : -1.0 are recognized and optimized by the i965 driver. However, it incorrectly optimizes int x = gl_FrontFacing ? 1 : -1; as int x

Re: [Piglit] [PATCH] glsl-1.10: Add test for bug in i965 gl_FrontFacing optimization

2015-03-11 Thread Ian Romanick
On 03/11/2015 02:32 PM, Emil Velikov wrote: On 11 March 2015 at 21:19, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com These patterns gl_FrontFacing ? -1.0 : 1.0 gl_FrontFacing ? 1.0 : -1.0 gl_FrontFacing ? 0.0 : -1.0 are recognized and

Re: [Piglit] [PATCH] glsl-1.10: Add test for bug in i965 gl_FrontFacing optimization

2015-03-11 Thread Emil Velikov
On 11 March 2015 at 21:19, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com These patterns gl_FrontFacing ? -1.0 : 1.0 gl_FrontFacing ? 1.0 : -1.0 gl_FrontFacing ? 0.0 : -1.0 are recognized and optimized by the i965 driver. However, it

Re: [Piglit] [PATCH] grouptools.py: Silently ignore mixed os.path.join usage on Windows too.

2015-03-11 Thread Jose Fonseca
Thanks Dylan. Yeah, this is meant mostly as short term stop gap. Feel free to revert this when you have a better solution. '|' sounds alright. Another alternative would be to use a non-printable character (something nobody ever consider using in a test name) -- then replace it with '/' a

Re: [Piglit] [PATCH] grouptools.py: Silently ignore mixed os.path.join usage on Windows too.

2015-03-11 Thread Dylan Baker
On Wed, Mar 11, 2015 at 08:19:42PM +, Jose Fonseca wrote: Thanks Dylan. Yeah, this is meant mostly as short term stop gap. Feel free to revert this when you have a better solution. '|' sounds alright. Another alternative would be to use a non-printable character (something nobody

Re: [Piglit] [PATCH] grouptools.py: Silently ignore mixed os.path.join usage on Windows too.

2015-03-11 Thread Dylan Baker
Also sent a reply to this from the wrong account, I think the best solution is to replace '/' with some other character. Maybe '|'? I'll work on patches for a different separator, in the mean time: Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Wed, Mar 11, 2015 at 11:24:36AM +, Jose

Re: [Piglit] [PATCH] tests/all: Use grouptools.join for glx_ext_import_context.

2015-03-11 Thread Dylan Baker
I sent you a reply from the wrong account, and it wont show up on list. for posterity: Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Wed, Mar 11, 2015 at 11:06:43AM +, Jose Fonseca wrote: This fixes the following assertion on Windows: AssertionError: Groups are not paths and

[Piglit] [PATCH v3] oglconform.py: Fix PEP 8 issues.

2015-03-11 Thread Vinson Lee
Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/oglconform.py | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tests/oglconform.py b/tests/oglconform.py index 436247c..f2e161e 100644 --- a/tests/oglconform.py +++ b/tests/oglconform.py @@ -39,14

[Piglit] [PATCH v2] registry/gl.py: Fix PEP 8 issues.

2015-03-11 Thread Vinson Lee
Signed-off-by: Vinson Lee v...@freedesktop.org --- registry/gl.py | 170 ++--- 1 file changed, 103 insertions(+), 67 deletions(-) diff --git a/registry/gl.py b/registry/gl.py index ff89189..54d7e51 100644 --- a/registry/gl.py +++

[Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

2015-03-11 Thread Iago Toral Quiroga
The textureProj tests multiply expected texture coordinates by the projector in advance so that when the driver does the division we obtain the same coordinates. However, the division can lead to small rounding errors that can affect the selected layer and fail the tests. This is currently

[Piglit] [PATCH] tests/all: Use grouptools.join for glx_ext_import_context.

2015-03-11 Thread Jose Fonseca
This fixes the following assertion on Windows: AssertionError: Groups are not paths and cannot contain \. (glx\glx_ext_import_context) I believe the current implementation of grouptools is unsustainable: it fails to spot when people mistakedly use os.path.join on unices, yet aborts when it

[Piglit] [PATCH] grouptools.py: Silently ignore mixed os.path.join usage on Windows too.

2015-03-11 Thread Jose Fonseca
grouptools currently acts like a time-bomb: spite the good intention, it currently ignores when developers mistakedly use os.path.join with grouptools on Posix; then it explodes when the same code is used on Windows. This makes grouptools behavior on Windows the same as Linux, ie., silently

Re: [Piglit] [PATCH v2] spec/arb_blend_func_extended: Add test for SIMD16 dual source blending

2015-03-11 Thread Iago Toral
Thanks for reviewing Matt, I'll do all these changes before pushing. Iago On Tue, 2015-03-10 at 18:18 -0700, Matt Turner wrote: On Thu, Mar 5, 2015 at 11:49 PM, Iago Toral Quiroga ito...@igalia.com wrote: On Intel hardware at least, SIMD16 dual source rendering requires handling pixel data

[Piglit] [PATCH] all.py: Fix PEP 8 issues.

2015-03-11 Thread Vinson Lee
Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/all.py | 98 1 file changed, 65 insertions(+), 33 deletions(-) diff --git a/tests/all.py b/tests/all.py index 1c3c889..e491cae 100644 --- a/tests/all.py +++ b/tests/all.py @@

Re: [Piglit] [PATCH v2 1/2] shaders: add test to check (0 cmp x+y) optimization

2015-03-11 Thread Samuel Iglesias Gonsálvez
On Tue, 2015-03-10 at 18:23 -0700, Matt Turner wrote: On Sun, Mar 1, 2015 at 11:31 PM, Samuel Iglesias Gonsalvez sigles...@igalia.com wrote: Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- v2: * Implement it as shader_runner test

Re: [Piglit] [PATCH] tex-miplevel-selection: Fix textureProj failures due to precision errors

2015-03-11 Thread Ilia Mirkin
On Wed, Mar 11, 2015 at 3:56 AM, Iago Toral Quiroga ito...@igalia.com wrote: The textureProj tests multiply expected texture coordinates by the projector in advance so that when the driver does the division we obtain the same coordinates. However, the division can lead to small rounding errors