[Piglit] [PATCH] V3. Add a case to valid gl_VertexID for bug 87611

2015-03-23 Thread Wang Shuo
V3: This case is passed by master. Below is the test point of this case: 1. Use user-allocated vertex arrays (NOT vertex buffer objects). 2. Use a glDrawArrays with a non-zero 'first'. 3. Use primitive restart to trigger multiple _mesa_prim without an intervening state change. For primitive

[Piglit] [Bug 89740] Create a New Account for piglit - Shuo Wang

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89740 --- Comment #1 from shuo.w...@intel.com --- Created attachment 114573 --> https://bugs.freedesktop.org/attachment.cgi?id=114573&action=edit ssh rsa key -- You are receiving this mail because: You are the QA Contact for the bug. You are the ass

[Piglit] [Bug 89740] New: Create a New Account for piglit - Shuo Wang

2015-03-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89740 Bug ID: 89740 Summary: Create a New Account for piglit - Shuo Wang Product: piglit Version: unspecified Hardware: Other OS: All Status: NEW Severity: norm

[Piglit] [PATCH] Adjust draw-pixel-with-texture to ensure glTexCoord is taken into account.

2015-03-23 Thread Matthew Dawson
The old version of the test assumed the glTexCoord call was being properly used in the system. However, at least in mesa, it is easy for an implementation to ignore the given coordinate. Thus setup the texture and texture coordinate to ensure it is respected. Also call glWindowPos2i, to ensure t

Re: [Piglit] [PATCH] framework; Catch "No results found" exception

2015-03-23 Thread Brian Paul
Reviewed-by: Brian Paul On 03/23/2015 04:22 PM, Dylan Baker wrote: This adds a couple of catches for results not found and cleanly exits without a traceback when this is an expected error condition. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 12 ++-- framework/r

Re: [Piglit] [PATCH] summary: Add an aggregate function

2015-03-23 Thread Brian Paul
LGTM. Thanks. Reviewed-by: Brian Paul On 03/23/2015 04:14 PM, Dylan Baker wrote: This summarizer can be used to aggregate a set of individual tests together into a single results file. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 41 +

[Piglit] [PATCH] framework; Catch "No results found" exception

2015-03-23 Thread Dylan Baker
This adds a couple of catches for results not found and cleanly exits without a traceback when this is an expected error condition. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 12 ++-- framework/results.py | 7 ++- framework/summary.py | 6 +

[Piglit] [PATCH] summary: Add an aggregate function

2015-03-23 Thread Dylan Baker
This summarizer can be used to aggregate a set of individual tests together into a single results file. Signed-off-by: Dylan Baker --- framework/programs/summary.py | 41 ++--- piglit| 4 2 files changed, 42 insertions(+), 3 delet

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
On 03/23/2015 03:38 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 03:24:21PM -0600, Brian Paul wrote: On 03/23/2015 03:07 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: Hmm, can you give me a concrete example of how to do this? I have an aborted run and te

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Dylan Baker
On Mon, Mar 23, 2015 at 03:24:21PM -0600, Brian Paul wrote: > On 03/23/2015 03:07 PM, Dylan Baker wrote: > > On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: > >> Hmm, can you give me a concrete example of how to do this? > >> > >> I have an aborted run and tests/ contains several thousa

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
On 03/23/2015 03:07 PM, Dylan Baker wrote: On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: Hmm, can you give me a concrete example of how to do this? I have an aborted run and tests/ contains several thousand NNN.json files. What "piglit summary console" command should I use to gen

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Dylan Baker
On Mon, Mar 23, 2015 at 02:57:07PM -0600, Brian Paul wrote: > Hmm, can you give me a concrete example of how to do this? > > I have an aborted run and tests/ contains several thousand NNN.json > files. What "piglit summary console" command should I use to generate > the json file? I've tried a

Re: [Piglit] recovering from aborted runs

2015-03-23 Thread Brian Paul
Hmm, can you give me a concrete example of how to do this? I have an aborted run and tests/ contains several thousand NNN.json files. What "piglit summary console" command should I use to generate the json file? I've tried a few things without luck. BTW, the piglit.py script always dumps co

[Piglit] [PATCH 5/4] glsl-1.10: Test bool-to-float-cast of equal of an expression

2015-03-23 Thread Ian Romanick
From: Ian Romanick These match the notEqual tests of the previous commit. These tests currently pass on the i965 driver, but one of my ideas for fixing the notEqual case broken the equal case. Signed-off-by: Ian Romanick --- .../execution/fs-equal-of-expression.shader_test | 35

[Piglit] [PATCH 3/4] glsl-1.10: Rename tests to follow -- pattern

2015-03-23 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Dylan Baker --- .../execution/fs-inline-notequal.shader_test | 27 - .../fs-notEqual-inline-function.shader_test| 27 + .../execution/vs-inline-notequal.shader_test | 28 -

[Piglit] [PATCH 2/4] glsl-1.20: Move notEqual tests from shaders to spec/glsl-1.20

2015-03-23 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Dylan Baker --- .../shaders/glsl-const-builtin-notEqual-bool.shader_test | 16 tests/shaders/glsl-const-builtin-notEqual.shader_test| 16 .../fs-notEqual-const-of-const-bvec3.shader_test | 16 +

[Piglit] [PATCH 4/4] glsl-1.10: Test bool-to-float-cast of notEqual of an expression

2015-03-23 Thread Ian Romanick
From: Ian Romanick The fragment shader test reproduces a recently added bug in the i965 driver on GEN4 and GEN5 platforms. The optimization tries to be clever when comparison is with a constant value of zero. However, the generated comparison was inverted, so everything went wrong. Signed-off-

[Piglit] [PATCH 1/4] glsl-1.20: Use [vertex shader passthrough] in notEqual tests

2015-03-23 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- tests/shaders/glsl-const-builtin-notEqual-bool.shader_test | 6 +- tests/shaders/glsl-const-builtin-notEqual.shader_test | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/tests/shaders/glsl-const-builtin-notEq

Re: [Piglit] [PATCH] glsl-1.20: test intrastage linking with const arrays

2015-03-23 Thread Chris Forbes
Looks like the right thing. Reviewed-by: Chris Forbes On Mon, Mar 23, 2015 at 8:50 PM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > .../linker/intrastage-const-arrays.shader_test | 22 > ++ > 1 file changed, 22 insertions(+) > create mode 100644 > tests

[Piglit] [PATCH 2/2] deqp_gles3.py: use grouptools separator for test separators

2015-03-23 Thread Dylan Baker
This is an oversight in the previous set of patches. Signed-off-by: Dylan Baker --- tests/deqp_gles3.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py index 409273b..97f9fb1 100644 --- a/tests/deqp_gles3.py +++ b/tests/deqp_gle

[Piglit] [PATCH 1/2] es3conform.py: Use grouptools instead of os.path

2015-03-23 Thread Dylan Baker
This probably would have been fine before since most (all?) users of es3conform.py used Linux. However, since the separator has changed this has stopped working, so grouptools is now required. Signed-off-by: Dylan Baker --- tests/es3conform.py | 9 + 1 file changed, 5 insertions(+), 4 de

Re: [Piglit] [PATCH 7/7] grouptools.py: assert if \\ or / is in a group

2015-03-23 Thread Dylan Baker
You're right, I'll send a patch for that because I overlooked it. Unfortunately grepping for '/' is a rather tedious process. On Sat, Mar 21, 2015 at 04:52:23PM +, Emil Velikov wrote: > On 21/03/15 16:04, Emil Velikov wrote: > > On 16 March 2015 at 23:13, Dylan Baker wrote: > >> So, I did a f

Re: [Piglit] [PATCH] Adjust draw-pixel-with-texture to ensure glTexCoord is taken into account.

2015-03-23 Thread Brian Paul
On 03/21/2015 11:49 PM, Matthew Dawson wrote: The old version of the test assumed the glTexCoord call was being properly used in the system. However, at least in mesa, it is easy for an implementation to ignore the given coordinate. Thus setup the texture and texture coordinate to ensure it is

Re: [Piglit] [PATCH] fs-discard-exit-2: Fix Clang absolute-value warnings.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:46 AM, Vinson Lee wrote: fs-discard-exit-2.c:118:13: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value] int dx = fabs(sx - x / 8); ^ fs-discard-exit-2.c:118:1

Re: [Piglit] [PATCH] select: Fix Clang absolute-value warnings.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:50 AM, Vinson Lee wrote: select.c:126:10: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] diffz = abs(hit1[MIN_Z] - hit2[MIN_Z])/zscale; ^ select.c:126:10: note: remove the call to 'abs' since unsigned

Re: [Piglit] [PATCH] ext_packed_depth_stencil: Fix Clang absolute-value warning.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:48 AM, Vinson Lee wrote: readpixels-24_8.c:62:6: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] abs((value >> 8) - (expected >> 8)) > 1) { ^ readpixels-24_8.c:62:6: note: remove the call to 'abs' sinc

Re: [Piglit] [PATCH] glsl-1.50-geometry-primitive-id-restart: Add NORETURN attribute to print_usage_and_exit.

2015-03-23 Thread Brian Paul
On 03/22/2015 01:17 AM, Vinson Lee wrote: Fix uninitialized scalar variable defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/glsl-1.50/execution/geometry/primitive-id-restart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/glsl-1.50/execu

Re: [Piglit] [PATCH] arb_pipeline_statistics_query-comp: Fix out-of-bounds reads.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:55 AM, Vinson Lee wrote: Fix out-of-bounds read defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/arb_pipeline_statistics_query/pipeline_stats_comp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/arb_pipeline_statist

Re: [Piglit] [PATCH] arb_direct_state_access: Remove unused variables.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:52 AM, Vinson Lee wrote: Fix Clang unused-const-variable warnings. gettransformfeedback.c:84:22: warning: unused variable 'out1_ret' [-Wunused-const-variable] static const GLfloat out1_ret[NUM_INPUTS] = { 0.0, 1.0, 2.0, 4.0}; ^ gettransformfeedback.c:85:22

Re: [Piglit] [PATCH] arb_direct_state_access: Ignore scanf return value.

2015-03-23 Thread Brian Paul
On 03/22/2015 12:57 AM, Vinson Lee wrote: Silence unchecked return value from library defect reported by Coverity. Signed-off-by: Vinson Lee --- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_d

Re: [Piglit] [PATCH] samplers: add a test that has a sampler array inside of a struct

2015-03-23 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 03/23/2015 12:20 PM, Ilia Mirkin wrote: Based on in-parameter-struct-array. Signed-off-by: Ilia Mirkin --- .../samplers/in-parameter-struct-array.shader_test | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 tests/spec/glsl-1.1

[Piglit] [PATCH] samplers: add a test that has a sampler array inside of a struct

2015-03-23 Thread Ilia Mirkin
Based on in-parameter-struct-array. Signed-off-by: Ilia Mirkin --- .../samplers/in-parameter-struct-array.shader_test | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/samplers/in-parameter-struct-array.shader_test diff --git a/te

[Piglit] [PATCH] glsl-1.20: test intrastage linking with const arrays

2015-03-23 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- .../linker/intrastage-const-arrays.shader_test | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 tests/spec/glsl-1.20/linker/intrastage-const-arrays.shader_test diff --git a/tests/spec/glsl-1.20/linker/intrastage-const-arrays.s