Keep the existing results file name if the results input was a file
rather than a directory.
Signed-off-by: Thomas Wood
---
framework/backends/json.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/framework/backends/json.py b/framework/backends/json.py
index affd
Hi Tapani
On 20/04/15 08:16, Tapani Pälli wrote:
> All other tests except invalid_enum_check pass on Nvidia
> binary driver (version 346.35).
>
> Signed-off-by: Tapani Pälli
> ---
> tests/all.py | 1 +
> .../CMakeLists.gl.txt
On 04/17/2015 04:16 PM, Jose Fonseca wrote:
The previous unhandled exception filter had two problems:
- Vectored exceptions filter are too big of a hammer for this, as they
intercept any exception on any thread, regardless they have a regular
handler that will catch them or not. Whereas w
Piglit no loger work for me with commit
e4b46dc198a6482d34280748022afd0e29729eaa
./piglit run cl results/cl_compat
Error: A test has already been asigned the name:
program@execute@builtin@builtin-float-mix-1.0.generated
Further, the two tests are not the same,
The original test has this command:
On Tue, 2015-04-21 at 16:47 +0200, EdB wrote:
> Piglit no loger work for me with commit
> e4b46dc198a6482d34280748022afd0e29729eaa
you need to clean and rebuild generated tests.
jan
>
> ./piglit run cl results/cl_compat
> Error: A test has already been asigned the name:
> program@execute@bui
How do I do ?
I make clean and even git clean -ifx and still got the error.
I see not rule to clean generated test, but I may have miss it.
On Tuesday 21 April 2015 10:58:59 Jan Vesely wrote:
> On Tue, 2015-04-21 at 16:47 +0200, EdB wrote:
> > Piglit no loger work for me with commit
> > e4b46dc19
On Tue, 2015-04-21 at 17:18 +0200, EdB wrote:
> How do I do ?
>
> I make clean and even git clean -ifx and still got the error.
> I see not rule to clean generated test, but I may have miss it.
yeah, for some reason tests in generated_tests/cl/builtin are not
cleaned up by either of those. Haven'
I think you're trying to handle a case that can't (or maybe shouldn't)
happen.
_update_results is a helper called only by load_results, which always
passes in a filename, so I think that in every case you'd end up hitting
the isfile path. In fact, I've added an 'assert
os.path.isfile(filepath)' an
Le 2015-04-21 17:27, Jan Vesely a écrit :
On Tue, 2015-04-21 at 17:18 +0200, EdB wrote:
How do I do ?
I make clean and even git clean -ifx and still got the error.
I see not rule to clean generated test, but I may have miss it.
yeah, for some reason tests in generated_tests/cl/builtin are not
On Tue, Apr 21, 2015 at 11:06:16AM -0700, Dylan Baker wrote:
> I think you're trying to handle a case that can't (or maybe shouldn't)
> happen.
>
> _update_results is a helper called only by load_results, which always
> passes in a filename, so I think that in every case you'd end up hitting
> the
This makes use PiglitConfig.required_get for getting required
information, and uses PiglitFatalError rather than exiting on certain
errors.
Signed-off-by: Dylan Baker
---
framework/tests/integration_tests.py | 7 +++
tests/xts.py | 9 +++--
2 files changed, 6 inse
This removes the need for passing and allows us to set the result in one
place instead of multiple places, it also means that Mixins like the
WindowResizeMixin don't need to handle errors from the base version, if
there is an exception, it will go until it's caught in Test.run()
Signed-off-by: Dyl
This is the basis of providing clean, unified exception handling to
piglit, this provides a set of Exception classes and a function
decorator to be used on main functions. Together these provide well
formatted error messages that differentiate between expected failures
and unexpected failures and p
This series moves to introduce a standard set of exceptions for Piglit
to use, and a standard handler for them that operates on each entry
point.
This removes boilerplate from our code by allowing it to be pulled into
methods, making it easier to work with, and provides better error
messages when
This uses the new exceptions and new PiglitConfig methods.
Signed-off-by: Dylan Baker
---
I have not been able to test this patch
framework/tests/integration_tests.py | 7 ++-
tests/oglconform.py | 9 -
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git
This allows us to encapsulate a lot of the error handling logic into a
single place with easy to use methods. This should reduce the amount of
code in consumers of PIGLIT_CONFIG.
It adds two new methods, safe_get and required_get, which operate on
NoOptionError or NoSectionError. With safe_get, if
This makes working with skips a little bit cleaner for a couple of
reasons. First, there is no need to return the super() call. Second, it
provides us a way to pass information up the call chain to Test.run(),
so that we can provide a reason for the skip.
This also adds some tests for glean, since
This removes a bunch of except boilerplate code.
Signed-off-by: Dylan Baker
---
tests/deqp_gles3.py | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py
index c55eb66..0ed6a61 100644
--- a/tests/deqp_gles3.py
+++ b/tests/deqp_gles3.
Don't raise Exception.
Signed-off-by: Dylan Baker
---
framework/backends/junit.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/framework/backends/junit.py b/framework/backends/junit.py
index 3602f9e..9971165 100644
--- a/framework/backends/junit.py
+++ b/framework/back
Signed-off-by: Dylan Baker
---
framework/programs/summary.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/framework/programs/summary.py b/framework/programs/summary.py
index 76ff6cc..afbbcf3 100644
--- a/framework/programs/summary.py
+++ b/framework/programs/summary.py
This makes use of PiglitConfig.required_get for getting information from
PIGLIT_CONFIG.
It also uses piglit exceptions extensively to raise errors, rather than
printing and exiting. This has the added benefit of printing errors to
stderr instead of stdout.
Signed-off-by: Dylan Baker
---
Unfortu
Use piglit exceptions for aborting and erroring rather than custom
classes.
Signed-off-by: Dylan Baker
---
framework/test/glsl_parser_test.py| 29
framework/tests/glsl_parser_test_tests.py | 107 ++
2 files changed, 47 insertions(+), 89 deletions(-)
Largely this just replaces a local exception with a generic one.
Signed-off-by: Dylan Bake
---
framework/test/shader_test.py| 22 ++
framework/tests/shader_test_tests.py | 3 ++-
2 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/framework/test/shader_t
This makes all of the integrated tests use the new exceptions code,
which simplifies testing and makes error messages nicer.
Signed-off-by: Dylan Baker
---
I cannot test this patch
framework/tests/integration_tests.py | 11 ---
tests/es3conform.py | 6 +++---
2 files
This patch largely replaces an existing TestDictError class with a
generic exeption for exceptions.
It also simplifies some error handles in the load_test_profile function.
Signed-off-by: Dylan Baker
---
framework/profile.py | 33 -
framework/tests/pr
This allows more exceptions to be caught at the top level exception
handling, requiring fewer try/except blocks in the middle of the code
that exit. This should make the code a little easier to read.
Signed-off-by: Dylan Baker
---
framework/backends/errors.py | 25 -
fra
Use an exception rather than passing booleans. This removes a bunch of
biolerplate code and makes things easier.
Signed-off-by: Dylan Baker
---
framework/programs/run.py | 15 ++-
framework/tests/run_parser_tests.py | 14 +++---
2 files changed, 13 insertions(+), 16
I forgot to mention, you can get this at my github:
This is available at my github:
https://github.com/dcbaker/piglit submit/unified-exceptions
signature.asc
Description: Digital signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lis
From: Dave Airlie
This passes on NVIDIA 346.47.
Signed-off-by: Dave Airlie
---
tests/spec/arb_copy_image/formats.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/spec/arb_copy_image/formats.c
b/tests/spec/arb_copy_image/formats.c
index aa9b4d3..787194b 100644
--- a/tests/spec/a
Reviewed-by: Ilia Mirkin
On Tue, Apr 21, 2015 at 9:59 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This passes on NVIDIA 346.47.
>
> Signed-off-by: Dave Airlie
> ---
> tests/spec/arb_copy_image/formats.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/spec/arb_copy_image/
On 04/21/2015 05:08 PM, Emil Velikov wrote:
Hi Tapani
On 20/04/15 08:16, Tapani Pälli wrote:
All other tests except invalid_enum_check pass on Nvidia
binary driver (version 346.35).
Signed-off-by: Tapani Pälli
---
tests/all.py | 1 +
.../CMakeLists
All other tests except invalid_enum_check pass on Nvidia
binary driver (version 346.35), tests also pass currently on
upcoming Mesa implementation.
v2:
- make test use Core context (for DSA), change test
concurrent (Ilia Mirkin)
- code cleanup, use ARRAY_SIZE (Emil Velikov)
- fix DSA
32 matches
Mail list logo
