[Piglit] [PATCH] framework tests: fix binary_check utility bug

2015-08-03 Thread Dylan Baker
This patch changes binary_check to work when a binary is present, but doesn't work for some reason. The example here is in the json content tests, where it looks for glxinfo, but if X isn't running glxinfo provides no output, which will cause a test to fail. This isn't useful, so instead of using

[Piglit] [PATCH 1/2] glsl_parser_test_tests.py: make tests more robust

2015-08-03 Thread Dylan Baker
Rather than loading a file out of the tree (which might be moved, deleted, etc.) create a temporary file and load that. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/tests/glsl_parser_test_tests.py | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

[Piglit] [PATCH 2/2] glsl_parser_test_tests.py: Add tests to glslparsertest_gles2 checking.

2015-08-03 Thread Dylan Baker
These add a few tests that check the glslparser_gles2 detection, we already have tests for glslparsertest. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/tests/glsl_parser_test_tests.py | 27 +++ 1 file changed, 27 insertions(+) diff --git

[Piglit] [PATCH 2/2] framework/test: split Valgrind code into a Mixin

2015-08-03 Thread Dylan Baker
This code is pretty self contained and specific, by making a mixin we allow it to be added to additional Test classes, and provides isolation of the logic. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/test/base.py| 64 +++-

[Piglit] [PATCH 1/2] framework/test/base.py: Move some logic from Test.run to Test.interpret_result

2015-08-03 Thread Dylan Baker
This refactors the Test.run() method, making it simpler, and moving result interpretation logic into the more natural interpret_result() method. This is purely a refactor, and doesn't change the code at all. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/test/base.py

[Piglit] [PATCH 1/2] framework/programs/run.py: Delete tests directory if it exists

2015-08-03 Thread Dylan Baker
This prevents piglit from aggregating tests from a previous run into the new run by deleting the old tests directory before starting. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- framework/programs/run.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[Piglit] [PATCH 2/2] framework: remove last use of core.checkDir

2015-08-03 Thread Dylan Baker
This function has two problems: 1) It desperately needs to be refactored to make better use of the except block. 3) It needs to be refactored to raise a PiglitFatalException. 2) It's far too specific to be in core, it really should be refactored to raise a PiglitInternalError when

[Piglit] [PATCH v5] cl: add clEnqueue-read_write BufferRect releated tests

2015-08-03 Thread Meng Mengmeng
It's a simple function test for clEnqueueReadBufferRect and clEnqueueWriteBufferRect. --- tests/cl.py | 2 + tests/cl/api/CMakeLists.cl.txt| 1 + tests/cl/api/enqueue-read_write-buffer-rect.c | 338 ++ 3 files changed,

Re: [Piglit] [PATCH v4] cl: add clEnqueue-read_write BufferRect releated tests

2015-08-03 Thread Meng, Mengmeng
Oh, it's my negligence. I need to resend out a final edition. I'm very grateful for your careful and repeated reviewing. Thanks, Meng -Original Message- From: EdB [mailto:edb+pig...@sigluy.net] Sent: Thursday, July 30, 2015 7:42 PM To: piglit@lists.freedesktop.org Cc: Meng, Mengmeng

[Piglit] [PATCH] framework: remove _test_run_hook from Test

2015-08-03 Thread Dylan Baker
This was a design mistake from the start, subclassing the Test class and overriding the run() method achieves the same result, without the need for this hook Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- This hook was only used in unit tests, so the only affect should be to make

Re: [Piglit] [PATCH 3/3] arb_arrays_of_arrays: add simple fs atomic counter execution test

2015-08-03 Thread Timothy Arceri
On Sun, 2015-08-02 at 10:25 -0400, Ilia Mirkin wrote: On Sun, Aug 2, 2015 at 8:04 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- .../fs-simple-inc-dec-read.shader_test | 109 + 1 file changed, 109 insertions(+) create mode 100644

Re: [Piglit] [PATCH 1/3] arb_arrays_of_arrays: add some atomic counter indirect indexing tests

2015-08-03 Thread Timothy Arceri
On Sun, 2015-08-02 at 10:22 -0400, Ilia Mirkin wrote: On Sun, Aug 2, 2015 at 8:04 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- .../atomic_counters/fs-indirect-index.shader_test | 72 +++ .../atomic_counters/vs-indirect-index.shader_test | 82

Re: [Piglit] [PATCH 1/2] ext_transform_feedback: Fix default precision qualifiers

2015-08-03 Thread Iago Toral
Hi Timothy, On Mon, 2015-08-03 at 18:39 +1000, Timothy Arceri wrote: On Mon, 2015-08-03 at 08:47 +0200, Iago Toral wrote: If no body has issues with these two patches I'd like to push them later this week. Iago On Tue, 2015-07-28 at 13:52 +0200, Iago Toral Quiroga wrote:

Re: [Piglit] [PATCH 1/2] ext_transform_feedback: Fix default precision qualifiers

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 08:47 +0200, Iago Toral wrote: If no body has issues with these two patches I'd like to push them later this week. Iago On Tue, 2015-07-28 at 13:52 +0200, Iago Toral Quiroga wrote: Default ES precision qualifiers for integer types in the VS and FS are different

Re: [Piglit] [PATCH 1/2] ext_transform_feedback: Fix default precision qualifiers

2015-08-03 Thread Iago Toral
If no body has issues with these two patches I'd like to push them later this week. Iago On Tue, 2015-07-28 at 13:52 +0200, Iago Toral Quiroga wrote: Default ES precision qualifiers for integer types in the VS and FS are different and that should make the test fail to compile/link if Mesa

Re: [Piglit] [PATCH 3/3] arb_arrays_of_arrays: add simple fs atomic counter execution test

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 19:10 +1000, Timothy Arceri wrote: On Sun, 2015-08-02 at 10:25 -0400, Ilia Mirkin wrote: On Sun, Aug 2, 2015 at 8:04 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- .../fs-simple-inc-dec-read.shader_test | 109 + 1 file

[Piglit] [PATCH 1/2] occlusion_query_meta_no_fragments: check more potential meta operations

2015-08-03 Thread Brian Paul
Scissored or masked clears might be done with a meta operation that draws a quad. Now check for those cases too. These cases plus some of the original ones all fail with gallium. --- .../occlusion_query_meta_no_fragments.c| 41 -- 1 file changed, 39

[Piglit] [PATCH 2/2] occlusion_query_meta_save: also test scissored clear

2015-08-03 Thread Brian Paul
Plain glClear is seldom a meta operation, but scissored clears are implemented by drawing a quad in gallium. Now the test tries both to check that glClear doesn't effect the occlusion query count. --- .../occlusion_query_meta_save.c| 29 ++ 1 file changed,

Re: [Piglit] [PATCH] xz: Use --help when detecting xz presence

2015-08-03 Thread Dylan Baker
On Sun, Aug 02, 2015 at 12:32:29PM -0700, Jordan Justen wrote: On 2015-08-02 09:57:00, Dylan Baker wrote: On Aug 2, 2015 00:45, Jordan Justen jordan.l.jus...@intel.com wrote: If xz is present, and the piglit command's output is redirected, then xz will think its output is