Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

Hello IIia, Thank you for the corrections. I will make these changes and submit. Regards, Juliet On Tue, Sep 1, 2015 at 11:17 PM, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 5:49 PM, Juliet Fru wrote: > > --- > > tests/all.py

[Piglit] [RFC] general: add draw-sync to all.py

The draw-sync test (from 2011) in the tests/general directory was never placed in all.py. Signed-off-by: Albert Freeman --- quick.py finishes with draw-sync passing This is an RFC since I placed the test in "!opengl 1.5" (since similar looking tests were there).

Re: [Piglit] [PATCH 8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

Ah, okay, that makes sense, I'll drop this patch On Wed, Sep 02, 2015 at 09:27:16PM +0100, Jose Fonseca wrote: > On 02/09/15 20:51, Dylan Baker wrote: > > This was never added to all.py > > Yes, that was because the test uses random numbers, hence might yield > variable results (fail once, pass

Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

> > Hello Emil, > > > Afaics adding PIGLIT_GL_VISUAL_DEPTH and PIGLIT_GL_VISUAL_STENCIL to > the config.window_visual should suffice. Never had the pleasure of > using them, but things ought to just work. > > I have added, I will be sending in the patch shortly. I just have some issues with

Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

On 2 September 2015 at 23:17, Juliet Fru wrote: > Hello Emil, > >> > +enum piglit_result >> > +piglit_display(void) >> > +{ >> > + bool pass = true; >> > + enum path p, paths[10]; >> > + int i, num_paths = 0; >> > + >> > + static const float white[3] =

[Piglit] [PATCH] Porting basic rendering GL tests from Glean to Piglit

--- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/no-op-paths.c | 304 3 files changed, 306 insertions(+) create mode 100644 tests/spec/gl-1.0/no-op-paths.c diff --git a/tests/all.py

Re: [Piglit] [PATCH] glsl-1.10: test for rotating a variable components in a loop

On 09/01/2015 06:31 PM, Ilia Mirkin wrote: > On Tue, Sep 1, 2015 at 9:02 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> This test fails on r600 with sb enabled, it does something >> similiar to what a lot of the CTS test cases do. >> >> Signed-off-by:

Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

Hi Juliet, On 1 September 2015 at 22:49, Juliet Fru wrote: > +enum piglit_result > +piglit_display(void) > +{ > + bool pass = true; > + enum path p, paths[10]; > + int i, num_paths = 0; > + > + static const float white[3] = {1.0, 1.0, 1.0}; > + > +

Re: [Piglit] [PATCH 8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

On 02/09/15 20:51, Dylan Baker wrote: This was never added to all.py Yes, that was because the test uses random numbers, hence might yield variable results (fail once, pass another). Rather than all.py, it probably makes sense to move this sort of tests to a new stress.py test-list. The

Re: [Piglit] [PATCH 9/9] tests/all: add fbo-mrt-new-bind

On Wednesday, September 02, 2015 12:51:24 PM Dylan Baker wrote: > This was never added to all.py > > cc: Mike Stroyan > cc: Kenneth Graunke > Signed-off-by: Dylan Baker > --- > tests/all.py | 1 + > 1 file changed, 1

[Piglit] [PATCH 4/9] tests/all.py: add arb_copy_image-api_errors

This was never added to all.py, and was detected by my check.py script. This fails on i965 against mesa master cc: Jason Ekstrand Signed-off-by: Dylan Baker --- tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py

[Piglit] [PATCH 0/9] Add missing tests to all.py

After seeing that recent patch for adding draw-sync to all.py I wondered what else might be missing, so I wrote a little script to find out. It returned a few missing tests, and I've added them in this series. Dylan Baker (9): check.py: a small utility for checking missing tests.

[Piglit] [PATCH 2/9] tests/all.py: add missing test fcc-front-buffer-distraction

This test was never added to all.py, and was detected by my check.py script. This fails on i965 against mesa master cc: Paul Berry Signed-off-by: Dylan Baker --- I'm assuming since this tests front/back buffer interactions this cannot be run

[Piglit] [PATCH 1/9] check.py: a small utility for checking missing tests.

I've included this so other can see what I was doing, I don't think it really needs to be committed, but it could be if people wanted. Though, it probably needs some cleanup before merge. --- check.py | 87 1 file changed, 87

[Piglit] [PATCH 9/9] tests/all: add fbo-mrt-new-bind

This was never added to all.py cc: Mike Stroyan cc: Kenneth Graunke Signed-off-by: Dylan Baker --- tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py index ca72b65..5211ff8 100644 ---

[Piglit] [PATCH 3/9] tests/all.py: add arb_gpu_shader_fp64-double_in_bool_uniform

This test was never added to all.py, and was detected by my check.py script. cc: Dave Airlie Signed-off-by: Dylan Baker --- tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py index df31849..e09261e 100644

[Piglit] [PATCH 5/9] tests/all.py: fix ext_texture_array-compressed

I did this wrong when I converted the format of all.py Signed-off-by: Dylan Baker --- tests/all.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index 0e22d5d..b4be071 100644 --- a/tests/all.py +++ b/tests/all.py @@

[Piglit] [PATCH 8/9] tests/all.py: add arb_robustness_draw-vbo-bounds

This was never added to all.py cc: José Fonseca Signed-off-by: Dylan Baker --- Does this actually need run_concurrent=False? tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py index 9c55dd7..ca72b65

[Piglit] [PATCH 6/9] tests.all: add arb_framebuffer_srgb-pushpop

This was never added to all.py. cc: Eric Anholt Signed-off-by: Dylan Baker --- Can this be run concurrently, or should it have run_concurrent=False added? tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py

[Piglit] [PATCH 7/9] tests/all.py: add arb_texture_buffer_object-render-no-bo

This was never added to all.py cc: Eric Anholt Signed-off-by: Dylan Baker --- tests/all.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/all.py b/tests/all.py index 86b93ed..9c55dd7 100644 --- a/tests/all.py +++ b/tests/all.py @@ -2377,6

[Piglit] [PATCH 1/7] framework/tests/utils.py: Make the TestFailure exception message better

This adds a better error message to TestFailure, which is raised by most of the helpers in the utils module if a Test fails. Signed-off-by: Dylan Baker --- framework/tests/utils.py | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff

[Piglit] [PATCH 4/7] framework/grouptools: fix join to handle empty elements correctly

Currently join doesn't handle empty values correctly, as it will add an extra {SEPARATOR} for each of them. Passing in this value: ['', 'foo', 'bar', ''] will result in this: '@foo@bar@' This obviously isn't what we want, we really want 'foo@bar', and this patch corrects the behavior to do that.

Re: [Piglit] [PATCH] arb_copy_image: fix a few error check tests

On 09/01/2015 02:56 PM, Brian Paul wrote: > Some of the error checks were incorrect before. Per the spec: > > 1. GL_TEXTURE_BUFFER and GL_TEXTURE_CUBE_MAP_+/-_XYZ are not legal targets > and should be flagged as invalid enums. > > 2. GL_INVALID_OPERATION should be generated when trying to copy

[Piglit] [PATCH 7/7] framework/status.py: Add early return to status_lookup

It's rediculously expensive to send a Status through the status_lookup factory, it's much cheaper to return early, and doesn't really affect non Status lookups. Signed-off-by: Dylan Baker --- framework/status.py | 5 + 1 file changed, 5 insertions(+) diff --git

[Piglit] [PATCH 5/7] framework/status.py: Make StatusException a child of PiglitInternalError

This change makes makes it simpler to handle this error than being a descendant of LookupError. The biggest advantage is that the __str__ method provides a good error message. This will be used in a later patch in this series. Signed-off-by: Dylan Baker ---

[Piglit] framework: small cleanups, enhancements, and fixes

These patches are pulled out of a much larger series of work. They're small, obvious, and self contained fixes, cleanups, or enhancements for the framework. ___ Piglit mailing list Piglit@lists.freedesktop.org

[Piglit] [PATCH 3/7] framework/grouptools: fix commonprefix with empty value

--- framework/grouptools.py | 2 ++ framework/tests/grouptools_tests.py | 8 2 files changed, 10 insertions(+) diff --git a/framework/grouptools.py b/framework/grouptools.py index 81e6091..d6749d6 100644 --- a/framework/grouptools.py +++ b/framework/grouptools.py @@ -81,6

[Piglit] [PATCH 2/7] framework/tests: remove old group separator strings

There were still a couple of '/' delemited strings floating around in the tests. use grouptools.join to avoid this being a problem. Signed-off-by: Dylan Baker --- framework/tests/junit_backends_tests.py | 34 + 1 file changed, 18

[Piglit] [PATCH 6/7] framework/status.py: rename 'Not Run' to 'notrun'

This matches the behavior of the other statuses. It looks odd, and it makes it hard to convert back from a string, since internally 'notrun' is used as the string representation. Signed-off-by: Dylan Baker --- framework/status.py | 2 +- 1 file changed, 1 insertion(+),

Re: [Piglit] [PATCH] Porting basic GL rendering tests to piglit

Hello Emil, > +enum piglit_result > > +piglit_display(void) > > +{ > > + bool pass = true; > > + enum path p, paths[10]; > > + int i, num_paths = 0; > > + > > + static const float white[3] = {1.0, 1.0, 1.0}; > > + > > + /* draw 10x10 pixel quads */ > > +

Re: [Piglit] [RFC] general: add draw-sync to all.py

On 09/02/2015 11:45 AM, Albert Freeman wrote: The draw-sync test (from 2011) in the tests/general directory was never placed in all.py. Signed-off-by: Albert Freeman --- quick.py finishes with draw-sync passing This is an RFC since I placed the test in "!opengl 1.5"