[Piglit] [PATCH 2/2] arb_copy_image-formats: add code to test GL_DEPTH32F_STENCIL8

2015-09-14 Thread Brian Paul
This internal depth/stencil format was added in GL 3.0 We need to handle a few things specially for this format: 1. The random float data must be in the range [0,1]. 2. When we compare pixels, we must skip the 3 unused bytes in the pixel. This patch also simplifies the array indexing code in check

[Piglit] [PATCH 1/2] arb_copy_image-formats: exit loops upon pixel mismatch

2015-09-14 Thread Brian Paul
Instead of printing potentially a thousand error messages when there's a failure. Also, some minor code reformatting. v2: remove passrate code too, per Anuj. --- tests/spec/arb_copy_image/formats.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tests/spec/a

Re: [Piglit] [PATCH v7] Port basic GL rendering test from Glean to Piglit

2015-09-14 Thread Brian Paul
On 09/13/2015 11:20 AM, Juliet Fru wrote: Hello Brian, Could you please give the sample array for testing the black colour? You just need to declare black like this: static const float black[3] = { 0.0, 0.0, 0.0 }; then test for that color in the probe function. -Brian Regards, Juliet On

Re: [Piglit] [PATCH v2 3/4] Add miptree tests for khr_texture_compression_astc

2015-09-14 Thread Nanley Chery
On Wed, Sep 9, 2015 at 5:04 PM, Chad Versace wrote: > On Fri 28 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > These tests run through every ASTC configuration, comparing the > > render of a compressed texture against a render of the decompressed > > version of that compressed text

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

2015-09-14 Thread Nanley Chery
On Mon, Sep 14, 2015 at 3:23 PM, Nanley Chery wrote: > > > On Tue, Sep 8, 2015 at 11:45 AM, Chad Versace > wrote: > >> On Fri 28 Aug 2015, Nanley Chery wrote: >> > From: Nanley Chery >> > >> > These tests check that the GL error returned by valid and invalid API >> calls >> > are as defined by

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

2015-09-14 Thread Nanley Chery
On Tue, Sep 8, 2015 at 11:45 AM, Chad Versace wrote: > On Fri 28 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery > > > > These tests check that the GL error returned by valid and invalid API > calls > > are as defined by the spec. > > > > Signed-off-by: Nanley Chery > > --- > > .../khr_te

Re: [Piglit] [PATCH 1/4] arb_texture_view: alphabetize program list

2015-09-14 Thread Anuj Phogat
On Fri, Sep 11, 2015 at 3:50 PM, Brian Paul wrote: > --- > tests/spec/arb_texture_view/CMakeLists.gl.txt | 28 > +-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/tests/spec/arb_texture_view/CMakeLists.gl.txt > b/tests/spec/arb_texture_view/CMakeLis

Re: [Piglit] [PATCH 3/4] arb_copy_image-formats: exit loops upon pixel mismatch

2015-09-14 Thread Anuj Phogat
On Fri, Sep 11, 2015 at 3:50 PM, Brian Paul wrote: > Instead of printing potentially a thousand error messages when > there's a failure. > > Also, some minor code reformatting. > --- > tests/spec/arb_copy_image/formats.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff -

[Piglit] [PATCH] texelFetch: Fix the divisors when testing MSAA with > 10 samples

2015-09-14 Thread Neil Roberts
Previously the test was trying to convert a sample number to the range [0,1] by dividing by 10.0. This doesn't work when testing 16x MSAA because it ends up with values greater than 1.0 which get clamped. This patch makes it divide by miplevels so that it will work whatever the number of samples is

Re: [Piglit] [PATCH] sso: fix issues in ValidateProgramPipeline

2015-09-14 Thread Tapani Pälli
On 09/14/2015 12:18 PM, Tapani Pälli wrote: On 09/14/2015 11:39 AM, Ilia Mirkin wrote: On Mon, Sep 14, 2015 at 4:34 AM, Tapani Pälli wrote: When fixing some ES 3.1 conformance issues I noticed several subtests started to fail. Patch fixes 2 issues in the test: - pipeline has to be bound f

[Piglit] [PATCH] sso: bind pipeline object in ValidateProgramPipeline

2015-09-14 Thread Tapani Pälli
When fixing some ES 3.1 conformance issues I noticed several subtests started to fail. Pipeline has to be bound before validation, this makes failing subtests to pass with planned Mesa changes. Signed-off-by: Tapani Pälli --- tests/spec/arb_separate_shader_objects/ValidateProgramPipeline.c | 1 +

Re: [Piglit] [PATCH] sso: fix issues in ValidateProgramPipeline

2015-09-14 Thread Tapani Pälli
On 09/14/2015 11:39 AM, Ilia Mirkin wrote: On Mon, Sep 14, 2015 at 4:34 AM, Tapani Pälli wrote: When fixing some ES 3.1 conformance issues I noticed several subtests started to fail. Patch fixes 2 issues in the test: - pipeline has to be bound for validation to return expected results - vali

Re: [Piglit] [PATCH] sso: fix issues in ValidateProgramPipeline

2015-09-14 Thread Ilia Mirkin
On Mon, Sep 14, 2015 at 4:34 AM, Tapani Pälli wrote: > When fixing some ES 3.1 conformance issues I noticed several subtests > started to fail. Patch fixes 2 issues in the test: > > - pipeline has to be bound for validation to return expected results > - validate_pipe needs to set global value 'pa

[Piglit] [PATCH] sso: fix issues in ValidateProgramPipeline

2015-09-14 Thread Tapani Pälli
When fixing some ES 3.1 conformance issues I noticed several subtests started to fail. Patch fixes 2 issues in the test: - pipeline has to be bound for validation to return expected results - validate_pipe needs to set global value 'pass' to true when validation passes. This makes subtests to p