Re: [Piglit] cleanups to tesselation generators

On Wed, Oct 07, 2015 at 02:17:01PM -0700, Dylan Baker wrote: > This series began it's life as an attempt to get the tessalation > generators running in python 3.x. > > And then I noticed how much code was duplicated between the two > generators, and spend 20 patches cleaning up style issues,

Re: [Piglit] [PATCH v1] Porting the OpenGL shading language from Glean to Piglit.

Hi Juliet, I only have time for a quick review for now. See comments below. I'll try to look closer tomorrow. On 10/07/2015 02:48 AM, Juliet Fru wrote: This test replaces the original tglsl1.cpp test --- tests/all.py|1 + tests/spec/gl-1.0/CMakeLists.gl.txt

[Piglit] [PATCH 2/9] gen_tess_input_tests.py: use modules.utils.safe_makedirs

This if much like os.makedirs, but catches extra errors to handle corner cases. Signed-off-by: Dylan Baker --- generated_tests/gen_tess_input_tests.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/generated_tests/gen_tess_input_tests.py

[Piglit] [PATCH 1/9] generated_tests: combine gen_{tcs, tes}_input_tests

These two generators share a lot of boilerplate, and all of the interesting logic is contained in the Test class. A little simple renaming and the generators can be combined, reducing the amount of boilerplate needed. Signed-off-by: Dylan Baker ---

[Piglit] [PATCH 3/9] gen_tess_input_tests.py: add missing docstring

Signed-off-by: Dylan Baker --- generated_tests/gen_tess_input_tests.py | 1 + 1 file changed, 1 insertion(+) diff --git a/generated_tests/gen_tess_input_tests.py b/generated_tests/gen_tess_input_tests.py index e0c2ac6..3149471 100644 ---

[Piglit] cleanups to tesselation generators

This series began it's life as an attempt to get the tessalation generators running in python 3.x. And then I noticed how much code was duplicated between the two generators, and spend 20 patches cleaning up style issues, removing semi-colons, remove unused imprts, sorting imports, using

[Piglit] [RFC 15/25] gen_tcs_input_tests.py: use textwrap.dedent

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 191 + 1 file changed, 96 insertions(+), 95 deletions(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index

[Piglit] [RFC 13/25] gen_tcs_input_tests.py: fix whitespace errors

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index c705844..5d2b4a5

[Piglit] [RFC 09/25] gen_tcs_input_tests.py: remove unnecessary semicolons

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index 763c128..a2f7ae3 100644 ---

[Piglit] [RFC 07/25] gen_tes_input_tests.py: use texwrap.dedent

This increases the readability of the file by allowing the long test string to be indented. Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 189 + 1 file changed, 95 insertions(+), 94 deletions(-) diff --git

[Piglit] [RFC 06/25] gen_tes_input_tests.py: use six.moves.range

This maintains python 2.x and 3.x compatibility, while still using an efficient iterator function (unlike range in python 2.x which returns a list) Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 12 +++- 1 file changed, 7 insertions(+),

Re: [Piglit] [PATCH] glsl-es: Verify restrictions on global variable initializers

Reviewed-by: Mark Janes Tested-by: Mark Janes Ian Romanick writes: > From: Ian Romanick > > Section 4.3 (Storage Qualifiers) of the OpenGL ES 1.00.17 spec says: > > "Declarations of globals

[Piglit] [RFC 01/25] gen_tes_input_Tests.py: use a proper docstring

This is just syntactic sugar. Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/generated_tests/gen_tes_input_tests.py

[Piglit] [RFC 16/25] gen_tcs_input_tests.py: replace unused variable with _

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index 535074a..01e938c 100644 ---

[Piglit] [RFC 08/25] gen_tes_input_tests.py: replace unused variable with _

Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generated_tests/gen_tes_input_tests.py b/generated_tests/gen_tes_input_tests.py index a0a0fdb..d443f7f 100644 ---

[Piglit] [RFC 05/25] gen_tes_input_tests.py: cleanup whitespace issues

these are mostly bad hanging indents or oddly placed spaces Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/generated_tests/gen_tes_input_tests.py

[Piglit] [RFC 10/25] gen_tcs_input_tests.py: replace tabs with spaces

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index

[Piglit] [RFC 02/25] gen_tes_input_tests.py: remove unnecissary ; at end of python lines

python allows these, but they're not necessary and not normal Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_tes_input_tests.py

[Piglit] [RFC 03/25] gen_tes_input_tests.py: replace tabs with spaces

This breaks python 3 compatibility Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/generated_tests/gen_tes_input_tests.py

[Piglit] [RFC 11/25] gen_tcs_input_tests.py: Use a proper docstring

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index 883c5cc..ac56905

[Piglit] [RFC 04/25] gen_tes_input_tests.py: Cleanup imports

one import per line per PEP8, and use the __future__ imports to enforce python 2.x and python 3.x compatibility. Signed-off-by: Dylan Baker --- generated_tests/gen_tes_input_tests.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Piglit] [RFC 12/25] gen_tcs_input_tests.py: fix imports

Signed-off-by: Dylan Baker --- generated_tests/gen_tcs_input_tests.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/generated_tests/gen_tcs_input_tests.py b/generated_tests/gen_tcs_input_tests.py index ac56905..c705844 100644 ---

[Piglit] [PATCH 4/6] generated_tests/gen_tess_input_tests.py: simplify some of the logic

This produces the same result, but it's much clearer what's happening. --- generated_tests/gen_tess_input_tests.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/generated_tests/gen_tess_input_tests.py b/generated_tests/gen_tess_input_tests.py index f4c50e6..4950976

[Piglit] [PATCH 6/6] generated_tests/gen_tess_input_tests.py: Reduce code duplication

This uses a couple of mixin classes to reduce code duplication. It splits the identical 'generate' functions out into a mixin, as well as the 'components' and 'test_data' methods into a second mixin. It then makes filename a lazy_property, to make even less code. The result is the removal of

[Piglit] [PATCH 1/6] gen_tess_input_tests.py: Use mako to generate tests

This gives us a cached template, speeding up regenerating these tests, which is especially helpful in a CI system like Jenkins. Signed-off-by: Dylan Baker --- generated_tests/CMakeLists.txt | 5 +- generated_tests/gen_tess_input_tests.py

[Piglit] [PATCH 2/6] gen_tess_input_tests.py: move some formatting logic into the templates

This logic was purely used for making content to appear in the generated files. It is both simpler and less code if it put in the template. Signed-off-by: Dylan Baker --- generated_tests/gen_tess_input_tests.py| 44 ++

[Piglit] [PATCH 3/6] gen_tess_input_tests.py: use numpy for random data

Python 2.x and python 3.x produce different results. This is probably a difference between the implementations. This result is largely the same in order of magnitude differences, but the numbers themselves are sometimes significantly different. This might be due to the difference between python 2

[Piglit] [PATCH 5/6] generated_tests/gen_tess_input_tests.py: homogenize {Tes, Tcs}Test

This is going to allow for code sharing, which will simpliyf things --- generated_tests/gen_tess_input_tests.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_tess_input_tests.py b/generated_tests/gen_tess_input_tests.py index 4950976..f96c725

[Piglit] [PATCH v1] Porting the OpenGL shading language from Glean to Piglit.

This test replaces the original tglsl1.cpp test --- tests/all.py|1 + tests/spec/gl-1.0/CMakeLists.gl.txt |1 + tests/spec/gl-1.0/shading-lang.c| 1939 +++ 3 files changed, 1941 insertions(+) create mode 100644

Re: [Piglit] [PATCH] arb_program_interface_query: rever linker test for querying varyings

Reviewed-by: Juha-Pekka Heikkila On 07.10.2015 09:34, Tapani Pälli wrote: This reverts commit e68f387df54767c177fcbf9e2f0b44a98525eb2a. This test is wrong. Varyings as GL_PROGRAM_INPUT should be in the resource list only when using SSO, not in case of full

[Piglit] [PATCH] arb_program_interface_query: rever linker test for querying varyings

This reverts commit e68f387df54767c177fcbf9e2f0b44a98525eb2a. This test is wrong. Varyings as GL_PROGRAM_INPUT should be in the resource list only when using SSO, not in case of full shader programs with multiple stages. I will write a separate test for that case. ---

[Piglit] [PATCH 1/2] glsl-es: Additional constant initializer tests.

From: Ian Romanick Most built-in functions with constant-expression parameters are also constant expressions. GLSL ES 1.00 and 3.00 differ as to whether or not the sequence operator is a constant expression. Note:

[Piglit] [PATCH 2/2] glsl-es: Verify rules about constant expressions w.r.t. sizing arrays

From: Ian Romanick NOTE: Without patches recently posted to the mesa-dev mailing list, Mesa fails spec/glsl-es-3.00/compiler/array-sized-by-sequence.*. Signed-off-by: Ian Romanick --- .../array-sized-by-sequence-in-parenthesis.vert | 17

Re: [Piglit] [PATCH v1] Porting the OpenGL shading language from Glean to Piglit.

On Wed, Oct 7, 2015 at 1:48 AM, Juliet Fru wrote: > This test replaces the original tglsl1.cpp test > --- > tests/all.py|1 + > tests/spec/gl-1.0/CMakeLists.gl.txt |1 + > tests/spec/gl-1.0/shading-lang.c| 1939 >

Re: [Piglit] [PATCH v1] Removed the two sided stencil extension Glean test.

On 10/06/2015 11:05 PM, Juliet Fru wrote: Hi Brian, I am currently porting the tglsl1.cpp Glean test to Piglit. I will be sending in the patch soon. Note that most of the things tested by tglsl1.cpp are already tested by other piglit shader tests. We should take a look at each test case and

Re: [Piglit] [PATCH v1] Removed the two sided stencil extension Glean test.

On 10/07/2015 08:48 AM, Brian Paul wrote: On 10/06/2015 11:05 PM, Juliet Fru wrote: Hi Brian, I am currently porting the tglsl1.cpp Glean test to Piglit. I will be sending in the patch soon. Note that most of the things tested by tglsl1.cpp are already tested by other piglit shader tests.

Re: [Piglit] [PATCH] arb_direct_state_access/create-textures: also check invalid zero target

On Oct 5, 2015 10:23 AM, "Brian Paul" wrote: > > Check that glCreateTextures rejects target=0, per the spec. Also, Mesa > internally uses target=0 for a special state (texture gen'd but not bound) > so it's good to test. > --- >

Re: [Piglit] [PATCH v2] clipflat: Fix subtest reporting

On Tue, Oct 06, 2015 at 05:13:03PM -0600, Brian Paul wrote: > Looks great. > Reviewed-by: Brian Paul > Thanks Brian. signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] oes_compressed_paletted_texture: fix BindTexture() parameter

On Oct 5, 2015 4:23 PM, "Nanley Chery" wrote: > > From: Nanley Chery > > The second parameter to glBindTexture should accept a texture > handle, not the address of one. > > Cc: Ian Romanick > Signed-off-by: Nanley Chery