Re: [Piglit] [PATCH 2/2] arb_shader_stencil_export: Compare all values

On 23 October 2015 at 06:00, Ben Widawsky wrote: > @@ -57,13 +57,15 @@ piglit_display(void) > > piglit_draw_rect(-1, -1, 2, 2); > > - glReadPixels(0, 0, 3, 1, GL_STENCIL_INDEX, GL_FLOAT, p); > + glReadPixels(0, 0, 256, 256, GL_STENCIL_INDEX,

Re: [Piglit] [PATCH 1/2] arb_shader_stencil_export: move to standard location

Hi Ben, Please feed these through -M so that git can detect the code movement. Otherwise people start running away :P But seriously, just a small comment below. On 23 October 2015 at 06:00, Ben Widawsky wrote: > --- /dev/null > +++

Re: [Piglit] [PATCH 1/2] arb_shader_stencil_export: move to standard location

On Tue, Nov 10, 2015 at 04:37:09PM +, Emil Velikov wrote: > Hi Ben, > > Please feed these through -M so that git can detect the code movement. > Otherwise people start running away :P What does -M do? I am not seeing such a flag in any of the relevant git subcommands (add, rm, commit, mv). I

Re: [Piglit] [PATCH 1/2] arb_shader_stencil_export: move to standard location

On Tue, Nov 10, 2015 at 09:16:06AM -0800, Ben Widawsky wrote: > On Tue, Nov 10, 2015 at 04:37:09PM +, Emil Velikov wrote: > > Hi Ben, > > > > Please feed these through -M so that git can detect the code movement. > > Otherwise people start running away :P > > What does -M do? I am not seeing

Re: [Piglit] [PATCH 1/2] arb_shader_stencil_export: move to standard location

On 10 November 2015 at 17:16, Ben Widawsky wrote: > On Tue, Nov 10, 2015 at 04:37:09PM +, Emil Velikov wrote: >> Hi Ben, >> >> Please feed these through -M so that git can detect the code movement. >> Otherwise people start running away :P > > What does -M do? I

Re: [Piglit] [PATCH] generated_tests/builtin_function.py: hide RuntimeWarnings

On Fri, Nov 6, 2015 at 12:35 PM, wrote: > From: Dylan Baker > > These warnings are expected, it's better to hide expected warnings and > provide a comment about them being expected than to have them clutter > the output of the build system. > >

Re: [Piglit] [PATCH] generated_tests/builtin_function.py: hide RuntimeWarnings

On Tue, Nov 10, 2015 at 12:37:31PM -0800, Vinson Lee wrote: > On Fri, Nov 6, 2015 at 12:35 PM, wrote: > > From: Dylan Baker > > > > These warnings are expected, it's better to hide expected warnings and > > provide a comment about them being

[Piglit] Patchwork

Hi ladies and gents, I've just finished (mostly) cleaning up patchwork, removing tests that have been superseded, rejected, sent to the wrong list, etc. We now have four pages of patches for review that are outstanding, some as far back as 2013, and some for features we have no tests for

Re: [Piglit] [PATCH 0/5] Randomized UBO tests of doom

That's a full step ahead of my suggestion. I just want the thing in a shared place so that I can run it when doing dodgy things to code I don't understand... if there's some automated process running it, that's just gravy on top. On Tue, Nov 10, 2015 at 1:26 AM, Dylan Baker

[Piglit] [PATCH] Implement piglit tests for EXT_blend_func_extended

--- tests/all.py | 13 +++ .../api/CMakeLists.gles2.txt | 5 + .../api/CMakeLists.gles3.txt | 6 ++ .../api/bindfragdataindexed-invalid-parameters.c | 8 ++

Re: [Piglit] [PATCH] framework: resmove es3conform support

On 11 November 2015 at 08:52, Eric Anholt wrote: > baker.dyla...@gmail.com writes: > >> From: Dylan Baker >> >> This is the old Khronos suite, which has been superseded by CTS. Since >> piglit can wrap cts it seems rather silly to have both CTS and >>

Re: [Piglit] [PATCH] generated_tests/builtin_function.py: hide RuntimeWarnings

On Tue, 2015-11-10 at 13:44 -0800, Dylan Baker wrote: > On Tue, Nov 10, 2015 at 12:37:31PM -0800, Vinson Lee wrote: > > On Fri, Nov 6, 2015 at 12:35 PM, wrote: > > > From: Dylan Baker > > > > > > These warnings are expected, it's better to hide

[Piglit] [PATCH 2/6] shader_runner: Don't call glDeleteProgram on an ARB program.

I don't feel good about this check, but it is done elsewhere in the same file ("prog == 0"). --- tests/shaders/shader_runner.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 4597b46..bb17381 100644

[Piglit] [PATCH 3/6] arb_vertex_program: Remove unnecessary fragment programs.

These just performed actions the fixed-function processing would have done. Removing them allows these tests to execute on hardware that supports ARB_vertex_program but not ARB_fragment_program (like R200). --- tests/spec/arb_vertex_program/arl.shader_test | 6 --

[Piglit] [PATCH 1/6] shader_runner: Check feature support before querying GL_MAX_*.

Otherwise, these will generate an error (to be noticed sometime later when glGetError() is called), often resulting in a test failure. --- tests/shaders/shader_runner.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/shaders/shader_runner.c

[Piglit] [PATCH 5/6] util: Remove now unused piglit_ARBfp_pass_through.

--- tests/util/piglit-util-gl.c | 15 +-- tests/util/piglit-util-gl.h | 9 - 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 767767d..8dd4c8a 100644 --- a/tests/util/piglit-util-gl.c +++

[Piglit] [PATCH 6/6] arb_vertex_program: Use glGetProgramivARB, not glGetProgramiv.

The rest of the surrounding calls are to the proper ARB functions. --- tests/spec/arb_vertex_program/getlocal4-errors.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_vertex_program/getlocal4-errors.c b/tests/spec/arb_vertex_program/getlocal4-errors.c

[Piglit] [PATCH 4/6] shaders: Drop unnecessary fragment programs from vp-address-*.

--- tests/shaders/vp-address-01.c | 3 --- tests/shaders/vp-address-02.c | 3 --- tests/shaders/vp-address-03.c | 3 --- tests/shaders/vp-address-04.c | 3 --- tests/shaders/vp-address-05.c | 3 --- tests/shaders/vp-address-06.c | 3 --- 6 files changed, 18 deletions(-) diff --git

Re: [Piglit] [PATCH 0/5] Randomized UBO tests of doom

On 2015-11-10 2:08, Ian Romanick wrote: On 11/09/2015 05:19 AM, Ilia Mirkin wrote: On Thu, Sep 25, 2014 at 4:39 PM, Ian Romanick wrote: On 09/24/2014 09:47 AM, Ian Romanick wrote: So, here it is. Finally. The first two patches provide the infrastructure for generating