Re: [Piglit] [PATCH] arb_separate_shader_objects: test explicit location on interface blocks

2015-11-30 Thread Tapani Pälli
Reviewed-by: Tapani Pälli --- 8< --- BTW these most likely won't pass on AMD since I've noticed that if you use SSO and builtin gl_Position, you'll you will need to redeclare built-in interface blocks like this: out gl_PerVertex { vec4 gl_Position; }; I believe this is a bug in AMD drivers

Re: [Piglit] [PATCH] arb_separate_shader_objects: test explicit location with a struct

2015-11-30 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/30/2015 09:42 AM, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.2-dev: fail --- .../execution/layout-location-struct.shader_test | 51 ++ 1 file changed, 51 insertions(+) create mode 100644

Re: [Piglit] [PATCH] arb_tessellation_shader: Check piglit_link_check_status results.

2015-11-30 Thread Marek Olšák
Reviewed-by. Marek Olšák Marek On Mon, Nov 30, 2015 at 8:46 AM, Vinson Lee wrote: > Fixes Coverity "unchecked return value" defects. > > Signed-off-by: Vinson Lee > --- > tests/spec/arb_tessellation_shader/invalid-get-program-params.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

[Piglit] [PATCH] fbo-depth-array: Fix reporting the piglit_result

2015-11-30 Thread Neil Roberts
test_once was ignoring the return value of draw_and_test_layer so the test would report a pass even if it failed. Reported-by: Marek Olšák --- Oops, sorry about that. Thanks for reporting it. tests/fbo/fbo-depth-array

Re: [Piglit] [PATCH] fbo-depth-array: Fix reporting the piglit_result

2015-11-30 Thread Marek Olšák
Reviewed-by: Marek Olšák On Nov 30, 2015 1:19 PM, "Neil Roberts" wrote: > test_once was ignoring the return value of draw_and_test_layer so the > test would report a pass even if it failed. > > Reported-by: Marek Olšák > --- > > Oops, sorry about that. Thanks for reporting it. > tests/fbo/fbo-

Re: [Piglit] [PATCH] astc: avoid deleting a random texture

2015-11-30 Thread Nanley Chery
On Mon, Nov 23, 2015 at 1:28 PM, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 4:16 PM, Ian Romanick wrote: > > On 11/23/2015 12:43 PM, Ilia Mirkin wrote: > >> On Mon, Nov 23, 2015 at 3:34 PM, Ian Romanick > wrote: > >>> On 11/21/2015 04:08 PM, Ilia Mirkin wrote: > In the check_error case,

Re: [Piglit] [PATCH v3 4/4] framework/test/base.py: use subprocess32 for timeouts.

2015-11-30 Thread Dylan Baker
On Fri, Nov 27, 2015 at 12:04:34PM +, Thomas Wood wrote: > On 12 November 2015 at 22:52, wrote: > > From: Dylan Baker > > > > Subprocess32 provides a backport of (ironically) python 3.3's subprocess > > module, which has a timeout parameter. When the timeout runs out then an > > exception is

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Ilia Mirkin
On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery wrote: > From: Nanley Chery > > Enable Piglit to report the result of each individual subtest > for the array and miptree ASTC tests. Modify the miptree test > to only run one subset of ASTC formats at a time. > > v2. Modify miptree test to only check

[Piglit] [PATCH] arb_separate_shader_objects: dont check for INVALID_OPERATION after validation

2015-11-30 Thread Timothy Arceri
Validation should not generate an INVALID_OPERATION only the draw call should, this was seems to have been working around a bug in Mesa. https://bugs.freedesktop.org/show_bug.cgi?id=93180 --- tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 -- 1 file changed, 2 deletions(-)

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Nanley Chery
On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote: > On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery wrote: > > From: Nanley Chery > > > > Enable Piglit to report the result of each individual subtest > > for the array and miptree ASTC tests. Modify the miptree test > > to only run one su

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Ilia Mirkin
On Mon, Nov 30, 2015 at 7:34 PM, Nanley Chery wrote: > On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote: >> On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery wrote: >> > + >> > + /* Load texture for current submode and block size */ >> > + load_texture("compress

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Dylan Baker
On Mon, Nov 30, 2015 at 04:34:40PM -0800, Nanley Chery wrote: > On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote: > > On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery wrote: > > > From: Nanley Chery > > > > > > Enable Piglit to report the result of each individual subtest > > > for the ar

Re: [Piglit] [PATCH] arb_separate_shader_objects: dont check for INVALID_OPERATION after validation

2015-11-30 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 12/01/2015 01:31 AM, Timothy Arceri wrote: Validation should not generate an INVALID_OPERATION only the draw call should, this was seems to have been working around a bug in Mesa. https://bugs.freedesktop.org/show_bug.cgi?id=93180 --- tests/spec/arb_separate_sha

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Nanley Chery
On Mon, Nov 30, 2015 at 07:46:37PM -0500, Ilia Mirkin wrote: > On Mon, Nov 30, 2015 at 7:34 PM, Nanley Chery wrote: > > On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote: > >> On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery > >> wrote: > >> > + > >> > + /* Load texture for

[Piglit] [PATCH] arb_es2_compatibility: Check piglit_link_check_status result.

2015-11-30 Thread Vinson Lee
Fixes Coverity "unchecked return value" defect. Signed-off-by: Vinson Lee --- .../arb_es2_compatibility/arb_es2_compatibility-releaseshadercompiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_es2_compatibility/arb_es2_compatibility-releaseshadercompiler.

[Piglit] [PATCH] arb_program_interface_query: Silence uninitialized variable warning.

2015-11-30 Thread Vinson Lee
Fixes Coverity "uninitialized scalar variable" defect. Signed-off-by: Vinson Lee --- tests/spec/arb_program_interface_query/getprogramresourceiv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/spec/arb_program_interface_query/getprogramresourceiv.c b/tests/spec/arb_program_int

Re: [Piglit] [PATCH] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Nanley Chery
On Mon, Nov 30, 2015 at 05:04:54PM -0800, Dylan Baker wrote: > On Mon, Nov 30, 2015 at 04:34:40PM -0800, Nanley Chery wrote: > > On Mon, Nov 30, 2015 at 03:50:04PM -0500, Ilia Mirkin wrote: > > > On Wed, Oct 28, 2015 at 7:55 PM, Nanley Chery > > > wrote: > > > > From: Nanley Chery > > > > > > >

[Piglit] [PATCH v3] khr_texture_compression_astc: Enable subtest reports

2015-11-30 Thread Nanley Chery
From: Nanley Chery Enable Jenkins to report the result of each individual subtest for the array and miptree ASTC tests. Modify the miptree test to only run one subset of ASTC formats at a time. v2. Modify miptree test to only check the given subtest. Use the -subtest option to run a specific