Re: [Piglit] [PATCH 15/16] namespace-pollution: Add fragment program as an object to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Now the program object tests can run on (hypothetical?) implementations > that support GL_ARB_fragment_program without also supporting > GL_ARB_vertex_program. > > Signed-off-by: Ian Romanick

Re: [Piglit] [PATCH 14/16] namespace-pollution: Add vertex program as an object to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > program with gldrawpixels > > Signed-off-by: Ian Romanick > Bugzilla: htt

Re: [Piglit] [PATCH 13/16] namespace-pollution: Add renderbuffer as an object to test

2016-01-06 Thread Ilia Mirkin
On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > renderbuffer with glgetteximage-compressed > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.

Re: [Piglit] [PATCH 12/16] namespace-pollution: Add glGetTexImage from a compressed texture as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > framebuffer with glgetteximage-compressed > > Signed-off-by: Ian Romanick

Re: [Piglit] [PATCH 11/16] namespace-pollution: Add framebuffer as an object to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > framebuffer with glgeneratemipmap > > Signed-off-by: Ian Romanick > Bugzi

Re: [Piglit] [PATCH 10/16] namespace-pollution: Add glCopyImageSubData as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > This test currently passes on i965 even though the > _mesa_meta_CopyImageSubData_uncompressed calls _mesa_GenFramebuffers. > Before finishing, the CopyImageSubData destroys any object that it c

Re: [Piglit] [PATCH 09/16] namespace-pollution: Add glBlitFramebuffer as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 > --- > tests/all.py | 2 +- > tests/general/object-namespace-polluti

Re: [Piglit] [PATCH 08/16] namespace-pollution: Add glGetTexImage as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 > --- > tests/all.py | 2 +- > tests/general/object-namespace-polluti

Re: [Piglit] [PATCH 07/16] namespace-pollution: Add glTexSubImage2D as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > This test currently passes on i965 even though the > _mesa_meta_pbo_TexSubImage calls _mesa_GenTextures. Before finishing, > the TexSubImage destroys any object that it created. This prevents

Re: [Piglit] [PATCH 06/16] namespace-pollution: Add glClearTexSubImage as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 > --- > tests/all.py | 2 +- > tests/general/object-namespace-polluti

Re: [Piglit] [PATCH 05/16] namespace-pollution: Add glCopyTexSubImage2D as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 > --- > tests/all.py | 2 +- > tests/general/object-namespace-polluti

Re: [Piglit] [PATCH 04/16] namespace-pollution: Add glCopyPixels as an operation to test

2016-01-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > texture with glcopypixels > > Signed-off-by: Ian Romanick > Bugzilla: htt

Re: [Piglit] [PATCH 03/16] namespace-pollution: Add glDrawPixels as an operation to test

2016-01-06 Thread Ilia Mirkin
On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > texture with gldrawpixels > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/s

Re: [Piglit] [PATCH 02/16] namespace-pollution: Add glBitmap as an operation to test

2016-01-06 Thread Ilia Mirkin
On Wed, Jan 6, 2016 at 7:53 PM, Ian Romanick wrote: > From: Ian Romanick > > NOTE: The following tests fail on i965 (and presumably other drivers > that use meta) on Mesa master and 11.1: > > texture with glbitmap > > Signed-off-by: Ian Romanick > Bugzilla: https://bugs.freedesktop.org/show_

Re: [Piglit] [PATCH 01/16] namespace-pollution: Initial framework and test cases for namespace pollution

2016-01-06 Thread Ilia Mirkin
A general comment -- this doesn't check whether meta messes up existing bindings. Am I mistaken? i.e. nothing checks GL_ARRAY_BUFFER_BINDING or whatever across these various operations. This could always be left to later, but it does seem like a possible thing for meta to screw up. Irregardless, th

[Piglit] [PATCH 02/16] namespace-pollution: Add glBitmap as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: texture with glbitmap Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 squash! namespace-pollution: Add glBitmap as an op

[Piglit] [PATCH 03/16] namespace-pollution: Add glDrawPixels as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: texture with gldrawpixels Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 06/16] namespace-pollution: Add glClearTexSubImage as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py | 2 +- tests/general/object-namespace-pollution.c | 35 ++ 2 files changed, 36 insertions(+), 1 deletion(-) d

[Piglit] [PATCH 11/16] namespace-pollution: Add framebuffer as an object to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: framebuffer with glgeneratemipmap Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 13/16] namespace-pollution: Add renderbuffer as an object to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: renderbuffer with glgetteximage-compressed Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 09/16] namespace-pollution: Add glBlitFramebuffer as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py | 2 +- tests/general/object-namespace-pollution.c | 72 ++ 2 files changed, 73 insertions(+), 1 deletion(-) d

[Piglit] [PATCH 05/16] namespace-pollution: Add glCopyTexSubImage2D as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py | 2 +- tests/general/object-namespace-pollution.c | 33 ++ 2 files changed, 34 insertions(+), 1 deletion(-) d

[Piglit] [PATCH 01/16] namespace-pollution: Initial framework and test cases for namespace pollution

2016-01-06 Thread Ian Romanick
From: Ian Romanick See the giant comment in the top of tests/general/object-namespace-pollution.c for more details. Currently only buffer objects and texture objects are supported with glClear and glGenerateMipmap. Addtional objects and operations will be added. Both glClear and glGenerateMipm

[Piglit] [PATCH 10/16] namespace-pollution: Add glCopyImageSubData as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick This test currently passes on i965 even though the _mesa_meta_CopyImageSubData_uncompressed calls _mesa_GenFramebuffers. Before finishing, the CopyImageSubData destroys any object that it created. This prevents it from polluting the namespace. Signed-off-by: Ian Romanick Bugz

[Piglit] [PATCH 15/16] namespace-pollution: Add fragment program as an object to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Now the program object tests can run on (hypothetical?) implementations that support GL_ARB_fragment_program without also supporting GL_ARB_vertex_program. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/general/object-names

[Piglit] [PATCH 00/16] Verify that meta does not pollute object namespaces

2016-01-06 Thread Ian Romanick
From: Ian Romanick Here is the nearly complete set of tests. There still a couple things that should be done and a couple that could be done... but probably aren't worth the effort. More on that below. The current series tests the cross-product of GL operations that are implemented in meta and

[Piglit] [PATCH 08/16] namespace-pollution: Add glGetTexImage as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py | 2 +- tests/general/object-namespace-pollution.c | 58 ++ 2 files changed, 59 insertions(+), 1 deletion(-) d

[Piglit] [PATCH 14/16] namespace-pollution: Add vertex program as an object to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: program with gldrawpixels Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 12/16] namespace-pollution: Add glGetTexImage from a compressed texture as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: framebuffer with glgetteximage-compressed Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 07/16] namespace-pollution: Add glTexSubImage2D as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick This test currently passes on i965 even though the _mesa_meta_pbo_TexSubImage calls _mesa_GenTextures. Before finishing, the TexSubImage destroys any object that it created. This prevents it from polluting the namespace. Signed-off-by: Ian Romanick Bugzilla: https://bugs.fr

[Piglit] [PATCH 04/16] namespace-pollution: Add glCopyPixels as an operation to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Mesa master and 11.1: texture with glcopypixels Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92363 --- tests/all.py

[Piglit] [PATCH 16/16] namespace-pollution: Add Apple vertex array as an object to test

2016-01-06 Thread Ian Romanick
From: Ian Romanick Almost all subtests fail because ARB and Apple VAOs share the same namespace. See the ARB_vertex_array_object spec "Interactions with APPLE_vertex_array_object" section for more details. NOTE: The following tests fail on i965 (and presumably other drivers that use meta) on Me

[Piglit] [PATCH 2/2] framework: record pid of test process in results

2016-01-06 Thread baker . dylan . c
From: Dylan Baker This information can be used on linux in conjunction with scripts to associate information in dmesg with information in piglit results. Adds the pid information to both the json and junit backends, and adds tests for both. This information is not published into any of the summ

[Piglit] [PATCH 1/2] framework/tests/results_tests.py: refactor to_json and from_dict tests

2016-01-06 Thread baker . dylan . c
From: Dylan Baker This slightly refactors these test classes, fixing time time tests, and making the to_json test not do a dict -> test result -> dict conversion, skipping the first dict stage. Signed-off-by: Dylan Baker --- framework/tests/results_tests.py | 77 +-

Re: [Piglit] [PATCH v5 4/4] framework/test/base.py: use subprocess32 for timeouts.

2016-01-06 Thread Dylan Baker
Bump. On Wed, Dec 16, 2015 at 4:52 PM, wrote: > From: Dylan Baker > > Subprocess32 provides a backport of python 3.2's subprocess module, > which has a timeout parameter for Popen.communicate. When the timeout > runs out then an exception is raised, and when that exception is caught > we can ki

Re: [Piglit] [PATCH] gl-1.0-rastercolor: basic test of the raster color used for bitmap drawing

2016-01-06 Thread Jose Fonseca
On 06/01/16 15:26, Brian Paul wrote: --- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/rastercolor.c | 99 + 3 files changed, 101 insertions(+) create mode 100644 tests/spec/gl-1.0/rastercol

[Piglit] [PATCH] gl-1.0-rastercolor: basic test of the raster color used for bitmap drawing

2016-01-06 Thread Brian Paul
--- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/rastercolor.c | 99 + 3 files changed, 101 insertions(+) create mode 100644 tests/spec/gl-1.0/rastercolor.c diff --git a/tests/all.py b/tests/all.