Re: [Piglit] [PATCH 2/2] EGL: build the egl_chromium_sync_control test only if PIGLIT_HAS_X11

2016-02-11 Thread Ryan Houdek
The test pulls in egl-util.h which requires X11 headers, that's how it has a requirement on X11. On Thu, Feb 11, 2016 at 8:20 PM, Emil Velikov wrote: > Hi Mircea, > > On 11 February 2016 at 23:22, Mircea Gherzan > wrote: > > The test uses X11

[Piglit] [PATCH] Fix a cmake issue with compiling the oes base_vertex tests.

2016-02-11 Thread Ryan Houdek
In a GLES only build this would fail to compile --- .../spec/oes_draw_elements_base_vertex/CMakeLists.gles2.txt | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tests/spec/oes_draw_elements_base_vertex/CMakeLists.gles2.txt

[Piglit] [PATCH] program_interface_query: use format layout qualifiers instead of size* layout qualifiers

2016-02-11 Thread Alejandro Piñeiro
From ARB_shader_image_load_store spec: "(0) How does this extension differ from the similar EXT_shader_image_load_store? RESOLVED: The functionality provided by this extension is very similar to that provided by EXT_shader_image_load_stores. There are some

Re: [Piglit] [PATCH] program_interface_query: use format layout qualifiers instead of size* layout qualifiers

2016-02-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 02/11/2016 02:42 PM, Alejandro Piñeiro wrote: From ARB_shader_image_load_store spec: "(0) How does this extension differ from the similar EXT_shader_image_load_store? RESOLVED: The functionality provided by this

Re: [Piglit] [PATCH] program_interface_query: no need to check link status when using piglit_build_simple_program_multiple_shaders

2016-02-11 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 02/10/2016 08:56 PM, Alejandro Piñeiro wrote: From piglit_build_simple_program_multiple_shaders documentation: /** * Builds and links a program from optional sources, throwing * PIGLIT_FAIL on error. The last target must be 0. */ So

[Piglit] [Bug 93336] [IVB, HSW] piglit.spec.arb_program_interface_query.arb_program_interface_query-getprogramresourceiv crashes

2016-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93336 Alejandro Piñeiro (freenode IRC: apinheiro) changed: What|Removed |Added Product|Mesa

Re: [Piglit] [PATCH] python: function with six version 1.5.2

2016-02-11 Thread Brian Paul
On 02/10/2016 07:07 PM, Dylan Baker wrote: CMake actually marks that we require six 1.4.0, however, I can't find any packages anywhere for 1.4.0, and the lowest version I've seen requested is 1.5.2. This fixes requirements for working with six 1.5.2, and sets tox to use 1.5.2 (and a suitable

Re: [Piglit] [PATCH 2/2] EGL: build the egl_chromium_sync_control test only if PIGLIT_HAS_X11

2016-02-11 Thread Ben Widawsky
On Fri, Feb 12, 2016 at 12:22:49AM +0100, Mircea Gherzan wrote: > The test uses X11 headers so this guard is needed. > > Signed-off-by: Mircea Gherzan Both are: Acked-by: Ben Widawsky [snip] -- Ben Widawsky, Intel Open Source Technology

[Piglit] [PATCH 1/2] cmake: use the EGL_CFLAGS_OTHER

2016-02-11 Thread Mircea Gherzan
Without them, the build will fail on a system without the X headers with a recent Mesa from the master branch. The EGL_CFLAGS_OTHER define the MESA_EGL_NO_X11_HEADERS macro that guards the #includes of the X headers. Signed-off-by: Mircea Gherzan --- CMakeLists.txt | 1

[Piglit] [PATCH 2/2] dependencies: Bump numpy version to 1.7.0 in cmake and tox

2016-02-11 Thread Dylan Baker
The previous version (1.6.2) fails to compile against python 3, and is from 2012. Version 1.7.0 does compile against python 3, and is still from February 2013, old enough that even stable Linux distributions should have picked it up by now. Signed-off-by: Dylan Baker

[Piglit] [PATCH 1/2] tox.ini: Set the mako version to the minimum version in cmake

2016-02-11 Thread Dylan Baker
We actually define a minimum required mako version in cmake. Since tox is supposed to be useful for testing, we should test that version. Signed-off-by: Dylan Baker --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index

[Piglit] [PATCH 2/2] EGL: build the egl_chromium_sync_control test only if PIGLIT_HAS_X11

2016-02-11 Thread Mircea Gherzan
The test uses X11 headers so this guard is needed. Signed-off-by: Mircea Gherzan --- tests/egl/spec/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/egl/spec/CMakeLists.txt b/tests/egl/spec/CMakeLists.txt index

Re: [Piglit] [PATCH] cl/math: Add some basic ilogb builtin tests

2016-02-11 Thread Jan Vesely
On Wed, 2016-02-10 at 20:57 -0600, Aaron Watry wrote: > Note: Doesn't test 0 or NaN as those inputs support multiple possible > output values. I guess FP_ILOGB{0,NAN} are available only in CLC. Reviewed-by: Jan Vesely > > Signed-off-by: Aaron Watry >

Re: [Piglit] [PATCH 2/2] EGL: build the egl_chromium_sync_control test only if PIGLIT_HAS_X11

2016-02-11 Thread Emil Velikov
Hi Mircea, On 11 February 2016 at 23:22, Mircea Gherzan wrote: > The test uses X11 headers so this guard is needed. > I must be going blind...but I cannot see any such thing in the test. Can you please point out which X11 headers and/or how they end up in the includes

[Piglit] [PATCH v2 1/2] tox.ini: Set the mako version to the minimum version in cmake

2016-02-11 Thread Dylan Baker
We actually define a minimum required mako version in cmake. Since tox is supposed to be useful for testing, we should test that version. Mako 1.0.2 contains bug fixes for python 3.5. For versions earlier than 3.5 0.8.0 is still sufficient, but for 3.5 1.0.2 is needed. CMake is updated to enforce

[Piglit] [PATCH v2 2/2] dependencies: Bump numpy version to 1.7.0 in cmake and tox

2016-02-11 Thread Dylan Baker
The previous version (1.6.2) fails to compile against python 3, and is from 2012. Version 1.7.0 does compile against python 3, and is still from February 2013, old enough that even stable Linux distributions should have picked it up by now. Signed-off-by: Dylan Baker

Re: [Piglit] [PATCH 1/2] cmake: use the EGL_CFLAGS_OTHER

2016-02-11 Thread Dylan Baker
Quoting Mircea Gherzan (2016-02-11 15:22:48) > Without them, the build will fail on a system without the X headers with > a recent Mesa from the master branch. The EGL_CFLAGS_OTHER define the > MESA_EGL_NO_X11_HEADERS macro that guards the #includes of the X > headers. > > Signed-off-by: Mircea

Re: [Piglit] [PATCH 1/2] cmake: use the EGL_CFLAGS_OTHER

2016-02-11 Thread Ben Widawsky
On Thu, Feb 11, 2016 at 05:43:54PM -0800, Dylan Baker wrote: > Quoting Mircea Gherzan (2016-02-11 15:22:48) > > Without them, the build will fail on a system without the X headers with > > a recent Mesa from the master branch. The EGL_CFLAGS_OTHER define the > > MESA_EGL_NO_X11_HEADERS macro that

Re: [Piglit] [PATCH 1/2] cmake: use the EGL_CFLAGS_OTHER

2016-02-11 Thread Emil Velikov
On 12 February 2016 at 01:43, Dylan Baker wrote: > Quoting Mircea Gherzan (2016-02-11 15:22:48) >> Without them, the build will fail on a system without the X headers with >> a recent Mesa from the master branch. The EGL_CFLAGS_OTHER define the >> MESA_EGL_NO_X11_HEADERS

[Piglit] [PATCH] getteximage-formats: Add option to clear texture before rendering

2016-02-11 Thread Topi Pohjolainen
Demonstrates a bug in Intel color resolve logic. If rendering to texture is preceded by fast clear subsequent reads from the texture require the underlying color buffer to be resolved. In case of mipmap generation Intel driver needs to reallocate the underlying buffer to fit the subsequent levels.

[Piglit] [Bug 93336] [IVB, HSW] piglit.spec.arb_program_interface_query.arb_program_interface_query-getprogramresourceiv crashes

2016-02-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93336 Alejandro Piñeiro (freenode IRC: apinheiro) changed: What|Removed |Added Status|NEW