[Piglit] [PATCH] arb_program_interface_query: test stage ref for buffer blocks

2016-04-04 Thread Timothy Arceri
This tests that we get the correct stage reference information when a shader has both a shader storage and uniform block. This exposes a bug in Mesa where we were expecting the index to be an index of a combined SSBO and UBO resources list. When they should instead each have their own resource lis

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

2016-04-04 Thread Dylan Baker
From the python side of things this looks really good (I can also vouch for the CMake), I have a few small nits, but nothing serious and I don't have a need to see another version. You should probably have someone more GL qualified look at that, but for my part: Reviewed-by: Dylan Baker Quoting

Re: [Piglit] [PATCH 4/5] deqp: in group mode, rerun tests that fail in test at a time mode

2016-04-04 Thread Dylan Baker
Quoting Jason Ekstrand (2016-04-04 14:14:23) > I think the default mode we want here is more of a "continue after crash" mode > where, when it crashes, we don't rerun anything but instead just continue > starting from the next test.  This is what Google does with their "cherry" > tool > and it wou

Re: [Piglit] [PATCH 4/5] deqp: in group mode, rerun tests that fail in test at a time mode

2016-04-04 Thread Jason Ekstrand
I think the default mode we want here is more of a "continue after crash" mode where, when it crashes, we don't rerun anything but instead just continue starting from the next test. This is what Google does with their "cherry" tool and it would prevent ensure that random crashes don't get hidden b

Re: [Piglit] [PATCH 1/8] README: Fix spelling mistake

2016-04-04 Thread Dylan Baker
Quoting Eric Engestrom (2016-04-03 11:21:25) > Signed-off-by: Eric Engestrom > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index 535a26e..d738cb1 100644 > --- a/README > +++ b/README > @@ -407,7 +407,7 @@ Every test is run as a separate

Re: [Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

2016-04-04 Thread Andres Gomez
This patch provides additional tests for the patch under review at: https://lists.freedesktop.org/archives/mesa-dev/2016-April/111842.html Also, this generator provides additional tests for the ARB_gpu_shader_fp64 extension: https://www.opengl.org/registry/specs/ARB/gpu_shader_fp64.txt Which has

[Piglit] [PATCH] gen_flat_interpolation_qualifier.py: Adds non-flat interpolation tests generator

2016-04-04 Thread Andres Gomez
Generator for error checking on "flat" keyword. This generator adds, additionally, checks for variables inside structs and interface blocks, which weren't explicitly mentioned in the GLSL specs and, partially, in the GLSL ES specs. For a discussion about this check https://lists.freedesktop.org/a

Re: [Piglit] [PATCH RESEND] cl: Fix image support when built on CL<1.2

2016-04-04 Thread Jan Vesely
On Mon, 2016-03-28 at 21:17 -0400, Jan Vesely wrote: > Provide our own image_desc structure since it's too tangled to > remove. > Tests that require OCL 1.2 result in WARN: > Piglit was compiled with lower OpenCL version (1.1) than version_min: > 12. > OCL 1.1 image tests pass on Intel CPU OCL when

Re: [Piglit] [PATCH 1/2] registery: update gl.xml to r32598

2016-04-04 Thread Kenneth Graunke
Typo in the commit title - "registery" vs. "registry". This patch is: Acked-by: Kenneth Graunke Patch 2 is: Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedes

Re: [Piglit] [PATCH 1/2] util: GL ES doesn't like glReadPixels(GL_RGB). Always use RGBA instead.

2016-04-04 Thread Kenneth Graunke
On Sunday, April 3, 2016 8:13:51 PM PDT Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > tests/util/piglit-util-gl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c > index d636810..dbdfb13 100644 > ---

Re: [Piglit] texsubimage: Option to run against fixed region

2016-04-04 Thread Kenneth Graunke
On Tuesday, March 1, 2016 12:13:21 PM PDT Topi Pohjolainen wrote: > While working on bug 91926 I spent quite some time simplifying > the test to increase the probability of the error on Intel SKL > hardware. This series adds an option to run the test against > fixed target, format and region. > >

[Piglit] [PATCH v2] util: Add new headed matrix_index header to [vertex data]

2016-04-04 Thread Alejandro Piñeiro
From: Timothy Arceri This allows data to be set for matrix attributes in shader runner. For example to set colunm 2 of mat2x3: attname/float/3/1 v2 (changes made by Alejandro in behalf of Timothy Arceri): * Fix matrix_index, as was wrongly being substracted by 1 (so for column 0, matrix ind

[Piglit] [PATCH] Add a copy of samplemaskin-basic that uses a non-const array index.

2016-04-04 Thread Kenneth Graunke
Currently triggers an assert fail in Mesa's GLSL compiler. --- .../execution/samplemaskin-indirect.shader_test| 27 ++ 1 file changed, 27 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/samplemaskin-indirect.shader_test diff --git a/tests/spec/arb_