Re: [Piglit] [PATCH 4/4] piglit-print-commands: Add --format option

2016-05-03 Thread Dylan Baker
Quoting Brian Paul (2016-05-03 15:50:01) > On 05/03/2016 03:59 PM, Dylan Baker wrote: > > This option allows the format of the output string to be modified by > > passing a command line argument. This allows for specialized formats to > > be printed for other uses than the original usage that

Re: [Piglit] [PATCH 4/4] piglit-print-commands: Add --format option

2016-05-03 Thread Brian Paul
On 05/03/2016 03:59 PM, Dylan Baker wrote: This option allows the format of the output string to be modified by passing a command line argument. This allows for specialized formats to be printed for other uses than the original usage that print-commands was designed for. Can you give an

[Piglit] [PATCH 1/4] tests/sanity: Make test group and name match the one in all.py

2016-05-03 Thread Dylan Baker
This test has an extra instance of it's name in the sanity profile when compared to the all profile. Make them the same between the two profiles. Signed-off-by: Dylan Baker --- tests/sanity.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Piglit] [PATCH 2/4] framework/profile: Fail gracefully when reordering of tests fail

2016-05-03 Thread Dylan Baker
Currently if a test name is passed that doesn't exist in the first profile a stack trace will be generated. This isn't necessary, since it's an expected behavior that reordering fails when asked to order a test not contained in the profile. Instead just fail gracefully with a helpful message.

[Piglit] [PATCH 3/4] framework: Add piglit-print-commands to the piglit command

2016-05-03 Thread Dylan Baker
This is mostly just restructuring code so that piglit-print-command works like the other piglit-* commands, calling back into the same module that the main piglit application does. This allows the addition of the 'piglit print-cmds' for those who prefer that (or who use an installed piglit and

[Piglit] (no subject)

2016-05-03 Thread Dylan Baker
From 8c658e7e88c845d294db1a4001d640e563c03dbc Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 3 May 2016 14:54:06 -0700 Subject: [PATCH 0/4] piglit-print-commands: add format argument This small series adds support for giving piglit-print-command a format option. The

Re: [Piglit] [PATCH] builtin_function*py: more test data for "trunc"

2016-05-03 Thread Eric Anholt
Andres Gomez writes: > When performing a trunc op in a float value there is, basically, three > scenarios: when the exponent is < 0, when it is > bitsize of the > significand or with a value in the middle. Current generator was using > data for values in the middle and < 0 but

Re: [Piglit] [PATCH 1/2] util: Add array_index support to [vertex data] (v2)

2016-05-03 Thread Alejandro Piñeiro
From my side: Reviewed-by: Alejandro Piñeiro Having said so, with this patch we are basically changing the format for vertex attribute data, used on tons of existing shader tests. And although the previous format is still supported, this patch marks it as deprecated. So

Re: [Piglit] [PATCH 03/37] glean/tfragprog1: port ADD tests to shader_runner

2016-05-03 Thread Dylan Baker
On May 3, 2016 4:11:43 AM PDT, "Pohjolainen, Topi" wrote: >On Mon, May 02, 2016 at 02:59:05PM -0700, Dylan Baker wrote: >> This ports the following tests: >> - ADD test >> - ADD with saturation >> - ADD an immediate >> - ADD negative immediate >> >> It does not

Re: [Piglit] [PATCH 0/5] Make piglit test ordering deterministic

2016-05-03 Thread Dylan Baker
Right. So without the patches the tests are sorted by some implementation detail of Python, with these patches they are guaranteed to be ordered the same as they are given in the profile. Dylan On May 3, 2016 8:29:13 AM PDT, Marius Vlad wrote: >So, with these patches

Re: [Piglit] [PATCH 0/5] Make piglit test ordering deterministic

2016-05-03 Thread Marius Vlad
So, with these patches we won't have that ``randomized'' feature at all right? (unless the test list is given as such). On Mon, May 02, 2016 at 02:21:09PM -0700, Dylan Baker wrote: > This series makes the test ordering in piglit deterministic, in that it > will run the tests in the order that

[Piglit] [PATCH 1/2] util: Add array_index support to [vertex data] (v2)

2016-05-03 Thread Andres Gomez
This allows data to be set for arbitrary array sized attributes in shader runner. For example to set mat2x3[2]: attname[0]/mat2x3/3/1 attname[0]/mat2x3/3/2 attname[1]/mat2x3/3/1 attname[1]/mat2x3/3/2 The syntax has been extended so the recommended type to specify in the [vertex data] header

Re: [Piglit] [PATCH 0/5] Make piglit test ordering deterministic

2016-05-03 Thread Gabriel Feceoru
On 03.05.2016 00:21, Dylan Baker wrote: This series makes the test ordering in piglit deterministic, in that it will run the tests in the order that they are provided by the profile. For native piglit tests (OpenGL and OpenCL) this will make them completely deterministic, for external

[Piglit] [PATCH] builtin_function*py: more test data for "trunc"

2016-05-03 Thread Andres Gomez
When performing a trunc op in a float value there is, basically, three scenarios: when the exponent is < 0, when it is > bitsize of the significand or with a value in the middle. Current generator was using data for values in the middle and < 0 but not for the last case so we add now a couple of

Re: [Piglit] [PATCH 03/37] glean/tfragprog1: port ADD tests to shader_runner

2016-05-03 Thread Pohjolainen, Topi
On Mon, May 02, 2016 at 02:59:05PM -0700, Dylan Baker wrote: > This ports the following tests: > - ADD test > - ADD with saturation > - ADD an immediate > - ADD negative immediate > > It does not port ADD negative "immediate (2)", which adds MOV, MUL, and > swizzling. It might be a useful test

Re: [Piglit] [PATCH] arb_internalformat_query2: use PRIi64 instead of PRIu64 macro

2016-05-03 Thread Eduardo Lima Mitev
Looks good. Reviewed-by: Eduardo Lima Mitev Thanks! On 05/02/2016 02:50 PM, Alejandro Piñeiro wrote: > As all the values we are printing are 64 bit integers, not unsigned integers. > > In general this is not relevant, as no query for a supported combination > of pname,target