[Piglit] [PATCH] shader_runner: Check sscanf return value.

Fix Coverity unchecked return value defect. CID: 1373655 Signed-off-by: Vinson Lee --- tests/shaders/shader_runner.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

Quoting Brian Paul (2016-11-04 16:02:38) > On 11/04/2016 02:49 PM, Dylan Baker wrote: > > Quoting Brian Paul (2016-11-04 13:18:21) > >> On 11/04/2016 01:49 PM, Dylan Baker wrote: > > [snip] > >> > >> This works, but > >> 1. seems like a lot of duplicated code. > >> 2. How about a simpler error

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

On 11/04/2016 02:49 PM, Dylan Baker wrote: Quoting Brian Paul (2016-11-04 13:18:21) On 11/04/2016 01:49 PM, Dylan Baker wrote: [snip] This works, but 1. seems like a lot of duplicated code. 2. How about a simpler error message like: "Unable to open '%s'" But that's not the problem. The

[Piglit] [PATCH] cl: Use HAVE_RT to determine linking with rt.

Fix build error on Mac OS X. Linking C executable ../../../../../bin/cl-custom-use-sub-buffer-in-kernel ld: library not found for -lrt Fixes: e34b54672cbb ("cl: Fix build on systems where clock_gettime is only avaiable in librt") Signed-off-by: Vinson Lee ---

Re: [Piglit] [PATCH] util: Remove duplicate assignment.

On 11/04/2016 04:17 PM, Vinson Lee wrote: Fix Coverity evaluation order violation defect. CID: 1374296 Fixes: e0048f4940f7 ("util: Add piglit_delay_ns() api") Signed-off-by: Vinson Lee --- tests/util/piglit-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Piglit] [PATCH] util: Remove duplicate assignment.

Fix Coverity evaluation order violation defect. CID: 1374296 Fixes: e0048f4940f7 ("util: Add piglit_delay_ns() api") Signed-off-by: Vinson Lee --- tests/util/piglit-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-util.c

Re: [Piglit] [PATCH] util: Include time.h on all platforms.

On Fri, Nov 4, 2016 at 8:45 AM, Brian Paul wrote: > On 11/03/2016 03:36 PM, Vinson Lee wrote: >> >> Fix MinGW build error. >> >> piglit-util.c: In function 'piglit_time_is_monotonic': >> piglit-util.c:583:18: error: storage size of 't' isn't known >>struct timespec t; >>

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

Quoting Brian Paul (2016-11-04 13:18:21) > On 11/04/2016 01:49 PM, Dylan Baker wrote: [snip] > > This works, but > 1. seems like a lot of duplicated code. > 2. How about a simpler error message like: "Unable to open '%s'" But that's not the problem. The function that it's failing in is

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

On 11/04/2016 01:49 PM, Dylan Baker wrote: Currently if there is a typo in a filename (which piglit uses to determine if a particular result can be loaded) then a message about an unsupported backend will be generated. Obviously, the more common reason for this error is a typo or pointing at the

Re: [Piglit] [PATCH 1/2] framework/backends: Make BackendError a PiglitInternalError

On 11/04/2016 01:49 PM, Dylan Baker wrote: Just a bit of house keeping. Signed-off-by: Dylan Baker --- framework/backends/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/framework/backends/__init__.py

[Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

Currently if there is a typo in a filename (which piglit uses to determine if a particular result can be loaded) then a message about an unsupported backend will be generated. Obviously, the more common reason for this error is a typo or pointing at the wrong directory, not that you've tried to

[Piglit] [PATCH 1/2] framework/backends: Make BackendError a PiglitInternalError

Just a bit of house keeping. Signed-off-by: Dylan Baker --- framework/backends/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/framework/backends/__init__.py b/framework/backends/__init__.py index 488ad55..ce9f1db 100644 ---

Re: [Piglit] [PATCH] framework/backends/json: Handle updating results without pid field

On 11/04/2016 01:34 PM, Dylan Baker wrote: If it's not present make it an empty list. cc: Brian Paul Signed-off-by: Dylan Baker --- framework/backends/json.py | 5 - unittests/framework/backends/test_json_update.py |

[Piglit] [PATCH] framework/backends/json: Handle updating results without pid field

If it's not present make it an empty list. cc: Brian Paul Signed-off-by: Dylan Baker --- framework/backends/json.py | 5 - unittests/framework/backends/test_json_update.py | 24 2 files changed, 28

[Piglit] exception updating json results from v7 to v9

Hi Dylan, Found a another issue. I have a results json file of version 7. The piglit-summary.py script is failing while converting from version 8 to 9 (the 7->8 conversion step evidently works): Traceback (most recent call last): File "./piglit-summary.py", line 35, in

[Piglit] piglit-summary.py exception on file not found

Hi Dylan, Could we have piglit-summary.py print a simple error message when the file is not found, rather than raising an exception: $ ./piglit-summary.py -s foo /home/brian/projects/piglit-mingw32-new/piglit/framework/test/base.py:77: UserWarning: Timeouts are not available

Re: [Piglit] [PATCH] util: Include time.h on all platforms.

On 11/03/2016 03:36 PM, Vinson Lee wrote: Fix MinGW build error. piglit-util.c: In function 'piglit_time_is_monotonic': piglit-util.c:583:18: error: storage size of 't' isn't known struct timespec t; ^ Fixes: e0048f4940f7 ("util: Add piglit_delay_ns() api") Bugzilla:

[Piglit] [PATCH] glsl-1.50: do not link interface-blocks-containing-unsized-arrays.geom

Linking means that we will validate in/out blocks between consumer and producer stages. In this case it should fail because for geometry shaders piglit will include a dummy vertex shader that does not have a matching output block. This has not been a problem until now because the linker was not

Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

On 11/03/2016 06:01 PM, Ilia Mirkin wrote: The RGB -> RGBA thing is probably because GLES is a lot pickier about formats matching and not having to do conversion. I had to do that all over the place when GLES-ifying piglits. Fixing this at the util level would be nice, but I couldn't think of