Re: [Piglit] [PATCH 1/5] arb_post_depth_coverage-basic: Add a basic initial test.

On Wed, Nov 9, 2016 at 6:39 PM, Plamena Manolova wrote: > A basic test to check whether the values written to gl_SampleMaskIn > are still correct after enabling the ARB_post_depth_coverage > extension. > > Signed-off-by: Plamena Manolova >

[Piglit] [PATCH 1/5] arb_post_depth_coverage-basic: Add a basic initial test.

A basic test to check whether the values written to gl_SampleMaskIn are still correct after enabling the ARB_post_depth_coverage extension. Signed-off-by: Plamena Manolova --- registry/gl.xml| 2 + tests/all.py

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

On Wed, Nov 9, 2016 at 11:41 PM, Francisco Jerez wrote: > @@ -3622,7 +3636,6 @@ piglit_init(int argc, char **argv) > sso_in_use = false; > prog_err_info = NULL; > vao = 0; > -

Re: [Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

Bump. Anyone interested in this? Dylan Quoting Dylan Baker (2016-10-31 14:40:35) > There are 18000 of these tests, quick.py has 53000 tests, which is 34% > of the total tests. That's just too many for quick.py. > > This patch takes the somewhat naive approach of just filtering out 80% > of

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

Marek Olšák writes: > On Wed, Nov 9, 2016 at 8:10 PM, Francisco Jerez wrote: >> Marek Olšák writes: >> >>> On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez >>> wrote: This refactors the implementation of

Re: [Piglit] [PATCH] draw-vertices-half-float: Add coverage for GL_OES_vertex_half_float

On Monday, October 10, 2016 2:25:02 PM PST Kevin Strasser wrote: > Add ES2 implementation to the test to provide coverage for > GL_OES_vertex_half_float extension. The tests will continue to pass on mesa > for desktop GL as well as ES2 once supported is added. > > Signed-off-by: Kevin Strasser

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

On Wed, Nov 9, 2016 at 8:10 PM, Francisco Jerez wrote: > Marek Olšák writes: > >> On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez >> wrote: >>> This refactors the implementation of the various "fb" commands to be >>> part of a

Re: [Piglit] [Patch 1/1] texelFetch, textureSize: replace deprecated gl_FragColor

On Wednesday, November 9, 2016 3:18:36 PM PST Sebastian Olender wrote: > According to GLSLLangSpec: Use of gl_FragData and gl_FragColor > is deprecated in version 1.3, using user-defined out instead. > --- > tests/texturing/shaders/texelFetch.c | 9 ++--- >

[Piglit] [PATCH v4 24/27] framework/profile: Move group_manager from TestProfile to TestDict

This move is going to allow us to supplement the TestDict with a different class that can be used instead that loads xml. Signed-off-by: Dylan Baker --- framework/profile.py| 104 ++ tests/all.py| 508

[Piglit] [PATCH v4 21/27] framework/profile: Split try/except block

This will avoid catching AttributeErrors when importing, and only catch them if mod.profile doesn't exist. Signed-off-by: Dylan Baker --- framework/profile.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/framework/profile.py

[Piglit] [PATCH v4 3/27] framework/profile: make run hooks public

These are used in a couple of places, and since they're meant to be changed by subclasses they need to be public. Signed-off-by: Dylan Baker --- framework/profile.py | 28 tests/igt.py | 3 ++- tests/xts.py | 8 3

[Piglit] [PATCH v4 26/27] framework/test/glsl_parser_test.py: split the parser out of the class

This pulls the code for parsing the test file out of GLSLParserTest and puts them in a new Parser class. This is going be useful later for allowing the parsing to be done during the compile stage, and not require searching the file system at runtime. Signed-off-by: Dylan Baker

[Piglit] [PATCH v4 27/27] tests/all.py: Make add_fbo_depthstencil_tests take an adder

This helper is the only one that doesn't take an adder function, which is a consistency issue. But more importantly with the move of the group_manager to TestDict instead of TestProfile, it makes an unsafe assumption about the availability of the group_manager method, since a TestDict could be

[Piglit] [PATCH v4 25/27] framework/test/base: Remove timeout parameter

This doesn't work and never has, setting it would cause an exception, and I'm not exactly sure how to fix it. It's also unused, so we can bring it back later if we need it. Signed-off-by: Dylan Baker --- framework/test/base.py | 5 + 1 file changed, 1 insertion(+),

[Piglit] [PATCH v4 22/27] framework/profile: replace Testprofile.{dmesg, monitoring} with dict

This allows a significant amount of cleanup to happen. It allows removing attributes from the global OPTIONS, removing tests that no longer apply, and because of the split run method it allows more values to simply be passed. Signed-off-by: Dylan Baker ---

[Piglit] [PATCH v4 8/27] framework/profile: add a copy method to profile

This will allow a profile to be copied and "subclassed" without affecting the original profile. This will allow a long-standing bug that made it impossible to run two subclasses of all.py (say shader.py and glslparser.py) at the same time, since they would both try to modify the all.py profile in

[Piglit] [PATCH v4 12/27] framework/programs/run: remove redundant list() around comprehension

This is a list comprehension, it already results in a list. There is no need to wrap it in the list() constructor call. Signed-off-by: Dylan Baker --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Piglit] [PATCH v4 9/27] tests: Copy profiles to allow them to be run in parallel

Some of these would be rather silly to run in parallel (xts and xts-render, for example), but this will help avoid copy and pasting things leading to the propagation of bad code. Signed-off-by: Dylan Baker --- tests/cpu.py| 4 +++- tests/glslparser.py | 4 +++-

[Piglit] [PATCH v4 23/27] framework/profile: remove unused argument from TestProfile.group_manager

Signed-off-by: Dylan Baker --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index 1bde8fb..7e09081 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -217,7 +217,7 @@

[Piglit] [PATCH v4 14/27] framework/programs/run: import framework.profile as profile

Since there isn't a conflict in the name anymore, this just makes the code cleaner and easier to read. Signed-off-by: Dylan Baker --- framework/programs/run.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/framework/programs/run.py

[Piglit] [PATCH v4 7/27] framework/programs/run: Remove use of TestrunResult

We basically only used it to set the name and the time elapsed. That's silly, just do those things directly. It needs less code and doesn't require creating a big object. This is leftover from the days before atomic writes, when results were all stored in memory until the end of the run.

[Piglit] [PATCH v4 19/27] framework/profile: Update __all__

Signed-off-by: Dylan Baker --- framework/profile.py | 2 ++ 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 9f72718..5f4657a 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -49,8 +49,10 @@

[Piglit] [PATCH v4 11/27] framework/profile: Don't merge profiles

Because we can copy profiles, we don't need to merge them to run more than one of them. Instead we can simply have a list of profiles, and run them one by one. One side effect of this is that tests will be run one profile at a time, so if running with out the -1/--no-concurrency or

[Piglit] [PATCH v4 20/27] framework/profile: Update docstrings

Signed-off-by: Dylan Baker --- framework/profile.py | 101 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 5f4657a..042cf98 100644 --- a/framework/profile.py

[Piglit] [PATCH v4 10/27] framework/programs/run: Only allow --test-list if one profile

This limitation has basically always existed, but for the next patch to function this is a requirement. This limitation will be properly fixed in a follow up series (that was originally part of this series, but the size and scope of the series got too big so this was split.) Signed-off-by: Dylan

[Piglit] [PATCH v4 18/27] framework/profile: Don't alter the TestProfile before running

This patch changes the way that the tests from TestProfile are processed. Rather than having a process_test_list method that modifies TestProfile.test_list, a new itertests() method creates an iterator that yields tests that are not excluded by filters. This saves a bit of code, increases the

[Piglit] [PATCH v4 4/27] framework/profile: Drop unneeded except

A try/finally works better here anyway. Signed-off-by: Dylan Baker --- framework/profile.py | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 0d2e1cf..f63180a 100644 --- a/framework/profile.py

[Piglit] [PATCH v4 1/27] framework/result: TestrunResult.options should be a dict

This changes the default type from None to a dict, which is what it is when setup in framework/programs/run. Signed-off-by: Dylan Baker --- framework/results.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/results.py

[Piglit] [PATCH v4 16/27] framework: Pull {include, exclude}_filter out of Options

Since these are also just special cases of filters for the standard TestProfile filtering mechanism, and they have a lot of unique classes. This is just a waste, the same can be achieved with a much simpler class structure. Signed-off-by: Dylan Baker ---

[Piglit] [PATCH v4 17/27] framework/profile: Factor out check_all closure

This does away with the check_all closure, by simplifying it down to an equivalent lambda expression. Signed-off-by: Dylan Baker --- framework/profile.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/framework/profile.py

[Piglit] [PATCH v4 5/27] framework: Split the run method out of profile.

There are a couple of reasons for doing this. First, profile is a big complex mess that does entirely too much, and this helps with that. Second, there are bugs in the way two profiles run at the same time work, and this is going to fix that. Signed-off-by: Dylan Baker

[Piglit] [PATCH v4 6/27] framework: remove concurrent from OPTIONS, pass directly to profile

This removes a value out of the global OPTIONS, which is nice. It's very trivial to pass this instead of putting it in options. Signed-off-by: Dylan Baker --- framework/options.py | 2 -- framework/profile.py | 8 +--- framework/programs/run.py | 11

[Piglit] [PATCH v4 13/27] framework/profile: Drop TestProfile.filter_tests

This was just a thin wrapper around the already public TestProfile.filters list. It seems silly to have such a method when it does nothing but call self.filters.append. Signed-off-by: Dylan Baker --- framework/profile.py | 16 +++- tests/all.py | 2

[Piglit] [PATCH v4 15/27] framework: Remove exclude_tests from options.OPTIONS

Rather than putting this in a global variable, just add a filter for this in the runner. Far simpler, and removes more globals. Signed-off-by: Dylan Baker --- framework/options.py| 1 - framework/profile.py| 1 -

[Piglit] [PATCH v4 2/27] unittests: Add tests for the feature completeness summary

This adds a few simple tests for the feature completeness summary object. Nothing to strenuous but much better than nothing. Signed-off-by: Dylan Baker --- unittests/framework/summary/test_feature.py | 116 +- 1 file changed, 116 insertions(+), 0

[Piglit] [PATCH v4 0/27] Various cleanups for profiles

This series is a large collections of cleanups for th profile module and particularly for the TestProfile and TestDict classes. These began their lives as the start of a series to serialize the TestDict at compile time and to move startup overhead. This series is just a bunch of cleanups and

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

Quoting Dylan Baker (2016-11-09 12:08:34) > Quoting Lionel Landwerlin (2016-11-09 03:39:33) > > This tests that the compiler accepts the new layout formats introduced by > > NV_image_formats and also it's correct interaction with the > > EXT_texture_norm16 specification. > > > > Signed-off-by:

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

Quoting Lionel Landwerlin (2016-11-09 03:39:33) > This tests that the compiler accepts the new layout formats introduced by > NV_image_formats and also it's correct interaction with the > EXT_texture_norm16 specification. > > Signed-off-by: Lionel Landwerlin > ---

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

Marek Olšák writes: > On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez > wrote: >> This refactors the implementation of the various "fb" commands to be >> part of a single 'if (parse_str(line, "fb ", ...)) {}' block in order >> to make code-sharing

Re: [Piglit] [PATCH v2 2/2] generated_tests: new compiler tests for NV_image_formats

On Wed, Nov 9, 2016 at 12:15 PM, Lionel Landwerlin wrote: > This tests that the compiler accepts the new layout formats introduced by > NV_image_formats and also it's correct interaction with the > EXT_texture_norm16 specification. > > v2: Only disallow normalized

[Piglit] [PATCH v2 2/2] generated_tests: new compiler tests for NV_image_formats

This tests that the compiler accepts the new layout formats introduced by NV_image_formats and also it's correct interaction with the EXT_texture_norm16 specification. v2: Only disallow normalized formats when EXT_texture_norm16 is not available (Ilia) Signed-off-by: Lionel Landwerlin

[Piglit] [PATCH v2 1/2] gen_extensions_defined.py: add NV_image_formats

This extensions is written against OpenGL ES 3.1 and 3.10 of the OpenGL ES Shading Language specification. v2: Fix missing 'GL_' prefix (Ilia) Signed-off-by: Lionel Landwerlin --- generated_tests/gen_extensions_defined.py | 1 + 1 file changed, 1 insertion(+)

Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support

On Tue, 2016-11-08 at 12:59 -0500, Ilia Mirkin wrote: > Could you update the change description to say precisely what each of > these things do? It's hard to review otherwise since I have to go out > and look up the things I don't know or have since forgotten. Done and sent again for review. I

Re: [Piglit] [PATCH] dir-locals.el: Adds White Space support

Acked-by: Ilia Mirkin I won't bother asking why one whitespace-line-column is set to 79 and the other to 80. I'm sure the answer would just disappoint me. On Wed, Nov 9, 2016 at 11:29 AM, Andres Gomez wrote: > The White Space package, which is available

[Piglit] [PATCH] dir-locals.el: Adds White Space support

The White Space package, which is available since GNU Emacs 22, is loaded and activated locally in prog-mode and cmake-mode. Also, using White Space variables, we set highlighting through faces on wrong indentation and the maximum length of a coding line. Notice that: - The highlighting for the

[Piglit] [Patch 1/1] texelFetch, textureSize: replace deprecated gl_FragColor

According to GLSLLangSpec: Use of gl_FragData and gl_FragColor is deprecated in version 1.3, using user-defined out instead. --- tests/texturing/shaders/texelFetch.c | 9 ++--- tests/texturing/shaders/textureSize.c | 9 ++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

The extra ext is only required for unorm and snorm formats, not all 16-bit ones. On Nov 9, 2016 6:39 AM, "Lionel Landwerlin" wrote: > This tests that the compiler accepts the new layout formats introduced by > NV_image_formats and also it's correct interaction

Re: [Piglit] [PATCH 1/2] gen_extensions_defined.py: add NV_image_formats

On Nov 9, 2016 6:39 AM, "Lionel Landwerlin" wrote: > > This extensions is written against OpenGL ES 3.1 and 3.10 of the OpenGL ES > Shading Language specification. > > Signed-off-by: Lionel Landwerlin > --- >

Re: [Piglit] [PATCH 06/18] shader_runner: Refactor handling of fb commands.

On Wed, Oct 19, 2016 at 1:36 AM, Francisco Jerez wrote: > This refactors the implementation of the various "fb" commands to be > part of a single 'if (parse_str(line, "fb ", ...)) {}' block in order > to make code-sharing easier among fb subcommands. Will be more useful >

Re: [Piglit] [PATCH] glsl-1.50: do not link interface-blocks-containing-unsized-arrays.geom

If nobody has comments about this, I'd like to push it tomorrow together with the corresponding patch in Mesa. Iago On Fri, 2016-11-04 at 13:33 +0100, Iago Toral Quiroga wrote: > Linking means that we will validate in/out blocks between consumer > and > producer stages. In this case it should

[Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

This tests that the compiler accepts the new layout formats introduced by NV_image_formats and also it's correct interaction with the EXT_texture_norm16 specification. Signed-off-by: Lionel Landwerlin --- generated_tests/CMakeLists.txt | 4 +

[Piglit] [PATCH 0/2] Tests for NV_image_formats

Hi all, We do have some interest to have support for R8 images in GLES on Intel hardware for ChromeOS [1] and it seems enabling the NV_image_formats extension is the way to go. I'm not quite sure how much this needs to be tested. Any direction would be really helpful. For now, here are some

[Piglit] [PATCH 1/2] gen_extensions_defined.py: add NV_image_formats

This extensions is written against OpenGL ES 3.1 and 3.10 of the OpenGL ES Shading Language specification. Signed-off-by: Lionel Landwerlin --- generated_tests/gen_extensions_defined.py | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Piglit] [PATCH] framework/test/shader_test: Fix MultiShaderRunner handling of directories

Tested-by: Marek Olšák Marek On Wed, Nov 9, 2016 at 12:51 AM, Dylan Baker wrote: > Currently MultiShaderRunner (used with --process-isolation false) > expects each directory will contain either GL, GLES2, or GLES3 shaders. > The barrier between GLES2