[Piglit] cl/api/retain_release-event test and Clover's reference counting

2016-12-20 Thread Vedran Miletić
Hello, few days ago I looked into Clover failing Piglit's cl/api/retain_release-event test. I came up with a patch [1]. Clover actually keeps two references to a single event in the queue. Furthermore, the OpenCL specification [2] says: | The reference count returned should be considered

Re: [Piglit] [PATCH 3/3] arb_post_depth_coverage-sample-shading: Test sample shading.

2016-12-20 Thread Lionel Landwerlin
Hi Pam, With the small changed below, this is : Reviewed-by: Lionel Landwerlin Cheers, - Lionel On 22/11/16 22:04, Plamena Manolova wrote: A multisampling test with sample shading enabled to check whether the values written to gl_SampleMaskIn are still

Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

2016-12-20 Thread Lionel Landwerlin
This test is failing on my Kabylake laptop. Please check the comments below. Cheers, - Lionel On 22/11/16 22:03, Plamena Manolova wrote: A simple multisampling test to check whether the values written to gl_SampleMaskIn are still correct after enabling the ARB_post_depth_coverage extension.

Re: [Piglit] [PATCH 1/3] arb_post_depth_coverage-basic: Add a basic initial test.

2016-12-20 Thread Lionel Landwerlin
Hi Pam, Here are some tiny comments inline. With that updated this patch is : Reviewed-by: Lionel Landwerlin Cheers, - Lionel On 22/11/16 22:01, Plamena Manolova wrote: A basic test to check whether the values written to gl_SampleMaskIn are still correct