Re: [Piglit] [PATCH v2] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-10 Thread Tapani Pälli
Thanks; Reviewed-by: Tapani Pälli Do you have Mesa fix coming up for this? Maybe commit that at same time to avoid QA hassle or then mention in commit message that this is expected to fail currently. On 01/10/2017 05:12 PM, Micah Fedke wrote: This tests the following statement from EGL_KH

Re: [Piglit] [PATCH 3/3] arb_cull_distance: correction of result interpretation

2017-01-10 Thread Olender, Sebastian D
Mea culpa, You're right. -Original Message- From: Landwerlin, Lionel G Sent: Tuesday, January 10, 2017 3:46 PM To: Olender, Sebastian D ; piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH 3/3] arb_cull_distance: correction of result interpretation On 10/01/17 14:38, Sebastian O

[Piglit] [PATCH v2] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-10 Thread Micah Fedke
This tests the following statement from EGL_KHR_image_base.txt: If an attribute specified in is not one of the attributes listed in Table bbb, the error EGL_BAD_PARAMETER is generated. Signed-off-by: Micah Fedke --- tests/all.py | 2 + tests/egl/CMakeLists.gl.txt | 2 + tests

Re: [Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Lionel Landwerlin
Oh thanks, sorry I had no idea :) On 10/01/17 14:50, Olender, Sebastian D wrote: I'm running this on windows -Original Message- From: Landwerlin, Lionel G Sent: Tuesday, January 10, 2017 3:48 PM To: Olender, Sebastian D ; piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH 1/3] P

Re: [Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Olender, Sebastian D
I'm running this on windows -Original Message- From: Landwerlin, Lionel G Sent: Tuesday, January 10, 2017 3:48 PM To: Olender, Sebastian D ; piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH 1/3] PNG files, write mode correction The man page of fopen says : "This is strictly fo

Re: [Piglit] [PATCH 2/3] arb_texture_view_rendering-formats: fix wrong array initialization

2017-01-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 10/01/17 14:38, Sebastian Olender wrote: Signed-off-by: Sebastian Olender --- tests/spec/arb_texture_view/rendering-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_texture_view/rendering-formats.c b/tests/spec/a

Re: [Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Lionel Landwerlin
The man page of fopen says : "This is strictly for compatibility with C89 and has no effect; the 'b' is ignored on all POSIX conforming systems, including Linux." I don't know where you're running this, but sure :) Reviewed-by: Lionel Landwerlin On 10/01/17 14:38, Sebastian Olender wrote:

Re: [Piglit] [PATCH 3/3] arb_cull_distance: correction of result interpretation

2017-01-10 Thread Lionel Landwerlin
On 10/01/17 14:38, Sebastian Olender wrote: Signed-off-by: Sebastian Olender --- tests/spec/arb_cull_distance/exceed-limits.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_cull_distance/exceed-limits.c b/tests/spec/arb_cull_distance/exceed-limits.

Re: [Piglit] [PATCH] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-10 Thread Micah Fedke
You're right, I was testing it with the x11_egl platform only, where much of the EGL setup is done implicitly by waffle. Will resubmit an egl-util platform reroll. -mf On 01/10/2017 05:51 AM, Tapani Pälli wrote: This test does not work correctly for me (skips because EGL_KHR_image_base is u

[Piglit] [PATCH 2/3] arb_texture_view_rendering-formats: fix wrong array initialization

2017-01-10 Thread Sebastian Olender
Signed-off-by: Sebastian Olender --- tests/spec/arb_texture_view/rendering-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_texture_view/rendering-formats.c b/tests/spec/arb_texture_view/rendering-formats.c index 41b521a..44ab56b 100644 --- a/tests/spe

[Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Sebastian Olender
Signed-off-by: Sebastian Olender --- tests/util/piglit-util-png.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-util-png.c b/tests/util/piglit-util-png.c index 4835ed6..c63ec7b 100644 --- a/tests/util/piglit-util-png.c +++ b/tests/util/piglit-util-png.c @@

[Piglit] [PATCH 3/3] arb_cull_distance: correction of result interpretation

2017-01-10 Thread Sebastian Olender
Signed-off-by: Sebastian Olender --- tests/spec/arb_cull_distance/exceed-limits.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_cull_distance/exceed-limits.c b/tests/spec/arb_cull_distance/exceed-limits.c index 10fecb9..e68ad73 100644 --- a/tests/spec

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for INTEL_conservative_rasterization

2017-01-10 Thread Manolova, Plamena
Looks good to me :) Reviewed-by: Plamena Manolova > On Thu, Dec 1, 2016 at 3:51 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Signed-off-by: Lionel Landwerlin > --- > generated_tests/CMakeLists.txt | 4 + > .../gen_shader_intel_conservative_rasterization.

Re: [Piglit] [PATCH v3] Add GL_INTEL_conservative_rasterization tests

2017-01-10 Thread Manolova, Plamena
This looks good to me. Reviewed-by: Plamena Manolova > On Thu, Dec 8, 2016 at 10:55 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > This extension is a subset of GL_NV_conservative_raster, applying only > to polygons. > > v2: Drop wrongly added files from Plamena's work (Lionel) >

Re: [Piglit] [PATCH] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-10 Thread Tapani Pälli
This test does not work correctly for me (skips because EGL_KHR_image_base is unsupported even though driver supports it). I believe you either would need to utilize egl-util framework (check the other tests in egl directory) or initialize EGL manually ground up like some tests do. Or is this d