Re: [Piglit] [PATCH] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-11 Thread Tapani Pälli
On 01/11/2017 05:24 PM, Emil Velikov wrote: On 10 January 2017 at 10:51, Tapani Pälli wrote: This test does not work correctly for me (skips because EGL_KHR_image_base is unsupported even though driver supports it). I believe you either would need to utilize egl-util framework (check the othe

[Piglit] [PATCH 4/5] gl-4.5/named-framebuffer-draw-buffers-errors: add a new test

2017-01-11 Thread Alejandro Piñeiro
Equivalent to the already existing gl-3.1/draw-buffers-errors and spec/gles-2.0/draw-buffers, but using the 4.5 API. The errors are the same that with DrawBuffers so we are testing this method too, although indirectly. Used as reference OpenGL 4.5 spec, section 17.4.1 "Selecting Buffers for Writin

[Piglit] [PATCH 5/5] gl-4.5/named-framebuffer-read-buffer-errors: add test

2017-01-11 Thread Alejandro Piñeiro
All spec quotes come from OpenGL 4.5 spec, section 18.2.1 "Selecting Buffers for Reading", page 502 (524 on PDF). Note that the errors are the same that with glReadBuffer, so we are testing this method too, although indirectly. --- tests/all.py | 1 + tests

[Piglit] [PATCH 3/5] gl-3.1/draw-buffers-errors: select explicitly default framebuffer

2017-01-11 Thread Alejandro Piñeiro
The spec quote explicitly mentions the default framebuffer, so it makes sense to explicitly select it. This allows to get some answer different to INVALID_OPERATION for some of the buffers. --- tests/spec/gl-3.1/draw-buffers-errors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec

[Piglit] [PATCH 2/5] gl-3.1/draw-buffer-errors: skip if current Context is > 4.0

2017-01-11 Thread Alejandro Piñeiro
Behaviour and error list changed on OpenGL > 4.0. So much that it is worth to create a new 4.x test. So we skip if current context is > 4.0. --- tests/spec/gl-3.1/draw-buffers-errors.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/spec/gl-3.1/draw-buffers-errors.c b/tests/spec/

[Piglit] [PATCH 1/5] util: move SUBTEST and SUBTESTCONDITION to piglit-util

2017-01-11 Thread Alejandro Piñeiro
Defined on dsa-utils.h. Plan to use on other tests. --- tests/spec/arb_direct_state_access/dsa-utils.h | 16 tests/util/piglit-util.h | 23 +++ 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/tests/spec/arb_direct_state_ac

[Piglit] [PATCH v3] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-11 Thread Micah Fedke
This tests the following statement from EGL_KHR_image_base.txt: If an attribute specified in is not one of the attributes listed in Table bbb, the error EGL_BAD_PARAMETER is generated. Signed-off-by: Micah Fedke --- tests/all.py | 2 + tests/egl/CMakeLists.gl.txt | 2 + tes

Re: [Piglit] [PATCH] resume: use the previously-set test-list when resuming

2017-01-11 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Martin Peres (2017-01-11 07:45:48) > Previously, the test-list was not saved when running and resuming a run > would ignore the test-list and execute the entire test set. > > This patch tries to follow Dylan's proposal[0]. > > [0] https://patchwork.freedesktop.o

[Piglit] [PATCH] resume: use the previously-set test-list when resuming

2017-01-11 Thread Martin Peres
Previously, the test-list was not saved when running and resuming a run would ignore the test-list and execute the entire test set. This patch tries to follow Dylan's proposal[0]. [0] https://patchwork.freedesktop.org/patch/122189/ Cc: Rami Ben Hassine Cc: Olivier Berthier Cc: Julian Dumez Cc

Re: [Piglit] [PATCH] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

2017-01-11 Thread Emil Velikov
On 10 January 2017 at 10:51, Tapani Pälli wrote: > This test does not work correctly for me (skips because EGL_KHR_image_base > is unsupported even though driver supports it). I believe you either would > need to utilize egl-util framework (check the other tests in egl directory) > or initialize E